Re: [dpdk-dev] [PATCH] i40e:Fix for wrong publish of card speed (was mixed between 10G and 40G)

["Ido Barnea (ibarnea)" <ibarnea@cisco.com>]

Hi Jingjing,
The existing code was obviously wrong. 
For the XL710 it returned: ETH_LINK_SPEED_1G |ETH_LINK_SPEED_10G
And for the X710: ETH_LINK_SPEED_10G |ETH_LINK_SPEED_40G


I did a minimal fix, and swapped the lines.

Any fix that will return the correct values is welcome.
For my purpose your proposal is fine.

You want me to change my patch, or you will do it?

Thanks,
Ido



On 18/07/2016, 4:52 AM, "Wu, Jingjing" <jingjing.wu@intel.com> wrote:

>Hi, Barnea
>
>Thanks for the patch. But for 40G link, I think it should be
>dev_info->speed_capa = ETH_LINK_SPEED_40G.
>
>Thanks
>Jingjing
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ido Barnea (ibarnea)
>> Sent: Sunday, July 17, 2016 11:43 PM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] i40e:Fix for wrong publish of card speed (was
>> mixed between 10G and 40G)
>> 
>> Signed-off-by: Ido Barnea <ibarnea@cisco.com>
>> 
>> 
>> ---
>>  drivers/net/i40e/i40e_ethdev.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>> index 3f9f05e..64d60ef 100644
>> --- a/drivers/net/i40e/i40e_ethdev.c
>> +++ b/drivers/net/i40e/i40e_ethdev.c
>> @@ -2628,10 +2628,10 @@ i40e_dev_info_get(struct rte_eth_dev *dev,
>> struct rte_eth_dev_info *dev_info
>> 	if (i40e_is_40G_device(hw->device_id))		/* For XL710
>> */
>> 
>> -		dev_info->speed_capa = ETH_LINK_SPEED_1G |
>> ETH_LINK_SPEED_10G;
>> +		dev_info->speed_capa = ETH_LINK_SPEED_10G |
>> ETH_LINK_SPEED_40G;
>>  	else
>>  		/* For X710 */
>> -		dev_info->speed_capa = ETH_LINK_SPEED_10G |
>> ETH_LINK_SPEED_40G;
>> +		dev_info->speed_capa = ETH_LINK_SPEED_1G |
>> ETH_LINK_SPEED_10G;
>>  }
>> static int
>> --
>> 2.8.3