From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 407E1568F for ; Fri, 20 Mar 2015 16:07:32 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 20 Mar 2015 08:07:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,437,1422950400"; d="scan'208";a="683150781" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga001.fm.intel.com with ESMTP; 20 Mar 2015 08:07:30 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.103]) by IRSMSX153.ger.corp.intel.com ([169.254.9.234]) with mapi id 14.03.0195.001; Fri, 20 Mar 2015 15:07:30 +0000 From: "Butler, Siobhan A" To: Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [dpdk-dev] tools brainstorming Thread-Index: AQHQYx105wa2dYsDE0GLqygeszi7350leBBg Date: Fri, 20 Mar 2015 15:07:29 +0000 Message-ID: <0C5AFCA4B3408848ADF2A3073F7D8CC86D53E553@IRSMSX109.ger.corp.intel.com> References: <3571725.20GtF5MAnU@xps13> In-Reply-To: <3571725.20GtF5MAnU@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] tools brainstorming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2015 15:07:32 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, March 20, 2015 2:51 PM > To: dev@dpdk.org > Subject: [dpdk-dev] tools brainstorming >=20 > Hi, >=20 > As you probably know, a MAINTAINERS file is being filled, which is a grea= t > help to request patch reviews and discuss design with the knowledgeable > people of this young DPDK community: > http://dpdk.org/browse/dpdk/tree/MAINTAINERS >=20 > The next step is to clearly define what are the guidelines to review a pa= tch > and accept it. So let's write a new document CONTRIBUTING (or another > capitalized file ;). It will help contributors to do the right checks bef= ore > submitting, and will help reviewers. >=20 > As we are lazy developers, writing guidelines is not enough. It must be > coupled with the integration of some tools. Let's work on these ones: > - make autotests easier and faster to run for smoke testing > - automated basic testpmd check > - build check with various options combinations > - abi check (started with validate-abi.sh) > - static analyze (clang, free online coverity) > - comment check (doxygen, codespell, kerspell) > - format check (customized checkpatch) This is a great list Thomas, totally agree with you we need some guidelines= , and some ways of automating basic checks to catch basic issues, save time and traffic on the mailing list. I propose we also add a bug tracking tool (e.g. Bugzilla or other). And also a standalone page/document/archive of FAQ's. >=20 > I'm sure this last item will trigger a lot of debate. > Actually, format checking can be of two kinds: > - commit message formatting (how to write the title, how and when > adding > Fixes tag, Signed-off-by tag, etc); > - coding style might deserve its own document. >=20 > At the end, we should be able to pass a "make check" on the whole code an= d > a "make checkpatch" before submitting. > Then the result of these tools could be automatically checked and display= ed > in patchwork or in an adapted version of qemu's patchew. But this is > obviously a later step. > When all automatic lights are green and human design review is properly > done, the patch can be acknowledged by one or many reviewers. Speaking > about that, it would be helpful to have a column in our patchwork to > summarize the counts of tests, reviews and acknowledgements. >=20 > Comments and contributions are more than welcome!