DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Butler, Siobhan A" <siobhan.a.butler@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: add note for txqflags in testpmd UG
Date: Wed, 1 Apr 2015 12:21:08 +0000	[thread overview]
Message-ID: <0C5AFCA4B3408848ADF2A3073F7D8CC86D582FED@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <1427890211-30148-1-git-send-email-pablo.de.lara.guarch@intel.com>


> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Wednesday, April 1, 2015 1:10 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: add note for txqflags in testpmd UG
> 
> Since txqflags is now set from the default rx/tx configuration, depending on
> the PMD, it might not be 0.
> Therefore, user has to overwrite it with --txqflags 0.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  doc/guides/testpmd_app_ug/run_app.rst |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/doc/guides/testpmd_app_ug/run_app.rst
> b/doc/guides/testpmd_app_ug/run_app.rst
> index 6cbbf40..b29c176 100644
> --- a/doc/guides/testpmd_app_ug/run_app.rst
> +++ b/doc/guides/testpmd_app_ug/run_app.rst
> @@ -405,6 +405,12 @@ They must be separated from the EAL options,
> shown in the previous section, with
>      Set the hexadecimal bitmask of TX queue flags, where 0 <= N <=
> 0x7FFFFFFF.
>      The default value is 0.
> 
> +    Note::
> +
> +        When using hardware offload functions such as vlan, checksum...,
> +        add txqflags=0, since depending on the PMD,
> +        txqflags might be set to a non-zero value.
> +
>  *   --rx-queue-stats-
> mapping=(port,queue,mapping)[,(port,queue,mapping)]
> 
>      Set the RX queues statistics counters mapping 0 <= mapping <= 15.
> --
> 1.7.4.1

Thanks Pablo that wording is better
Acked-by Siobhan Butler <siobhan.a.butler@intel.com>

  reply	other threads:[~2015-04-01 12:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 12:10 Pablo de Lara
2015-04-01 12:21 ` Butler, Siobhan A [this message]
2015-04-01 19:25   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0C5AFCA4B3408848ADF2A3073F7D8CC86D582FED@IRSMSX109.ger.corp.intel.com \
    --to=siobhan.a.butler@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).