From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 0F0317F1C for ; Thu, 2 Apr 2015 16:37:16 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 02 Apr 2015 07:37:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,511,1422950400"; d="scan'208";a="702266136" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga002.fm.intel.com with ESMTP; 02 Apr 2015 07:37:15 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.95]) by IRSMSX107.ger.corp.intel.com ([169.254.10.137]) with mapi id 14.03.0224.002; Thu, 2 Apr 2015 15:37:14 +0100 From: "Butler, Siobhan A" To: "Xie, Huawei" , "Ouyang, Changchun" Thread-Topic: [dpdk-dev] [PATCH] mbuf: clean old refcnt option Thread-Index: AQHQa9x8yrO9avqbHkiiH8sE51DIHZ026LuAgAGbHACAAUk7AA== Date: Thu, 2 Apr 2015 14:37:13 +0000 Message-ID: <0C5AFCA4B3408848ADF2A3073F7D8CC86D5868FC@IRSMSX109.ger.corp.intel.com> References: <1427824702-5119-1-git-send-email-thomas.monjalon@6wind.com> <551AF4EF.5090104@6wind.com> <2662680.fVrczecCFl@xps13> In-Reply-To: <2662680.fVrczecCFl@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] mbuf: clean old refcnt option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2015 14:37:17 -0000 Huawei/Changchun can you please ack this patch or if you are not happy with= it ask for it to be deffered but it is blocking. Thank you=20 S > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, April 1, 2015 8:58 PM > To: Xie, Huawei; Ouyang, Changchun > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] mbuf: clean old refcnt option >=20 > 2015-03-31 21:26, Olivier MATZ: > > Hi Thomas, > > > > On 03/31/2015 07:58 PM, Thomas Monjalon wrote: > > > CONFIG_RTE_MBUF_SCATTER_GATHER was renamed into > > > CONFIG_RTE_MBUF_REFCNT by commit 62814bc2e923 and removed by > commit 4769bc5a27cc. > > > Some traces remain because of delayed patches. > > > > > > It can also be removed from doxygen config. > > > It is now poisoned in rte_mbuf.h to warn any misuse. > > > > > > Fixes: d0dff9ba445e ("doc: sample application user guide") > > > Fixes: fc1f2750a3ec ("doc: programmers guide") > > > Fixes: 4769bc5a27cc ("mbuf: remove build option to disable refcnt") > > > > > > Signed-off-by: Thomas Monjalon > [...] > > > --- a/doc/guides/sample_app_ug/vhost.rst > > > +++ b/doc/guides/sample_app_ug/vhost.rst > > > @@ -338,28 +338,6 @@ Compiling the Sample Code > > > > > > .. code-block:: console > > > > > > - make > > > - > > > - .. note:: > > > - > > > - Note For zero copy, need firstly disable > CONFIG_RTE_MBUF_SCATTER_GATHER, > > > - CONFIG_RTE_LIBRTE_IP_FRAG and > CONFIG_RTE_LIBRTE_DISTRIBUTOR > > > - in the config file and then re-configure and compile the cor= e lib, and > then build the application: > > > - > > > - .. code-block:: console > > > - > > > - vi ${RTE_SDK}/config/common_linuxapp > > > - > > > - change it as follows: > > > - > > > - :: > > > - > > > - CONFIG_RTE_MBUF_SCATTER_GATHER=3Dn > > > - CONFIG_RTE_LIBRTE_IP_FRAG=3Dn > > > - CONFIG_RTE_LIBRTE_DISTRIBUTOR=3Dn > > > - > > > - .. code-block:: console > > > - > > > cd ${RTE_SDK} > > > make config ${RTE_TARGET} > > > make install ${RTE_TARGET} >=20 > Note that make config is useless and T=3D is missing. >=20 > > I have one doubt about the vhost part, as the previous doc was telling > > to disable refcnt option and now the behavior is equivalent to having > > the option always enabled. Also you are removing parts of doc that > > talk about CONFIG_RTE_LIBRTE_DISTRIBUTOR and > CONFIG_RTE_LIBRTE_IP_FRAG. > > > > It would be safer to also have an acknowledgment from a vhost expert. >=20 > Huawei, Changchun, any opinion please?