From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id BF0315A54 for ; Wed, 8 Apr 2015 21:54:43 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 08 Apr 2015 12:54:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,545,1422950400"; d="scan'208";a="553071281" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga003.jf.intel.com with ESMTP; 08 Apr 2015 12:54:42 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.95]) by IRSMSX102.ger.corp.intel.com ([169.254.2.2]) with mapi id 14.03.0224.002; Wed, 8 Apr 2015 20:54:41 +0100 From: "Butler, Siobhan A" To: Thomas Monjalon , "Wiles, Keith" Thread-Topic: [dpdk-dev] tools brainstorming Thread-Index: AQHQYx105wa2dYsDE0GLqygeszi7351DCqJggABGtICAAAZUAIAATYiA Date: Wed, 8 Apr 2015 19:54:40 +0000 Message-ID: <0C5AFCA4B3408848ADF2A3073F7D8CC86D590392@IRSMSX109.ger.corp.intel.com> References: <3571725.20GtF5MAnU@xps13> <0C5AFCA4B3408848ADF2A3073F7D8CC86D58F9C2@IRSMSX109.ger.corp.intel.com> <2232884.6IKBPajdgE@xps13> In-Reply-To: <2232884.6IKBPajdgE@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] tools brainstorming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2015 19:54:44 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, April 8, 2015 5:16 PM > To: Wiles, Keith; Butler, Siobhan A > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] tools brainstorming >=20 > 2015-04-08 15:53, Wiles, Keith: > > One of the biggest problems with any style is helping the developer > > maintain the style. Using some tool does help and I have used astyle > > before, not bad code formatter. Here is a few that seem to be reasonabl= e. > > > > http://astyle.sourceforge.net/ > > > > http://uncrustify.sourceforge.net/ > > > > http://sourceforge.net/projects/gcgreatcode/ >=20 > I'm not sure it's a good idea to convert the codebase automatically. > The coding style must be a reference for new patches and they must be > automatically checked with a dedicated checkpatch tool. > By forbidding patches which don't comply, the codebase will be naturally > converted over time. >=20 > I didn't review this proposal yet. > My first comment is that it's too long to read :) When a consensus is don= e, it > must be added with a patch with custom checkpatch addition. Thanks Thomas, agreed it is a bit of a novel :)- I will refactor with the c= omments supplied so far and post a fresh version tomorrow. Siobhan=20