From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by dpdk.org (Postfix) with ESMTP id 86914B0AC for ; Tue, 10 Jun 2014 21:25:56 +0200 (CEST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 10 Jun 2014 12:26:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.98,1010,1392192000"; d="scan'208";a="443956109" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by azsmga001.ch.intel.com with ESMTP; 10 Jun 2014 12:26:08 -0700 Received: from irsmsx105.ger.corp.intel.com (163.33.3.28) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 10 Jun 2014 20:26:08 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.245]) by IRSMSX105.ger.corp.intel.com ([169.254.7.239]) with mapi id 14.03.0123.003; Tue, 10 Jun 2014 20:26:08 +0100 From: "Carew, Alan" To: Stephen Hemminger Thread-Topic: [PATCH 00/10] igb_uio patches Thread-Index: AQHPgc44FOC71onM5kqyc4P0fXLAYptqeVNggAAYd4CAABwtAA== Date: Tue, 10 Jun 2014 19:26:08 +0000 Message-ID: <0E29434AEE0C3A4180987AB476A6F630593A5F6C@IRSMSX101.ger.corp.intel.com> References: <20140606212644.203613327@networkplumber.org> <0E29434AEE0C3A4180987AB476A6F630593A5E2D@IRSMSX101.ger.corp.intel.com> <20140610104035.08d3946a@nehalam.linuxnetplumber.net> In-Reply-To: <20140610104035.08d3946a@nehalam.linuxnetplumber.net> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 00/10] igb_uio patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2014 19:25:57 -0000 -----Original Message----- From: Stephen Hemminger [mailto:stephen@networkplumber.org]=20 Sent: Tuesday, June 10, 2014 6:41 PM To: Carew, Alan Cc: dev@dpkd.org Subject: Re: [PATCH 00/10] igb_uio patches On Tue, 10 Jun 2014 15:33:31 +0000 "Carew, Alan" wrote: > Good catches and fixes in this set, would it be possible to refactor the = "enum igbuio_intr_mode" to a common header files as with http://dpdk.org/ml= /archives/dev/2014-June/003127.html Actually, thought that was ugly. The userspace shouldn't have to see all th= ese definitions. Not a big fan of doing this and it would go against goal of making a versio= n that could be merged upstream. Stephen, One alternative for us is then to take Neil Horman's idea of scanning /sys/= bus/pci/devices//msi_irqs/ This gives us at least (MSI | MSI-X) | INT-X, however the Virtio specificat= ion mentions MSI-X explicitly for determining the correct offset and might = not address the underlying problem my patch set was addressing, I have not = tried Virtio with MSI. A question then, how does uio_pci_generic handle interrupt modes in terms o= f userspace interface when determining the configured interrupt mode? In the short term while we still work with igb_uio we may have to rely on S= YSFS, but there is nothing stopping us from having device specific code pat= hs that does not exclude us from ignoring igb_uio. The shared headers also = gives us the benefit of having an internal interface(rte_pci_device: rte_in= tr_mode ) already in place when swapping out kernel drivers, Anatoly's VFI= O implementation already uses such an interface. Thanks, Alan