From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 50AAF1BA54 for ; Wed, 4 Apr 2018 04:02:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2018 19:02:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,404,1517904000"; d="scan'208";a="217332551" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 03 Apr 2018 19:02:50 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 3 Apr 2018 19:02:50 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 3 Apr 2018 19:02:50 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.43]) by shsmsx102.ccr.corp.intel.com ([169.254.2.61]) with mapi id 14.03.0319.002; Wed, 4 Apr 2018 10:02:48 +0800 From: "Xu, Rosen" To: "gaetan.rivet@6wind.com" CC: "dev@dpdk.org" , "Doherty, Declan" , "Richardson, Bruce" , "shreyansh.jain@nxp.com" , "Zhang, Tianfei" , "Wu, Hao" Thread-Topic: [PATCH v3 3/6] mk/rte.app.mk: Add Intel FPGA Bus Build Configuration Macro To App Script Thread-Index: AQHTxpir7jCdJcoocEeV+cGt/By4mKPv5IlQ Date: Wed, 4 Apr 2018 02:02:47 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D739F33E0A@SHSMSX104.ccr.corp.intel.com> References: <1521553556-62982-1-git-send-email-rosen.xu@intel.com> <1522229396-17898-1-git-send-email-rosen.xu@intel.com> <1522229396-17898-4-git-send-email-rosen.xu@intel.com> <20180328132834.pw7babp7o2uq7w23@bidouze.vm.6wind.com> In-Reply-To: <20180328132834.pw7babp7o2uq7w23@bidouze.vm.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmIxY2Y0ZTgtOTk4ZS00MjRlLTlhZjItZTcxMjQ0MjJkZjFlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkIwbkJlQmlzYmlVRnVQSGVERmU4d29QTjFOSENcL0xMRGdTa2ZoMWZ5U3hFPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 3/6] mk/rte.app.mk: Add Intel FPGA Bus Build Configuration Macro To App Script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 02:02:53 -0000 Hi Gaetan, > -----Original Message----- > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > Sent: Wednesday, March 28, 2018 21:29 > To: Xu, Rosen > Cc: dev@dpdk.org; Doherty, Declan ; > Richardson, Bruce ; shreyansh.jain@nxp.com; > Zhang, Tianfei ; Wu, Hao > Subject: Re: [PATCH v3 3/6] mk/rte.app.mk: Add Intel FPGA Bus Build > Configuration Macro To App Script >=20 > On Wed, Mar 28, 2018 at 05:29:53PM +0800, Rosen Xu wrote: > > Signed-off-by: Rosen Xu > > --- > > mk/rte.app.mk | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 3eb41d1..958b6b5 > > 100644 > > --- a/mk/rte.app.mk > > +++ b/mk/rte.app.mk > > @@ -107,6 +107,9 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_CMDLINE) +=3D - > lrte_cmdline > > _LDLIBS-$(CONFIG_RTE_LIBRTE_REORDER) +=3D -lrte_reorder > > _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED) +=3D -lrte_sched > > > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_IFPGA_BUS) +=3D -lrte_bus_ifpga > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_IFPGA_RAWDEV) +=3D - > lrte_ifpga_rawdev > > + >=20 > This however, should trigger a link error given that the relevant librari= es are > not yet available. Same as before, please squash with the patch introduci= ng > the libraries. I have fixed the link error comment in my PATCH v5. For squash comment I have fixed it in my PATCH v4. Are they ok? > > ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y) > > _LDLIBS-$(CONFIG_RTE_LIBRTE_KNI) +=3D -lrte_kni > > endif > > -- > > 1.8.3.1 > > >=20 > -- > Ga=EBtan Rivet > 6WIND