From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 452F01BACB for ; Thu, 10 May 2018 15:16:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2018 06:16:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,385,1520924400"; d="scan'208";a="44816102" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 10 May 2018 06:16:55 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 10 May 2018 06:16:54 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 10 May 2018 06:16:54 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.240]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.40]) with mapi id 14.03.0319.002; Thu, 10 May 2018 21:16:51 +0800 From: "Xu, Rosen" To: "Wu, Jingjing" , "dev@dpdk.org" , "thomas@monjalon.net" CC: "Zhang, Roy Fan" , "Doherty, Declan" , "Richardson, Bruce" , "shreyansh.jain@nxp.com" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "Zhang, Tianfei" , "Liu, Song" , "Wu, Hao" , "gaetan.rivet@6wind.com" , "Wu, Yanglong" Thread-Topic: [dpdk-dev] [PATCH v10 3/3] iFPGA: Add Intel FPGA BUS Rawdev Driver Thread-Index: AQHT52listbL4KkKj02spJgpOwv+yqQonRbQgABKAyA= Date: Thu, 10 May 2018 13:16:50 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D739FD14DF@SHSMSX104.ccr.corp.intel.com> References: <1521553556-62982-1-git-send-email-rosen.xu@intel.com> <1525851801-16101-1-git-send-email-rosen.xu@intel.com> <1525851801-16101-4-git-send-email-rosen.xu@intel.com> <9BB6961774997848B5B42BEC655768F81108ED12@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F81108ED12@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGQ5ODY3YzktZmM0YS00ZmYxLWJjNWQtNzE3OTI2ZjQ5NTU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJLb3BlS2lCVTdmbHBudHd1QWh0V01zU3NQbXVHQm5yS3BVWTMyZ1VLVDNyZ0lJMXdmK1wvcG5GbmF5Q3VRY0RoOCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v10 3/3] iFPGA: Add Intel FPGA BUS Rawdev Driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 13:16:56 -0000 Hi Jingjing, > -----Original Message----- > From: Wu, Jingjing > Sent: Thursday, May 10, 2018 17:21 > To: Xu, Rosen ; dev@dpdk.org; thomas@monjalon.net > Cc: Xu, Rosen ; Zhang, Roy Fan > ; Doherty, Declan ; > Richardson, Bruce ; shreyansh.jain@nxp.com; > Yigit, Ferruh ; Ananyev, Konstantin > ; Zhang, Tianfei ; > Liu, Song ; Wu, Hao ; > gaetan.rivet@6wind.com; Wu, Yanglong > Subject: RE: [dpdk-dev] [PATCH v10 3/3] iFPGA: Add Intel FPGA BUS Rawdev > Driver >=20 > Hi, Rosen >=20 > Few comments below. Thanks a lot. > Thanks > Jingjing >=20 > [...] >=20 > > +static int > > +ifpga_rawdev_start(struct rte_rawdev *dev) { > > + int ret =3D 0; > > + struct opae_adapter *adapter; > > + > > + IFPGA_RAWDEV_PMD_FUNC_TRACE(); > > + > > + RTE_FUNC_PTR_OR_ERR_RET(dev, -EINVAL); > > + > > + adapter =3D ifpga_rawdev_get_priv(dev); > > + if (!adapter) > > + return -ENODEV; > > + > Set dev->started? Rawdev lib enable it. > > + return ret; > > +} >=20 >=20 > [...] >=20 > > + > > +static const struct rte_rawdev_ops ifpga_rawdev_ops =3D { > > + .dev_info_get =3D ifpga_rawdev_info_get, > > + .dev_configure =3D NULL, > If go the declaration of rte_rawdev_configure, you will see "This functio= n > must be invoked first before any other function in the API." > So I think we need to function for it, even it does nothing. For other Rawdev Drivers, no used function pointer is initialized with NULL= . >=20 > [...] >=20 > > +static struct rte_pci_driver rte_ifpga_rawdev_pmd =3D { > > + .id_table =3D pci_ifpga_map, > > + .drv_flags =3D RTE_PCI_DRV_NEED_MAPPING | > RTE_PCI_DRV_INTR_LSC, > Is RTE_PCI_DRV_INTR_LSC supported? >=20 > [...] >=20 > > +static struct rte_vdev_driver ifpga_cfg_driver =3D { > > + .probe =3D ifpga_cfg_probe, > > + .remove =3D ifpga_cfg_remove, > > +}; > > + > > +RTE_PMD_REGISTER_VDEV(net_ifpga_cfg, ifpga_cfg_driver); > I think prefix net_ would mean the device is net device (eth_dev)? How ab= out > to change the prefix to raw_? I have fixed it both in code and document. > > +RTE_PMD_REGISTER_ALIAS(net_ifpga_cfg, ifpga_cfg); > > +RTE_PMD_REGISTER_PARAM_STRING(net_ifpga_cfg, > > + "bdf=3D " > ifpga=3D? > > + "port=3D " > > + "afu_bts=3D"); > > +