From: "Xu, Rosen" <rosen.xu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Zhang, Tianfei" <tianfei.zhang@intel.com>,
"Liu, Song" <song.liu@intel.com>, "Wu, Hao" <hao.wu@intel.com>,
"gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue
Date: Tue, 22 May 2018 10:42:50 +0000 [thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D73A00BDBD@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1913991.jNxr5nhODZ@xps>
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, May 21, 2018 22:23
> To: Xu, Rosen <rosen.xu@intel.com>
> Cc: dev@dpdk.org; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Doherty,
> Declan <declan.doherty@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; shreyansh.jain@nxp.com; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Zhang, Tianfei <tianfei.zhang@intel.com>;
> Liu, Song <song.liu@intel.com>; Wu, Hao <hao.wu@intel.com>;
> gaetan.rivet@6wind.com
> Subject: Re: [dpdk-stable] [PATCH] drivers/raw/ifpga_rawdev: fix coverity
> issue
>
> 16/05/2018 15:53, Rosen Xu:
> > Fix coverity issue: 279449
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> >
> > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> > Coverity issue: 279449
> > Cc: stable@dpdk.org
>
> Not for stable
>
> > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> > @@ -227,7 +227,7 @@
> > int file_fd;
> > int ret = 0;
> > ssize_t buffer_size;
> > - void *buffer;
> > + void *buffer = NULL;
>
> It is not fixing anything.
> This variable cannot be read before being written.
Yes, it's a scripts error.
This patch can be cancelled.
prev parent reply other threads:[~2018-05-22 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 13:53 [dpdk-dev] " Rosen Xu
2018-05-21 14:22 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-05-22 10:42 ` Xu, Rosen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E78D399C70DA940A335608C6ED296D73A00BDBD@SHSMSX104.ccr.corp.intel.com \
--to=rosen.xu@intel.com \
--cc=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=hao.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=shreyansh.jain@nxp.com \
--cc=song.liu@intel.com \
--cc=thomas@monjalon.net \
--cc=tianfei.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).