* [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue
@ 2018-05-16 13:53 Rosen Xu
2018-05-21 14:22 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Rosen Xu @ 2018-05-16 13:53 UTC (permalink / raw)
To: dev, thomas
Cc: rosen.xu, roy.fan.zhang, declan.doherty, bruce.richardson,
shreyansh.jain, ferruh.yigit, konstantin.ananyev, tianfei.zhang,
song.liu, hao.wu, gaetan.rivet, stable
Fix coverity issue: 279449
Signed-off-by: Rosen Xu <rosen.xu@intel.com>
Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
Coverity issue: 279449
Cc: stable@dpdk.org
---
drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
index 030ed1b..0e94861 100644
--- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
+++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
@@ -227,7 +227,7 @@
int file_fd;
int ret = 0;
ssize_t buffer_size;
- void *buffer;
+ void *buffer = NULL;
u64 pr_error;
if (!file_name)
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue
2018-05-16 13:53 [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue Rosen Xu
@ 2018-05-21 14:22 ` Thomas Monjalon
2018-05-22 10:42 ` Xu, Rosen
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2018-05-21 14:22 UTC (permalink / raw)
To: Rosen Xu
Cc: dev, roy.fan.zhang, declan.doherty, bruce.richardson,
shreyansh.jain, ferruh.yigit, konstantin.ananyev, tianfei.zhang,
song.liu, hao.wu, gaetan.rivet
16/05/2018 15:53, Rosen Xu:
> Fix coverity issue: 279449
>
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
>
> Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> Coverity issue: 279449
> Cc: stable@dpdk.org
Not for stable
> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> @@ -227,7 +227,7 @@
> int file_fd;
> int ret = 0;
> ssize_t buffer_size;
> - void *buffer;
> + void *buffer = NULL;
It is not fixing anything.
This variable cannot be read before being written.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue
2018-05-21 14:22 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
@ 2018-05-22 10:42 ` Xu, Rosen
0 siblings, 0 replies; 3+ messages in thread
From: Xu, Rosen @ 2018-05-22 10:42 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, Zhang, Roy Fan, Doherty, Declan, Richardson, Bruce,
shreyansh.jain, Yigit, Ferruh, Ananyev, Konstantin, Zhang,
Tianfei, Liu, Song, Wu, Hao, gaetan.rivet
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, May 21, 2018 22:23
> To: Xu, Rosen <rosen.xu@intel.com>
> Cc: dev@dpdk.org; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Doherty,
> Declan <declan.doherty@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; shreyansh.jain@nxp.com; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Zhang, Tianfei <tianfei.zhang@intel.com>;
> Liu, Song <song.liu@intel.com>; Wu, Hao <hao.wu@intel.com>;
> gaetan.rivet@6wind.com
> Subject: Re: [dpdk-stable] [PATCH] drivers/raw/ifpga_rawdev: fix coverity
> issue
>
> 16/05/2018 15:53, Rosen Xu:
> > Fix coverity issue: 279449
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> >
> > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> > Coverity issue: 279449
> > Cc: stable@dpdk.org
>
> Not for stable
>
> > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> > @@ -227,7 +227,7 @@
> > int file_fd;
> > int ret = 0;
> > ssize_t buffer_size;
> > - void *buffer;
> > + void *buffer = NULL;
>
> It is not fixing anything.
> This variable cannot be read before being written.
Yes, it's a scripts error.
This patch can be cancelled.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-22 10:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-16 13:53 [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue Rosen Xu
2018-05-21 14:22 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-05-22 10:42 ` Xu, Rosen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).