From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A2848235; Sun, 22 Jul 2018 12:37:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2018 03:37:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,389,1526367600"; d="scan'208";a="69166832" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 22 Jul 2018 03:37:48 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 22 Jul 2018 03:37:47 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 22 Jul 2018 03:37:47 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.81]) by shsmsx102.ccr.corp.intel.com ([169.254.2.124]) with mapi id 14.03.0319.002; Sun, 22 Jul 2018 18:37:44 +0800 From: "Xu, Rosen" To: Ori Kam , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Gilmore, Walter E" , "Zhang, Qi Z" , "stable@dpdk.org" Thread-Topic: [PATCH v2] examples/flow_filtering: add rte_fdir_conf initialization Thread-Index: AQHUIMfB44HnX72M20KYJuGwVcpgk6SaRDsAgADKBqA= Date: Sun, 22 Jul 2018 10:37:42 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A163037@SHSMSX104.ccr.corp.intel.com> References: <1531361387-116027-1-git-send-email-rosen.xu@intel.com> <1532159404-88843-1-git-send-email-rosen.xu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjFjMWZjMTUtNzM1Yy00MWJjLWIwZDMtODlkZTc3ZWE2YzNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNHdDTGVzZXM1Z294N0xtell5cUk3S013dWtkV1ByOFhpTUJPamNzRU9BcDVaQndXbk9VYjZBM3R6NTBPM09lTSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: add rte_fdir_conf initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jul 2018 10:37:57 -0000 Hi, I have fixed it, thanks. > -----Original Message----- > From: Ori Kam [mailto:orika@mellanox.com] > Sent: Sunday, July 22, 2018 14:34 > To: Xu, Rosen ; dev@dpdk.org > Cc: Yigit, Ferruh ; Gilmore, Walter E > ; Zhang, Qi Z ; > stable@dpdk.org > Subject: RE: [PATCH v2] examples/flow_filtering: add rte_fdir_conf > initialization >=20 >=20 >=20 > > -----Original Message----- > > From: Rosen Xu [mailto:rosen.xu@intel.com] > > Sent: Saturday, July 21, 2018 10:50 AM > > To: dev@dpdk.org > > Cc: rosen.xu@intel.com; ferruh.yigit@intel.com; Ori Kam > > ; walter.e.gilmore@intel.com; > > qi.z.zhang@intel.com; stable@dpdk.org > > Subject: [PATCH v2] examples/flow_filtering: add rte_fdir_conf > > initialization > > > > Rte_fdir_conf of rte_eth_conf should be initialized before port > > initialization. It is a workaround solution when work with Intel I40e. > > > > Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow > > API") > > Cc: stable@dpdk.org > > > > Signed-off-by: Rosen Xu > > > > v2 updates: > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > - Take more test on I40e > > - Add comments > > --- > > examples/flow_filtering/main.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/examples/flow_filtering/main.c > > b/examples/flow_filtering/main.c index f595034..73d646c 100644 > > --- a/examples/flow_filtering/main.c > > +++ b/examples/flow_filtering/main.c > > @@ -132,6 +132,17 @@ > > DEV_TX_OFFLOAD_SCTP_CKSUM | > > DEV_TX_OFFLOAD_TCP_TSO, > > }, > > + /* > > + * Initialize fdir_conf of ete_eth_conf > > + * it is a workaround solution when work with Intel I40e > > + * and it is not the normal way > > + */ > > + .fdir_conf =3D { > > + .mode =3D RTE_FDIR_MODE_PERFECT, > > + .pballoc =3D RTE_FDIR_PBALLOC_64K, > > + .status =3D RTE_FDIR_REPORT_STATUS, > > + .drop_queue =3D 127, > > + }, > > }; > > struct rte_eth_txconf txq_conf; > > struct rte_eth_rxconf rxq_conf; > > -- > > 1.8.3.1 >=20 > Just small comment I think work should be replaced with working. > Both in the commit log and code comment. It's fixed. > Acked-by: Ori Kam >=20 > Thanks, > Ori