From: "Xu, Rosen" <rosen.xu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Zhang, Tianfei" <tianfei.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] bus/ifpga: remove useless driver cast
Date: Wed, 26 Sep 2018 00:25:28 +0000 [thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D73A28D790@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20180925220828.11882-1-thomas@monjalon.net>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, September 26, 2018 6:08
> To: Xu, Rosen <rosen.xu@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] bus/ifpga: remove useless driver cast
>
> The rte_afu_driver is assigned to rte_afu_device.driver during probing.
> There is no need of accessing the rte_afu_driver via rte_device.driver and
> type casting to its container.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> drivers/bus/ifpga/ifpga_bus.c | 6 ++----
> drivers/bus/ifpga/rte_bus_ifpga.h | 3 ---
> 2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
> index 207aea152..a10f54f7b 100644
> --- a/drivers/bus/ifpga/ifpga_bus.c
> +++ b/drivers/bus/ifpga/ifpga_bus.c
> @@ -349,16 +349,14 @@ static int
> ifpga_remove_driver(struct rte_afu_device *afu_dev) {
> const char *name;
> - const struct rte_afu_driver *driver;
>
> name = rte_ifpga_device_name(afu_dev);
> - if (!afu_dev->device.driver) {
> + if (afu_dev->driver == NULL) {
> IFPGA_BUS_DEBUG("no driver attach to device %s\n", name);
> return 1;
> }
>
> - driver = RTE_DRV_TO_AFU_CONST(afu_dev->device.driver);
> - return driver->remove(afu_dev);
> + return afu_dev->driver->remove(afu_dev);
> }
>
> static int
> diff --git a/drivers/bus/ifpga/rte_bus_ifpga.h
> b/drivers/bus/ifpga/rte_bus_ifpga.h
> index 51d5ae0d9..d53c0f483 100644
> --- a/drivers/bus/ifpga/rte_bus_ifpga.h
> +++ b/drivers/bus/ifpga/rte_bus_ifpga.h
> @@ -83,9 +83,6 @@ struct rte_afu_device { #define RTE_DEV_TO_AFU(ptr)
> \
> container_of(ptr, struct rte_afu_device, device)
>
> -#define RTE_DRV_TO_AFU_CONST(ptr) \
> - container_of(ptr, const struct rte_afu_driver, driver)
> -
> /**
> * Initialization function for the driver called during FPGA BUS probing.
> */
> --
> 2.19.0
Acked-by: Rosen Xu <rosen.xu@intel.com>
next prev parent reply other threads:[~2018-09-26 0:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 22:08 Thomas Monjalon
2018-09-26 0:25 ` Xu, Rosen [this message]
2018-09-27 12:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E78D399C70DA940A335608C6ED296D73A28D790@SHSMSX104.ccr.corp.intel.com \
--to=rosen.xu@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=tianfei.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).