From: "Xu, Rosen" <rosen.xu@intel.com>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/test-pmd: expand test-pmd queue threshold size of RED parameters
Date: Tue, 4 Dec 2018 13:00:29 +0000 [thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D73A403D76@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <54CBAA185211B4429112C315DA58FF6D3366840C@IRSMSX103.ger.corp.intel.com>
> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Tuesday, December 04, 2018 20:29
> To: Xu, Rosen <rosen.xu@intel.com>; dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Wu,
> Jingjing <jingjing.wu@intel.com>
> Subject: RE: [PATCH] app/test-pmd: expand test-pmd queue threshold size of
> RED parameters
>
>
>
> > -----Original Message-----
> > From: Xu, Rosen
> > Sent: Monday, November 26, 2018 8:36 AM
> > To: dev@dpdk.org
> > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>;
> > Xu, Rosen <rosen.xu@intel.com>; Yigit, Ferruh
> > <ferruh.yigit@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> > Subject: [PATCH] app/test-pmd: expand test-pmd queue threshold size of
> > RED parameters
> >
> > There's very commonly that more than 4G DDR memory in NIC for HQoS,
> so
> > right now the queue threshold size of RED needs to expand to uint64_t.
> > For struct rte_tm_red_params, it has been fixed, but for test-pmd TM
> > configuration, it hasn't been fixed. This patch fixes it.
> >
> > Fixes: bddc2f40b594 ("app/testpmd: add commands for shaper and wred
> > profiles")
> > Cc: jasvinder.singh@intel.com
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > ---
> > app/test-pmd/cmdline_tm.c | 24 ++++++++++++------------
> > 1 file changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c
> > index
> > 4c76348..1012084 100644
> > --- a/app/test-pmd/cmdline_tm.c
> > +++ b/app/test-pmd/cmdline_tm.c
> > @@ -1156,18 +1156,18 @@ struct
> > cmd_add_port_tm_node_wred_profile_result {
> > uint16_t port_id;
> > uint32_t wred_profile_id;
> > cmdline_fixed_string_t color_g;
> > - uint16_t min_th_g;
> > - uint16_t max_th_g;
> > + uint64_t min_th_g;
> > + uint64_t max_th_g;
> > uint16_t maxp_inv_g;
> > uint16_t wq_log2_g;
> > cmdline_fixed_string_t color_y;
> > - uint16_t min_th_y;
> > - uint16_t max_th_y;
> > + uint64_t min_th_y;
> > + uint64_t max_th_y;
> > uint16_t maxp_inv_y;
> > uint16_t wq_log2_y;
> > cmdline_fixed_string_t color_r;
> > - uint16_t min_th_r;
> > - uint16_t max_th_r;
> > + uint64_t min_th_r;
> > + uint64_t max_th_r;
> > uint16_t maxp_inv_r;
> > uint16_t wq_log2_r;
> > };
> > @@ -1206,11 +1206,11 @@ struct
> > cmd_add_port_tm_node_wred_profile_result
> { cmdline_parse_token_num_t
> > cmd_add_port_tm_node_wred_profile_min_th_g =
> > TOKEN_NUM_INITIALIZER(
> > struct cmd_add_port_tm_node_wred_profile_result,
> > - min_th_g, UINT16);
> > + min_th_g, UINT64);
> > cmdline_parse_token_num_t
> > cmd_add_port_tm_node_wred_profile_max_th_g =
> > TOKEN_NUM_INITIALIZER(
> > struct cmd_add_port_tm_node_wred_profile_result,
> > - max_th_g, UINT16);
> > + max_th_g, UINT64);
> > cmdline_parse_token_num_t
> > cmd_add_port_tm_node_wred_profile_maxp_inv_g =
> > TOKEN_NUM_INITIALIZER(
> > struct cmd_add_port_tm_node_wred_profile_result,
> > @@ -1226,11 +1226,11 @@ struct
> > cmd_add_port_tm_node_wred_profile_result
> { cmdline_parse_token_num_t
> > cmd_add_port_tm_node_wred_profile_min_th_y =
> > TOKEN_NUM_INITIALIZER(
> > struct cmd_add_port_tm_node_wred_profile_result,
> > - min_th_y, UINT16);
> > + min_th_y, UINT64);
> > cmdline_parse_token_num_t
> > cmd_add_port_tm_node_wred_profile_max_th_y =
> > TOKEN_NUM_INITIALIZER(
> > struct cmd_add_port_tm_node_wred_profile_result,
> > - max_th_y, UINT16);
> > + max_th_y, UINT64);
> > cmdline_parse_token_num_t
> > cmd_add_port_tm_node_wred_profile_maxp_inv_y =
> > TOKEN_NUM_INITIALIZER(
> > struct cmd_add_port_tm_node_wred_profile_result,
> > @@ -1246,11 +1246,11 @@ struct
> > cmd_add_port_tm_node_wred_profile_result
> { cmdline_parse_token_num_t
> > cmd_add_port_tm_node_wred_profile_min_th_r =
> > TOKEN_NUM_INITIALIZER(
> > struct cmd_add_port_tm_node_wred_profile_result,
> > - min_th_r, UINT16);
> > + min_th_r, UINT64);
> > cmdline_parse_token_num_t
> > cmd_add_port_tm_node_wred_profile_max_th_r =
> > TOKEN_NUM_INITIALIZER(
> > struct cmd_add_port_tm_node_wred_profile_result,
> > - max_th_r, UINT16);
> > + max_th_r, UINT64);
> > cmdline_parse_token_num_t
> > cmd_add_port_tm_node_wred_profile_maxp_inv_r =
> > TOKEN_NUM_INITIALIZER(
> > struct cmd_add_port_tm_node_wred_profile_result,
> > --
>
>
> Reviewed-by: Jasvinder Singh <jasvinder.singh@intel.com>
>
Thanks
next prev parent reply other threads:[~2018-12-04 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 8:35 Rosen Xu
2018-12-04 12:28 ` Singh, Jasvinder
2018-12-04 13:00 ` Xu, Rosen [this message]
2018-12-20 19:07 ` Dumitrescu, Cristian
2018-12-21 0:40 ` Xu, Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E78D399C70DA940A335608C6ED296D73A403D76@SHSMSX104.ccr.corp.intel.com \
--to=rosen.xu@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jasvinder.singh@intel.com \
--cc=jingjing.wu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).