From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7DD5C1B200 for ; Tue, 4 Dec 2018 14:00:36 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2018 05:00:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,314,1539673200"; d="scan'208";a="115931417" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 04 Dec 2018 05:00:34 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Dec 2018 05:00:34 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 4 Dec 2018 05:00:33 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.203]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.176]) with mapi id 14.03.0415.000; Tue, 4 Dec 2018 21:00:30 +0800 From: "Xu, Rosen" To: "Singh, Jasvinder" , "dev@dpdk.org" CC: "Dumitrescu, Cristian" , "Lu, Wenzhuo" , "Yigit, Ferruh" , "Wu, Jingjing" Thread-Topic: [PATCH] app/test-pmd: expand test-pmd queue threshold size of RED parameters Thread-Index: AQHUhWO0UoqBZQJoQEG808jqCZU68qVujpLQgAAJOuA= Date: Tue, 4 Dec 2018 13:00:29 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A403D76@SHSMSX104.ccr.corp.intel.com> References: <1543221357-79801-1-git-send-email-rosen.xu@intel.com> <54CBAA185211B4429112C315DA58FF6D3366840C@IRSMSX103.ger.corp.intel.com> In-Reply-To: <54CBAA185211B4429112C315DA58FF6D3366840C@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODg3ODkwM2UtOGE2Yy00NTEwLWJiNzctYTczYmE4NTI1NzdlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN0xsNFwva0Y0d2hvQ3pxZDQ2d2hqeXp3bSs4NXVENjYrZU9vdWlPVlFBMmgwSURpUzcrTEgrTG1aS2tua3lYMHMifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/test-pmd: expand test-pmd queue threshold size of RED parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2018 13:00:37 -0000 > -----Original Message----- > From: Singh, Jasvinder > Sent: Tuesday, December 04, 2018 20:29 > To: Xu, Rosen ; dev@dpdk.org > Cc: Dumitrescu, Cristian ; Lu, Wenzhuo > ; Yigit, Ferruh ; Wu, > Jingjing > Subject: RE: [PATCH] app/test-pmd: expand test-pmd queue threshold size o= f > RED parameters >=20 >=20 >=20 > > -----Original Message----- > > From: Xu, Rosen > > Sent: Monday, November 26, 2018 8:36 AM > > To: dev@dpdk.org > > Cc: Dumitrescu, Cristian ; Lu, Wenzhuo > > ; Singh, Jasvinder ; > > Xu, Rosen ; Yigit, Ferruh > > ; Wu, Jingjing > > Subject: [PATCH] app/test-pmd: expand test-pmd queue threshold size of > > RED parameters > > > > There's very commonly that more than 4G DDR memory in NIC for HQoS, > so > > right now the queue threshold size of RED needs to expand to uint64_t. > > For struct rte_tm_red_params, it has been fixed, but for test-pmd TM > > configuration, it hasn't been fixed. This patch fixes it. > > > > Fixes: bddc2f40b594 ("app/testpmd: add commands for shaper and wred > > profiles") > > Cc: jasvinder.singh@intel.com > > > > Signed-off-by: Rosen Xu > > --- > > app/test-pmd/cmdline_tm.c | 24 ++++++++++++------------ > > 1 file changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c > > index > > 4c76348..1012084 100644 > > --- a/app/test-pmd/cmdline_tm.c > > +++ b/app/test-pmd/cmdline_tm.c > > @@ -1156,18 +1156,18 @@ struct > > cmd_add_port_tm_node_wred_profile_result { > > uint16_t port_id; > > uint32_t wred_profile_id; > > cmdline_fixed_string_t color_g; > > - uint16_t min_th_g; > > - uint16_t max_th_g; > > + uint64_t min_th_g; > > + uint64_t max_th_g; > > uint16_t maxp_inv_g; > > uint16_t wq_log2_g; > > cmdline_fixed_string_t color_y; > > - uint16_t min_th_y; > > - uint16_t max_th_y; > > + uint64_t min_th_y; > > + uint64_t max_th_y; > > uint16_t maxp_inv_y; > > uint16_t wq_log2_y; > > cmdline_fixed_string_t color_r; > > - uint16_t min_th_r; > > - uint16_t max_th_r; > > + uint64_t min_th_r; > > + uint64_t max_th_r; > > uint16_t maxp_inv_r; > > uint16_t wq_log2_r; > > }; > > @@ -1206,11 +1206,11 @@ struct > > cmd_add_port_tm_node_wred_profile_result > { cmdline_parse_token_num_t > > cmd_add_port_tm_node_wred_profile_min_th_g =3D > > TOKEN_NUM_INITIALIZER( > > struct cmd_add_port_tm_node_wred_profile_result, > > - min_th_g, UINT16); > > + min_th_g, UINT64); > > cmdline_parse_token_num_t > > cmd_add_port_tm_node_wred_profile_max_th_g =3D > > TOKEN_NUM_INITIALIZER( > > struct cmd_add_port_tm_node_wred_profile_result, > > - max_th_g, UINT16); > > + max_th_g, UINT64); > > cmdline_parse_token_num_t > > cmd_add_port_tm_node_wred_profile_maxp_inv_g =3D > > TOKEN_NUM_INITIALIZER( > > struct cmd_add_port_tm_node_wred_profile_result, > > @@ -1226,11 +1226,11 @@ struct > > cmd_add_port_tm_node_wred_profile_result > { cmdline_parse_token_num_t > > cmd_add_port_tm_node_wred_profile_min_th_y =3D > > TOKEN_NUM_INITIALIZER( > > struct cmd_add_port_tm_node_wred_profile_result, > > - min_th_y, UINT16); > > + min_th_y, UINT64); > > cmdline_parse_token_num_t > > cmd_add_port_tm_node_wred_profile_max_th_y =3D > > TOKEN_NUM_INITIALIZER( > > struct cmd_add_port_tm_node_wred_profile_result, > > - max_th_y, UINT16); > > + max_th_y, UINT64); > > cmdline_parse_token_num_t > > cmd_add_port_tm_node_wred_profile_maxp_inv_y =3D > > TOKEN_NUM_INITIALIZER( > > struct cmd_add_port_tm_node_wred_profile_result, > > @@ -1246,11 +1246,11 @@ struct > > cmd_add_port_tm_node_wred_profile_result > { cmdline_parse_token_num_t > > cmd_add_port_tm_node_wred_profile_min_th_r =3D > > TOKEN_NUM_INITIALIZER( > > struct cmd_add_port_tm_node_wred_profile_result, > > - min_th_r, UINT16); > > + min_th_r, UINT64); > > cmdline_parse_token_num_t > > cmd_add_port_tm_node_wred_profile_max_th_r =3D > > TOKEN_NUM_INITIALIZER( > > struct cmd_add_port_tm_node_wred_profile_result, > > - max_th_r, UINT16); > > + max_th_r, UINT64); > > cmdline_parse_token_num_t > > cmd_add_port_tm_node_wred_profile_maxp_inv_r =3D > > TOKEN_NUM_INITIALIZER( > > struct cmd_add_port_tm_node_wred_profile_result, > > -- >=20 >=20 > Reviewed-by: Jasvinder Singh >=20 Thanks