DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xu, Rosen" <rosen.xu@intel.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
	"Singh, Jasvinder" <jasvinder.singh@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/test-pmd: expand test-pmd queue threshold size of RED parameters
Date: Fri, 21 Dec 2018 00:40:12 +0000	[thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D73A45B0C0@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E817FE5@IRSMSX108.ger.corp.intel.com>

Thanks Cristian.

> -----Original Message-----
> From: Dumitrescu, Cristian
> Sent: Friday, December 21, 2018 3:08
> To: Xu, Rosen <rosen.xu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Subject: RE: [PATCH] app/test-pmd: expand test-pmd queue threshold size of
> RED parameters
> 
> 
> > > > -----Original Message-----
> > > > From: Xu, Rosen
> > > > Sent: Monday, November 26, 2018 8:36 AM
> > > > To: dev@dpdk.org
> > > > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Lu,
> > > > Wenzhuo <wenzhuo.lu@intel.com>; Singh, Jasvinder
> > > > <jasvinder.singh@intel.com>; Xu, Rosen <rosen.xu@intel.com>;
> > > > Yigit, Ferruh <ferruh.yigit@intel.com>; Wu, Jingjing
> > > > <jingjing.wu@intel.com>
> > > > Subject: [PATCH] app/test-pmd: expand test-pmd queue threshold
> > > > size
> > of
> > > > RED parameters
> > > >
> > > > There's very commonly that more than 4G DDR memory in NIC for
> > > > HQoS,
> > > so
> > > > right now the queue threshold size of RED needs to expand to uint64_t.
> > > > For struct rte_tm_red_params, it has been fixed, but for test-pmd
> > > > TM configuration, it hasn't been fixed. This patch fixes it.
> > > >
> > > > Fixes: bddc2f40b594 ("app/testpmd: add commands for shaper and
> > > > wred
> > > > profiles")
> > > > Cc: jasvinder.singh@intel.com
> > > >
> > > > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > > > ---
> > > >  app/test-pmd/cmdline_tm.c | 24 ++++++++++++------------
> > > >  1 file changed, 12 insertions(+), 12 deletions(-)
> > > >
> 
> > > Reviewed-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > >
> >
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Applied to next-qos tree, thanks!

      reply	other threads:[~2018-12-21  0:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26  8:35 Rosen Xu
2018-12-04 12:28 ` Singh, Jasvinder
2018-12-04 13:00   ` Xu, Rosen
2018-12-20 19:07     ` Dumitrescu, Cristian
2018-12-21  0:40       ` Xu, Rosen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0E78D399C70DA940A335608C6ED296D73A45B0C0@SHSMSX104.ccr.corp.intel.com \
    --to=rosen.xu@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jasvinder.singh@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).