From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 267B71B14C for ; Wed, 2 Jan 2019 07:52:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jan 2019 22:52:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,430,1539673200"; d="scan'208";a="132261651" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 01 Jan 2019 22:52:55 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 1 Jan 2019 22:52:55 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 1 Jan 2019 22:52:55 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.45]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.196]) with mapi id 14.03.0415.000; Wed, 2 Jan 2019 14:52:53 +0800 From: "Xu, Rosen" To: "Pei, Andy" , "dev@dpdk.org" CC: "Zhang, Tianfei" , "Yigit, Ferruh" Thread-Topic: [PATCH v3]/driver/raw/ifpga_rawdev: fix a memory leak bug in ifpga Thread-Index: AQHUnBjnq0GhO+awEkmOCZ+So9NN/KWbluxA Date: Wed, 2 Jan 2019 06:52:52 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A478CAA@SHSMSX104.ccr.corp.intel.com> References: <1545161721-382282-1-git-send-email-andy.pei@intel.com> <1545746524-116580-1-git-send-email-andy.pei@intel.com> In-Reply-To: <1545746524-116580-1-git-send-email-andy.pei@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2M3MjhjYWUtNTVlYi00NWY1LTk3ZGUtZmQxNjJmZWVhNDU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoielVMWDcxYkhXOE81ekVTd01Jc1N5Qk9XNXhLRHdWY3pVTGFlXC9jUGZUV2Z0QUlua3RtVkdGRlBWN1wvN0hiY3E0In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3]/driver/raw/ifpga_rawdev: fix a memory leak bug in ifpga X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2019 06:52:57 -0000 Hi, > -----Original Message----- > From: Pei, Andy > Sent: Tuesday, December 25, 2018 22:02 > To: dev@dpdk.org > Cc: Xu, Rosen ; Zhang, Tianfei > ; Pei, Andy > Subject: [PATCH v3]/driver/raw/ifpga_rawdev: fix a memory leak bug in ifp= ga >=20 > When ifpga_rawdev_create() allocate memory for a new rawdev, the original > code allocate redundant memory for adapter, which is a member of the > rawdev. > What is actually necessary is the adapter to be initialized, not memory > allocated. >=20 > What is different in v3 from v2 is that the adapter is no longer need to = be > freed. >=20 > fixes:ef1e8ede3da5 > cc: rosen.xu@intel.com > cc: tianfei.zhang@intel.com Acked-by: Rosen Xu