From: "Xu, Rosen" <rosen.xu@intel.com>
To: "Pei, Andy" <andy.pei@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Tianfei" <tianfei.zhang@intel.com>
Subject: Re: [dpdk-dev] [DPDK] /driver/bus/ifpga: users do not have to input afu_bts in cmdline
Date: Mon, 14 Jan 2019 05:14:27 +0000 [thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D73A4B759F@SHSMSX152.ccr.corp.intel.com> (raw)
In-Reply-To: <1547430067-63007-1-git-send-email-andy.pei@intel.com>
> -----Original Message-----
> From: Pei, Andy
> Sent: Monday, January 14, 2019 9:41
> To: dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; Pei, Andy <andy.pei@intel.com>
> Subject: [DPDK] /driver/bus/ifpga: users do not have to input afu_bts in
> cmdline
>
> Original driver requires users to input "afu_bts" args.
> After apply this patch, driver can also work without a "afu_bts" args explicitly
> in the cmdline.
>
> fixes: 05fa3d4a6539
> cc: rosen.xu@intel.com
> cc: tianfei.zhang@intel.com
> cc: andy.pei@intel.com
>
> Signed-off-by: AndyPei <andy.pei@intel.com>
> ---
> drivers/bus/ifpga/ifpga_bus.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
> index 5f23ed8..e4b7b6f 100644
> --- a/drivers/bus/ifpga/ifpga_bus.c
> +++ b/drivers/bus/ifpga/ifpga_bus.c
> @@ -125,15 +125,13 @@ void rte_ifpga_driver_unregister(struct
> rte_afu_driver *driver)
> IFPGA_AFU_BTS);
> goto end;
> }
> + afu_pr_conf.pr_enable = 1;
> } else {
> - IFPGA_BUS_ERR("arg %s is mandatory for ifpga bus",
> - IFPGA_AFU_BTS);
> - goto end;
> + afu_pr_conf.pr_enable = 0;
> }
>
> afu_pr_conf.afu_id.uuid.uuid_low = 0;
> afu_pr_conf.afu_id.uuid.uuid_high = 0;
> - afu_pr_conf.pr_enable = path?1:0;
>
> if (ifpga_find_afu_dev(rawdev, &afu_pr_conf.afu_id))
> goto end;
> --
> 1.8.3.1
Acked-by: Rosen Xu <rosen.xu@intel.com>
next prev parent reply other threads:[~2019-01-14 5:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 1:41 AndyPei
2019-01-14 5:14 ` Xu, Rosen [this message]
2019-01-18 11:07 ` [dpdk-dev] [PATCH v2] bus/ifpga: fix forcing optional devargs Ferruh Yigit
2019-01-18 19:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E78D399C70DA940A335608C6ED296D73A4B759F@SHSMSX152.ccr.corp.intel.com \
--to=rosen.xu@intel.com \
--cc=andy.pei@intel.com \
--cc=dev@dpdk.org \
--cc=tianfei.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).