From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D3E551B1FF for ; Mon, 14 Jan 2019 06:14:32 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2019 21:14:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,476,1539673200"; d="scan'208";a="291317972" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 13 Jan 2019 21:14:31 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 13 Jan 2019 21:14:31 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 13 Jan 2019 21:14:30 -0800 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.44]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.160]) with mapi id 14.03.0415.000; Mon, 14 Jan 2019 13:14:28 +0800 From: "Xu, Rosen" To: "Pei, Andy" , "dev@dpdk.org" CC: "Zhang, Tianfei" Thread-Topic: [DPDK] /driver/bus/ifpga: users do not have to input afu_bts in cmdline Thread-Index: AQHUq6p34RPwwvY+CEqyrUOMGaRK9qWuOIoQ Date: Mon, 14 Jan 2019 05:14:27 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A4B759F@SHSMSX152.ccr.corp.intel.com> References: <1547430067-63007-1-git-send-email-andy.pei@intel.com> In-Reply-To: <1547430067-63007-1-git-send-email-andy.pei@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWMyYjNlZDgtYWM0OC00YjQ3LTkyNzQtMjU4MGI5YjYwM2I2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOEhxbFZ5MnIxVTlad2J0bnVUblhvWDNtcGFNbHhCSmY2RnRrVFwvaGc5OUJic1cxWlNZRk5QVDRjMHRQSUdHSjgifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [DPDK] /driver/bus/ifpga: users do not have to input afu_bts in cmdline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 05:14:33 -0000 > -----Original Message----- > From: Pei, Andy > Sent: Monday, January 14, 2019 9:41 > To: dev@dpdk.org > Cc: Xu, Rosen ; Zhang, Tianfei > ; Pei, Andy > Subject: [DPDK] /driver/bus/ifpga: users do not have to input afu_bts in > cmdline >=20 > Original driver requires users to input "afu_bts" args. > After apply this patch, driver can also work without a "afu_bts" args exp= licitly > in the cmdline. >=20 > fixes: 05fa3d4a6539 > cc: rosen.xu@intel.com > cc: tianfei.zhang@intel.com > cc: andy.pei@intel.com >=20 > Signed-off-by: AndyPei > --- > drivers/bus/ifpga/ifpga_bus.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.= c > index 5f23ed8..e4b7b6f 100644 > --- a/drivers/bus/ifpga/ifpga_bus.c > +++ b/drivers/bus/ifpga/ifpga_bus.c > @@ -125,15 +125,13 @@ void rte_ifpga_driver_unregister(struct > rte_afu_driver *driver) > IFPGA_AFU_BTS); > goto end; > } > + afu_pr_conf.pr_enable =3D 1; > } else { > - IFPGA_BUS_ERR("arg %s is mandatory for ifpga bus", > - IFPGA_AFU_BTS); > - goto end; > + afu_pr_conf.pr_enable =3D 0; > } >=20 > afu_pr_conf.afu_id.uuid.uuid_low =3D 0; > afu_pr_conf.afu_id.uuid.uuid_high =3D 0; > - afu_pr_conf.pr_enable =3D path?1:0; >=20 > if (ifpga_find_afu_dev(rawdev, &afu_pr_conf.afu_id)) > goto end; > -- > 1.8.3.1 Acked-by: Rosen Xu