From: "Xu, Rosen" <rosen.xu@intel.com>
To: "Pei, Andy" <andy.pei@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Tianfei" <tianfei.zhang@intel.com>
Subject: Re: [dpdk-dev] [DPDK] [PATCH v4] raw/ifpga: fix a typo and delete code of unused function
Date: Wed, 16 Jan 2019 11:26:47 +0000 [thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D73A4C6CCA@SHSMSX152.ccr.corp.intel.com> (raw)
In-Reply-To: <1547530680-423006-1-git-send-email-andy.pei@intel.com>
Hi,
Pls don't use fixline if your patch code doesn't merged in community.
> -----Original Message-----
> From: Pei, Andy
> Sent: Tuesday, January 15, 2019 13:38
> To: dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; Pei, Andy <andy.pei@intel.com>
> Subject: [DPDK] [PATCH v4] raw/ifpga: fix a typo and delete code of unused
> function
>
> fix a typo and delete code of unused function
>
> Fixes: 88c9eb7cb4b5 (\"fix a typo and delete code of unused function\")
> Cc: andy.pei@intel.com
> Cc: rosen.xu@intel.com
> Cc: tianfei.zhang@intel.com
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
> drivers/raw/ifpga_rawdev/base/opae_hw_api.c | 24 +-----------------------
> 1 file changed, 1 insertion(+), 23 deletions(-)
>
> diff --git a/drivers/raw/ifpga_rawdev/base/opae_hw_api.c
> b/drivers/raw/ifpga_rawdev/base/opae_hw_api.c
> index 50f6438..ea42757 100644
> --- a/drivers/raw/ifpga_rawdev/base/opae_hw_api.c
> +++ b/drivers/raw/ifpga_rawdev/base/opae_hw_api.c
> @@ -304,7 +304,7 @@ static struct opae_adapter_ops *match_ops(struct
> opae_adapter *adapter)
>
> /**
> * opae_adapter_init - init opae_adapter data structure
> - * @adpdate: pointer of opae_adater data structure
> + * @adapter: pointer of opae_adater data structure
> * @name: adapter name.
> * @data: private data of this adapter.
> *
> @@ -325,28 +325,6 @@ int opae_adapter_init(struct opae_adapter
> *adapter, }
>
> /**
> - * opae_adapter_alloc - alloc opae_adapter data structure
> - * @name: adapter name.
> - * @data: private data of this adapter.
> - *
> - * Return: opae_adapter on success, otherwise NULL.
> - */
> - /**This function will no longer be called.
> -struct opae_adapter *opae_adapter_alloc(const char *name, void *data) -{
> - struct opae_adapter *adapter = opae_zmalloc(sizeof(*adapter));
> -
> - if (!adapter)
> - return NULL;
> -
> - if (opae_adapter_init(adapter, name, data))
> - return NULL;
> -
> - return adapter;
> -}
> -**/
> -
> -/**
> * opae_adapter_enumerate - enumerate this adapter
> * @adapter: adapter to enumerate.
> *
> --
> 1.8.3.1
next prev parent reply other threads:[~2019-01-16 11:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 18:33 [dpdk-dev] [PATCH] Fix a memnory leak bug due to malloc unproperly AndyPei
2018-12-13 14:32 ` Burakov, Anatoly
2018-12-18 7:16 ` Xu, Rosen
2018-12-18 19:35 ` [dpdk-dev] [PATCH v2]/driver/raw/ifpga_rawdev: fix a memory leak bug in ifpga AndyPei
2018-12-19 7:16 ` Xu, Rosen
2018-12-19 8:42 ` Pei, Andy
2018-12-25 14:02 ` [dpdk-dev] [PATCH v3]/driver/raw/ifpga_rawdev: " AndyPei
2019-01-02 2:47 ` Zhang, Tianfei
2019-01-02 6:52 ` Xu, Rosen
2019-01-15 0:03 ` Thomas Monjalon
2019-01-15 5:38 ` [dpdk-dev] [DPDK] [PATCH v4] raw/ifpga: fix a typo and delete code of unused function Andy Pei
2019-01-16 11:26 ` Xu, Rosen [this message]
2019-01-17 5:26 ` [dpdk-dev] [DPDK] " Andy Pei
2019-01-17 5:36 ` Ye Xiaolong
2019-01-17 6:39 ` [dpdk-dev] [DPDK] raw/ifpga: fix a typo Andy Pei
2019-01-17 8:39 ` Xu, Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E78D399C70DA940A335608C6ED296D73A4C6CCA@SHSMSX152.ccr.corp.intel.com \
--to=rosen.xu@intel.com \
--cc=andy.pei@intel.com \
--cc=dev@dpdk.org \
--cc=tianfei.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).