DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xu, Rosen" <rosen.xu@intel.com>
To: "Pei, Andy" <andy.pei@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [DPDK] bus/ifpga: fix a brackets unmatch
Date: Thu, 17 Jan 2019 08:36:15 +0000	[thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D73A4CCE36@SHSMSX152.ccr.corp.intel.com> (raw)
In-Reply-To: <1547703135-195893-1-git-send-email-andy.pei@intel.com>

Hi,

> -----Original Message-----
> From: Pei, Andy
> Sent: Thursday, January 17, 2019 13:32
> To: dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com>;
> stable@dpdk.org
> Subject: [DPDK] bus/ifpga: fix a brackets unmatch

I think it's v2 patch, so pls identify it.
For the title, I think this one could be better.

C linkage names declaration brackets mismatch

> The code
> 
> extern "C" {
> 
> miss a related
> 
> }
Pls descript it in detail not in demo code.

> 
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> Cc: rosen.xu@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
>  drivers/bus/ifpga/rte_bus_ifpga.h | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/ifpga/rte_bus_ifpga.h
> b/drivers/bus/ifpga/rte_bus_ifpga.h
> index d53c0f4..0bf43ba 100644
> --- a/drivers/bus/ifpga/rte_bus_ifpga.h
> +++ b/drivers/bus/ifpga/rte_bus_ifpga.h
> @@ -13,7 +13,7 @@
> 
>  #ifdef __cplusplus
>  extern "C" {
> -#endif
> +#endif /* __cplusplus */
> 
>  #include <rte_bus.h>
>  #include <rte_pci.h>
> @@ -143,4 +143,8 @@ struct rte_afu_driver {  #define
> RTE_PMD_REGISTER_AFU_ALIAS(nm, alias)\  static const char *afudrvinit_ ##
> nm ## _alias = RTE_STR(alias)
> 
> +#ifdef __cplusplus
> +}
> +#endif /* __cplusplus */
> +
>  #endif /* _RTE_BUS_IFPGA_H_ */
> --
> 1.8.3.1

  reply	other threads:[~2019-01-17  8:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14  6:01 [dpdk-dev] [DPDK] /driver/bus/ifpga: Fix " AndyPei
2019-01-16 11:29 ` Xu, Rosen
2019-01-17  5:32 ` [dpdk-dev] [DPDK] bus/ifpga: fix " Andy Pei
2019-01-17  8:36   ` Xu, Rosen [this message]
2019-01-18 11:09   ` [dpdk-dev] [PATCH v2] bus/ifpga: fix build for cpp applications Ferruh Yigit
2019-01-18 18:57     ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0E78D399C70DA940A335608C6ED296D73A4CCE36@SHSMSX152.ccr.corp.intel.com \
    --to=rosen.xu@intel.com \
    --cc=andy.pei@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).