From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 613F05A; Wed, 20 Mar 2019 09:16:09 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2019 01:16:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,248,1549958400"; d="scan'208";a="143542213" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 20 Mar 2019 01:16:07 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 01:16:07 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 01:16:07 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.74]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.10]) with mapi id 14.03.0415.000; Wed, 20 Mar 2019 16:16:05 +0800 From: "Xu, Rosen" To: "Pei, Andy" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] raw/ifpga: modify log output Thread-Index: AQHU3vQSSIKKzPAkAUSG8y4h2/QaqaYULBoQ Date: Wed, 20 Mar 2019 08:16:05 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A61B143@SHSMSX104.ccr.corp.intel.com> References: <1552556863-35966-1-git-send-email-andy.pei@intel.com> <1553069009-64692-1-git-send-email-andy.pei@intel.com> In-Reply-To: <1553069009-64692-1-git-send-email-andy.pei@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2M0NzFiZTAtZjBhMS00ZjRhLTkxZTEtYjg4NGZlY2VhODFhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibWJmSEVpVyt1cktXRlZZRytzVVdPVlwvdG1VcXhLRUZsYittSFo2V25wOXlrM2J5RkMrNzFjNEJkVHdWQlY4VGsifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] raw/ifpga: modify log output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2019 08:16:10 -0000 > -----Original Message----- > From: Pei, Andy > Sent: Wednesday, March 20, 2019 16:03 > To: dev@dpdk.org > Cc: Xu, Rosen ; Pei, Andy ; > stable@dpdk.org > Subject: [PATCH v2] raw/ifpga: modify log output >=20 > print function name in ifpga log and a new line goes after every IFPGA lo= g. >=20 > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen.xu@intel.com > Cc: andy.pei@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Andy Pei > --- > drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > index c7759b8..234ce36 100644 > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > @@ -8,8 +8,8 @@ > extern int ifpga_rawdev_logtype; >=20 > #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \ > - rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt, \ > - ##args) > + rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "%s(): " fmt "\n", \ > + __func__, ##args) >=20 > #define IFPGA_RAWDEV_PMD_FUNC_TRACE() > IFPGA_RAWDEV_PMD_LOG(DEBUG, ">>") >=20 > -- > 1.8.3.1 Reviewed-by: Rosen Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4A5BEA00E6 for ; Wed, 20 Mar 2019 09:16:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CC8EC2C60; Wed, 20 Mar 2019 09:16:10 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 613F05A; Wed, 20 Mar 2019 09:16:09 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2019 01:16:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,248,1549958400"; d="scan'208";a="143542213" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 20 Mar 2019 01:16:07 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 01:16:07 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 01:16:07 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.74]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.10]) with mapi id 14.03.0415.000; Wed, 20 Mar 2019 16:16:05 +0800 From: "Xu, Rosen" To: "Pei, Andy" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] raw/ifpga: modify log output Thread-Index: AQHU3vQSSIKKzPAkAUSG8y4h2/QaqaYULBoQ Date: Wed, 20 Mar 2019 08:16:05 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A61B143@SHSMSX104.ccr.corp.intel.com> References: <1552556863-35966-1-git-send-email-andy.pei@intel.com> <1553069009-64692-1-git-send-email-andy.pei@intel.com> In-Reply-To: <1553069009-64692-1-git-send-email-andy.pei@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2M0NzFiZTAtZjBhMS00ZjRhLTkxZTEtYjg4NGZlY2VhODFhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibWJmSEVpVyt1cktXRlZZRytzVVdPVlwvdG1VcXhLRUZsYittSFo2V25wOXlrM2J5RkMrNzFjNEJkVHdWQlY4VGsifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] raw/ifpga: modify log output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320081605.TGmkaoyxgY9Ei1C56IYAdV445kdwNWABsXRNMDCuzSE@z> > -----Original Message----- > From: Pei, Andy > Sent: Wednesday, March 20, 2019 16:03 > To: dev@dpdk.org > Cc: Xu, Rosen ; Pei, Andy ; > stable@dpdk.org > Subject: [PATCH v2] raw/ifpga: modify log output >=20 > print function name in ifpga log and a new line goes after every IFPGA lo= g. >=20 > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen.xu@intel.com > Cc: andy.pei@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Andy Pei > --- > drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > index c7759b8..234ce36 100644 > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > @@ -8,8 +8,8 @@ > extern int ifpga_rawdev_logtype; >=20 > #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \ > - rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt, \ > - ##args) > + rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "%s(): " fmt "\n", \ > + __func__, ##args) >=20 > #define IFPGA_RAWDEV_PMD_FUNC_TRACE() > IFPGA_RAWDEV_PMD_LOG(DEBUG, ">>") >=20 > -- > 1.8.3.1 Reviewed-by: Rosen Xu