From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 6D0BB1B471 for ; Tue, 16 Apr 2019 10:15:25 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 01:15:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,357,1549958400"; d="scan'208";a="149811236" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 16 Apr 2019 01:15:23 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 01:15:23 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 01:15:23 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.21]) with mapi id 14.03.0415.000; Tue, 16 Apr 2019 16:15:20 +0800 From: "Xu, Rosen" To: Thomas Monjalon CC: "Yigit, Ferruh" , "dev@dpdk.org" , "Zhang, Tianfei" , "Wei, Dan" , "Pei, Andy" , "Yang, Qiming" , "Wang, Haiyue" , "Chen, Santos" , "Zhang, Zhang" , "Lomartire, David" , "Hu, Jia" Thread-Topic: [PATCH v8 02/14] bus/ifpga: add function for AFU search by name Thread-Index: AQHU80jtguR+3utF70ia3Jv9z6yeSKY8oL8AgAF2tLD//9NdgIAAh5Yw Date: Tue, 16 Apr 2019 08:15:20 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A6B18B2@SHSMSX104.ccr.corp.intel.com> References: <1551338000-120348-1-git-send-email-rosen.xu@intel.com> <4035e454-c105-9a01-c1c9-e9ba343a69e3@intel.com> <0E78D399C70DA940A335608C6ED296D73A6AF7CE@SHSMSX104.ccr.corp.intel.com> <1849278.EChBP1P422@xps> In-Reply-To: <1849278.EChBP1P422@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDI1YWE1NDMtMzVmMC00MmQyLTg0YTEtOWFhMjgzNDUwZTRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoick44U1d2bDFpUjBUbXdhcWhYNnRjZ0NTK1hmaTdBRVFwWUFHNnk3Zmp3dU5IeVlDTjRiWStFVStKdTR2VUVYbiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 02/14] bus/ifpga: add function for AFU search by name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2019 08:15:26 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, April 16, 2019 16:10 > To: Xu, Rosen > Cc: Yigit, Ferruh ; dev@dpdk.org; Zhang, Tianfei > ; Wei, Dan ; Pei, Andy > ; Yang, Qiming ; Wang, > Haiyue ; Chen, Santos ; > Zhang, Zhang ; Lomartire, David > ; Hu, Jia > Subject: Re: [PATCH v8 02/14] bus/ifpga: add function for AFU search by > name >=20 > 16/04/2019 04:50, Xu, Rosen: > > From: Yigit, Ferruh > > > > --- a/drivers/bus/ifpga/rte_bus_ifpga.h > > > > +++ b/drivers/bus/ifpga/rte_bus_ifpga.h > > > > @@ -120,6 +120,15 @@ struct rte_afu_driver { } > > > > > > > > /** > > > > + * Find AFU by AFU name. > > > > + * > > > > + * @param name > > > > + * A pointer to AFU name string. > > > > + */ > > > > +struct rte_afu_device *__rte_experimental > > > > +rte_ifpga_find_afu_by_name(const char *name); > > > > + > > > > > > > > > Hi Rosen, > > > > > > This is the bus code, and only drivers will call it right? I think > > > there is no intention to make this run by application code, the > > > functions need to be exported because driver and bus are different > libraries. > > > If above correct, there is no point of making the function > > > experimental, can drop the __rte_experimental tag, and update .map > > > file to not use EXPERIMENTAL. > > > > Hi Ferruh, > > > > Just double confirm with you, if I follow this modification, there is o= ne > checkpatch error. >=20 > This is a warning, and Ferruh allows it in this case :) >=20 Okay Thomas. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 802FAA00E6 for ; Tue, 16 Apr 2019 10:15:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 428151B480; Tue, 16 Apr 2019 10:15:27 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 6D0BB1B471 for ; Tue, 16 Apr 2019 10:15:25 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 01:15:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,357,1549958400"; d="scan'208";a="149811236" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 16 Apr 2019 01:15:23 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 01:15:23 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 01:15:23 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.21]) with mapi id 14.03.0415.000; Tue, 16 Apr 2019 16:15:20 +0800 From: "Xu, Rosen" To: Thomas Monjalon CC: "Yigit, Ferruh" , "dev@dpdk.org" , "Zhang, Tianfei" , "Wei, Dan" , "Pei, Andy" , "Yang, Qiming" , "Wang, Haiyue" , "Chen, Santos" , "Zhang, Zhang" , "Lomartire, David" , "Hu, Jia" Thread-Topic: [PATCH v8 02/14] bus/ifpga: add function for AFU search by name Thread-Index: AQHU80jtguR+3utF70ia3Jv9z6yeSKY8oL8AgAF2tLD//9NdgIAAh5Yw Date: Tue, 16 Apr 2019 08:15:20 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A6B18B2@SHSMSX104.ccr.corp.intel.com> References: <1551338000-120348-1-git-send-email-rosen.xu@intel.com> <4035e454-c105-9a01-c1c9-e9ba343a69e3@intel.com> <0E78D399C70DA940A335608C6ED296D73A6AF7CE@SHSMSX104.ccr.corp.intel.com> <1849278.EChBP1P422@xps> In-Reply-To: <1849278.EChBP1P422@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDI1YWE1NDMtMzVmMC00MmQyLTg0YTEtOWFhMjgzNDUwZTRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoick44U1d2bDFpUjBUbXdhcWhYNnRjZ0NTK1hmaTdBRVFwWUFHNnk3Zmp3dU5IeVlDTjRiWStFVStKdTR2VUVYbiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 02/14] bus/ifpga: add function for AFU search by name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190416081520.gmy9nyHuac5Kdq1nyC9VZc4sfYVjYOMkiqO6znFnYPo@z> > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, April 16, 2019 16:10 > To: Xu, Rosen > Cc: Yigit, Ferruh ; dev@dpdk.org; Zhang, Tianfei > ; Wei, Dan ; Pei, Andy > ; Yang, Qiming ; Wang, > Haiyue ; Chen, Santos ; > Zhang, Zhang ; Lomartire, David > ; Hu, Jia > Subject: Re: [PATCH v8 02/14] bus/ifpga: add function for AFU search by > name >=20 > 16/04/2019 04:50, Xu, Rosen: > > From: Yigit, Ferruh > > > > --- a/drivers/bus/ifpga/rte_bus_ifpga.h > > > > +++ b/drivers/bus/ifpga/rte_bus_ifpga.h > > > > @@ -120,6 +120,15 @@ struct rte_afu_driver { } > > > > > > > > /** > > > > + * Find AFU by AFU name. > > > > + * > > > > + * @param name > > > > + * A pointer to AFU name string. > > > > + */ > > > > +struct rte_afu_device *__rte_experimental > > > > +rte_ifpga_find_afu_by_name(const char *name); > > > > + > > > > > > > > > Hi Rosen, > > > > > > This is the bus code, and only drivers will call it right? I think > > > there is no intention to make this run by application code, the > > > functions need to be exported because driver and bus are different > libraries. > > > If above correct, there is no point of making the function > > > experimental, can drop the __rte_experimental tag, and update .map > > > file to not use EXPERIMENTAL. > > > > Hi Ferruh, > > > > Just double confirm with you, if I follow this modification, there is o= ne > checkpatch error. >=20 > This is a warning, and Ferruh allows it in this case :) >=20 Okay Thomas.