From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 088B2A05D3 for ; Thu, 23 May 2019 04:59:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CDAE51B94D; Thu, 23 May 2019 04:59:35 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id E193E25D9; Thu, 23 May 2019 04:59:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2019 19:59:33 -0700 X-ExtLoop1: 1 Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 22 May 2019 19:59:33 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 22 May 2019 19:59:33 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.129]) with mapi id 14.03.0415.000; Thu, 23 May 2019 10:59:31 +0800 From: "Xu, Rosen" To: "Pei, Andy" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] net/ipn3ke: check input argument before other operation Thread-Index: AQHVERN305NZ8BF6H0yqrPEhKoU2MKZ4BN5A Date: Thu, 23 May 2019 02:59:30 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A76ECD7@SHSMSX104.ccr.corp.intel.com> References: <1558509691-429834-1-git-send-email-andy.pei@intel.com> <1558579983-142573-1-git-send-email-andy.pei@intel.com> In-Reply-To: <1558579983-142573-1-git-send-email-andy.pei@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2M5MGNmMTAtZmJiNS00ZTI4LWJlMWQtNTIwMWEyZmRlNmRhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicjI0cnd3NXliZGlSMDNSSUExbEFLQ2tOXC93SkZ1bVBmaTdHcnZlRVlvNlNOS3lUaVVGZWVWZk5YcWJOaTdRYlQifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ipn3ke: check input argument before other operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Pei, Andy > Sent: Thursday, May 23, 2019 10:53 > To: dev@dpdk.org > Cc: Pei, Andy ; Xu, Rosen ; > stable@dpdk.org > Subject: [PATCH v2] net/ipn3ke: check input argument before other > operation >=20 > check input argument rte_eth_dev *ethdev, ensuring ethdev is not NULL > before operation on ethdev. >=20 > Coverity issue: 337922 > Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor") > Cc: rosen.xu@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Andy Pei > --- > drivers/net/ipn3ke/ipn3ke_representor.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c > b/drivers/net/ipn3ke/ipn3ke_representor.c > index cf3b214..f7bb0b4 100644 > --- a/drivers/net/ipn3ke/ipn3ke_representor.c > +++ b/drivers/net/ipn3ke/ipn3ke_representor.c > @@ -735,13 +735,16 @@ > enum rte_filter_type filter_type, enum rte_filter_op filter_op, > void *arg) > { > - struct ipn3ke_hw *hw =3D IPN3KE_DEV_PRIVATE_TO_HW(ethdev); > - struct ipn3ke_rpst *rpst =3D IPN3KE_DEV_PRIVATE_TO_RPST(ethdev); > int ret =3D 0; > + struct ipn3ke_hw *hw; > + struct ipn3ke_rpst *rpst; >=20 > if (ethdev =3D=3D NULL) > return -EINVAL; >=20 > + hw =3D IPN3KE_DEV_PRIVATE_TO_HW(ethdev); > + rpst =3D IPN3KE_DEV_PRIVATE_TO_RPST(ethdev); > + > if (hw->acc_flow) > switch (filter_type) { > case RTE_ETH_FILTER_GENERIC: > -- > 1.8.3.1 Acked-by: Rosen Xu