From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7559AA0A00; Mon, 11 Jan 2021 17:19:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57E90140F49; Mon, 11 Jan 2021 17:19:30 +0100 (CET) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id 61BA5140F31 for ; Mon, 11 Jan 2021 17:19:29 +0100 (CET) Received: by mail-pg1-f172.google.com with SMTP id 30so12808270pgr.6 for ; Mon, 11 Jan 2021 08:19:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=S+yNQ1VmMPCltlHypkJ8UW8CHgVYdfxYf8yIqyAW4Zw=; b=MhWBhAzV3kOpUoBBwNfKxxXXx/me/T1UWxgDHQTl3KzdythNHPaE7ukMvimzOOcTGw j3mQcieXV1NeI70MD8r74WNzq68Ax6OBZdGAL406BCyfar5p5Q3TU6zjGXPk/TidQjUG mStNxZ8+Dedr2qMIkJx5dQ5CuHiBu0eJ6oT2GQNUA7AhHsmGIlqKQRoVS/yP5zUTg+9b ZhfDNjMQiOxidEqzGca/N8H1FcXLQOKQI0v5WypGn0NbWOAlggp6FWSGN6vGHsMokhPi v6JANFFOQxv6a3wMX9SJmP75w15wVSEu3W2PNYEDFfsFInsXgbDChgYmw3A+mQUZYvNA pfqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=S+yNQ1VmMPCltlHypkJ8UW8CHgVYdfxYf8yIqyAW4Zw=; b=T1n/5cFPjYeyq0qQps2OZZfmmNqC+T1Erzm6Frn/VT/H3Qvv3EkDRM81OzX3FcfdWE bqhezcGzaVpRILDAQVVi45UP+BQFCFqCPQIMS857V8NB5vPWLF54BrDHULmRLJNFIV+p tx/2r/HWEohVH2Pn1F+ce5CwDbPxvUarNPv1zls1yVs10vbfPpvgXZ2lOe3oeGe8VxxY DXxio5gSeWwkpawjpnXIycXs8HzFYZXhf7OeisP1cSKcUAX3zF2V698VIwD9tTvehr12 gMR1UhX3YOz1GO4m6E9iQ7Lc8D/QSNrrOU2w+CTjzE8LRmkuIOhMnFbRFcAhqgDLhaNb EILA== X-Gm-Message-State: AOAM5301bNZ/LYeVfWE3sGckODD0bElaaOyp/ihSolmgF0eO4CmEhshQ DGMOdkRJsQ7+XOKGAjENWSkwAg== X-Google-Smtp-Source: ABdhPJzpmt7btcpFFbd3COzb9rM/ajwL76Nu/gVqAKT3BtaaayiEHfjlkdfDvbjZJQt4z33Flhy1TQ== X-Received: by 2002:aa7:9357:0:b029:1a5:43da:b90d with SMTP id 23-20020aa793570000b02901a543dab90dmr154323pfn.54.1610381968662; Mon, 11 Jan 2021 08:19:28 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:1129:cd4b:9e0e:30cb? ([2600:1700:6b0:fde0:1129:cd4b:9e0e:30cb]) by smtp.gmail.com with ESMTPSA id gz2sm11790pjb.2.2021.01.11.08.19.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jan 2021 08:19:28 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) From: Andrew Boyer In-Reply-To: <20210111135559.1169775-1-bruce.richardson@intel.com> Date: Mon, 11 Jan 2021 11:19:26 -0500 Cc: dev , thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, stable@dpdk.org Content-Transfer-Encoding: quoted-printable Message-Id: <0EF8D1A0-3838-442A-A4E9-006258035C34@pensando.io> References: <20210111135559.1169775-1-bruce.richardson@intel.com> To: Bruce Richardson X-Mailer: Apple Mail (2.3608.120.23.2.4) Subject: Re: [dpdk-dev] [PATCH] build: provide suitable error for "both" libraries option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Jan 11, 2021, at 8:55 AM, Bruce Richardson = wrote: >=20 > Rather than having the DPDK configuration error out when linking apps > and examples when "both" is select for "default_library" option, we = can > detect that setting earlier in the build config and provide a suitable > error message to the user. >=20 > CC: stable@dpdk.org >=20 > Signed-off-by: Bruce Richardson > --- > config/meson.build | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/config/meson.build b/config/meson.build > index 3ddcc3539..05e9cede5 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -308,3 +308,12 @@ if get_option('b_lto') > add_project_link_arguments('-Wno-lto-type-mismatch', = language: 'c') > endif > endif > + > +if get_option('default_library') =3D=3D 'both' > + error( ''' > + Unsupported value "both" for "default_library" option. > + > + NOTE: DPDK always builds both shared and static libraries. = Please set > + "default_library" to either "static" or "shared" to select = default linkage > + for apps and any examples''') Should there be a period after =E2=80=98examples=E2=80=99? > +endif > -- > 2.27.0 >=20 Reviewed-by: Andrew Boyer