From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E292A00C2; Fri, 1 Jul 2022 10:33:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1234641133; Fri, 1 Jul 2022 10:33:29 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EBF3041133 for ; Fri, 1 Jul 2022 10:33:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656664407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UqkhW4318bi4v+03U3JI72nGlJPruX5D8h/nM+zocaI=; b=HLkjnca91CA2+aXVtsIfs0yydd81qKWqM8ldNRKNdPIzF2GtkIcuO/o76AVkhGJN6IQa7m MTfJNDH/nDAxHjpi0B5RoxfiB1xEJl1vhys9THpm06V88GToRWor4caCAYZBV5ADtXonOd KdUgUuWcd/HHh4G+9VU6H/T+9Zk9lLU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-544-s81Xpz_APZmEIc6IBBA5Ug-1; Fri, 01 Jul 2022 04:33:23 -0400 X-MC-Unique: s81Xpz_APZmEIc6IBBA5Ug-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0C81418E530C; Fri, 1 Jul 2022 08:33:23 +0000 (UTC) Received: from [10.39.208.30] (unknown [10.39.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D25A440336E; Fri, 1 Jul 2022 08:33:21 +0000 (UTC) Message-ID: <0a0ba20a-e52b-d29a-6f0e-41de892caa7a@redhat.com> Date: Fri, 1 Jul 2022 10:33:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] vdpa/mlx5: fix leak on event thread creation To: David Marchand , Matan Azrad , Viacheslav Ovsiienko , Xueming Li Cc: dev , dpdk stable , Raslan Darawsheh References: <20220620131044.1858049-1-david.marchand@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/1/22 10:30, David Marchand wrote: > On Mon, Jun 20, 2022 at 3:11 PM David Marchand > wrote: >> >> As stated in the manual, pthread_attr_init return value should be >> checked. >> Besides, a pthread_attr_t should be destroyed once unused. >> >> In practice, we may have no leak (from what I read in glibc current code), >> but this may change in the future. >> Stick to a correct use of the API. >> >> Fixes: 5cf3fd3af4df ("vdpa/mlx5: add CPU core parameter to bind polling thread") >> Cc: stable@dpdk.org >> >> Signed-off-by: David Marchand > > Review, please? > > I reviewed the patch but was waiting for Nvidia to test it. Reviewed-by: Maxime Coquelin Nvidia, could it be done ASAP so that it goes to -rc3? Thanks, Maxime