From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 307407272 for ; Thu, 19 Apr 2018 18:17:21 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 9B753140069; Thu, 19 Apr 2018 16:17:19 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 19 Apr 2018 17:17:15 +0100 To: CC: Ferruh Yigit , Ivan Malov References: <1523035280-24873-1-git-send-email-arybchenko@solarflare.com> <1523035280-24873-2-git-send-email-arybchenko@solarflare.com> From: Andrew Rybchenko Message-ID: <0a0eaef9-74d3-7165-ad90-0301003c9392@solarflare.com> Date: Thu, 19 Apr 2018 19:17:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1523035280-24873-2-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23792.003 X-TM-AS-Result: No--8.911200-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1524154640-z0fJ6rUPtb0f Subject: Re: [dpdk-dev] [PATCH 1/7] net/sfc/base: add a new means to control RSS hash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 16:17:21 -0000 On 04/06/2018 08:21 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > Currently, libefx has no support for additional RSS modes > available with later controllers. In order to support this, > libefx should be able to list available hash configurations. > > This patch provides basic infrastructure for the new interface. > The client drivers will be able to query the list of supported > hash configurations for a particular hash algorithm. Also, it > will be possible to configure hashing by means of new definitions. > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > --- > drivers/net/sfc/base/ef10_rx.c | 29 ++++++++-- > drivers/net/sfc/base/efx.h | 90 +++++++++++++++++++++++++++++ > drivers/net/sfc/base/efx_rx.c | 126 +++++++++++++++++++++++++++++++++++++++-- > 3 files changed, 236 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/sfc/base/ef10_rx.c b/drivers/net/sfc/base/ef10_rx.c > index 86a6ac7..e7dd1ea 100644 > --- a/drivers/net/sfc/base/ef10_rx.c > +++ b/drivers/net/sfc/base/ef10_rx.c > @@ -298,11 +298,32 @@ efx_mcdi_rss_context_set_flags( > __in uint32_t rss_context, > __in efx_rx_hash_type_t type) > { > + efx_rx_hash_type_t type_ipv4 = EFX_RX_HASH(IPV4, 2TUPLE); Self NACK, will send v2 It breaks clang build because of false positive warning [...]