From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C2DFA00C3; Thu, 3 Feb 2022 17:06:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E49F940143; Thu, 3 Feb 2022 17:06:49 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id DAA6640140 for <dev@dpdk.org>; Thu, 3 Feb 2022 17:06:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643904408; x=1675440408; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=bcMN8Byw7eXd746+20ra5cD44P+pRXjv40E1+69OuSk=; b=WeDfVolIkOGwe9ulSVpjdTo6nbSHo5lWpAFiH35uwCS5BlNiw6MR0QLM 5BwKD50+rEBn2Uit2m5A49pfa4mUorC2glf3kX/Qo7+SwPL+h8zvwgsF/ nbvjiNmawHtCsbDIjnqPbBfWdIaAYjKK4kYIoA8tLJzlQuzRr5gQV+pht rp/uQKthmOn4P76QhO0I+oOfeQC8/pfU1EYe80u9H10VCURmxaB8dVpaE UHB/GnVqvMSWC2kQwrUS+4mPmbsTRhaPTGr9BGWZ9TbMMYN0TfLmPFfem EpPQcqr87dFoFtZ5Q3INK3pcBz1KMBZjLRJ755klFmDMUNnkIrpZwmhPe w==; X-IronPort-AV: E=McAfee;i="6200,9189,10246"; a="334533842" X-IronPort-AV: E=Sophos;i="5.88,340,1635231600"; d="scan'208";a="334533842" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2022 08:06:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,340,1635231600"; d="scan'208";a="771818017" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga005.fm.intel.com with ESMTP; 03 Feb 2022 08:06:46 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 3 Feb 2022 08:06:46 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 3 Feb 2022 08:06:45 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 3 Feb 2022 08:06:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=exTypK80hVuFpNcOLT22rEotrNuNo1o3ryB09aXS0R/Cs2d5rfEmzd3cc7Ht/oXIqFVmooPenrngdq+OYm9jfeydK9dVZr8Yupz15HndZp05bVFUaDL5fCiFdc6oY9JwtSpIizlgPww/7VGb6RDvBEu6qZiRuwx/TvpEhkJ5XfvXwf5WZ++Lb6EmUj5NFw1QrKXx0lzkUp0DGdVRzxs7H4puh7XSj/k8gpkdxF4Nht/1yT6Flr2xb8POq1mOt++1+JwGVAEkXJPXbJXRVXZMoYKzBCwMGwB6Kyy+la1vzqInw73Vj9dzxlTWXrsTjmFos5S35Ik1LdQuEW8ubRfGww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Z51+t50aot3HnjyCaUc1IqXwuQLBVL/cJYw3VP5U5A=; b=UvlMD/f1hdSKjSmZ2LxNMKuNff3eubUIr5x34+ixaWAuYh54iSxg9Om+C5/Ko5DA+v8fSEs7yokaJ9IkpBeHbHL5jS4dOB55IIw7A7Jtf7i8SjQfctgw8268LeDVMsU+Nd20YHVEmQk++Mf86HJYR+MM+3jh0PRr+1SzrBd3gyCiFeSsLITe/Kl29KU+DCvqj4kiEph8e/8S3Tu4FvgxvUxPJVE4PDACmOYwGXW9zQ/CjN6sEbsdT3ZOCI+1r0n4+FkR1p8j3zKd4+54R3iZ5JOwe8hBLsMiD3HFUcWaY17AGNh0j942XtP5rIn7V4gy/XPvSjuLUlnJjprEIIBgbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MWHPR11MB0016.namprd11.prod.outlook.com (2603:10b6:301:63::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Thu, 3 Feb 2022 16:06:41 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022 16:06:41 +0000 Message-ID: <0a4533ff-c544-d49a-da82-4d70595b5275@intel.com> Date: Thu, 3 Feb 2022 16:06:20 +0000 Content-Language: en-US To: <jerinj@marvell.com>, <dev@dpdk.org>, Xiaoyun Li <xiaoyun.li@intel.com>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com> CC: <thomas@monjalon.net>, <ajit.khaparde@broadcom.com>, <aboyer@pensando.io>, <andrew.rybchenko@oktetlabs.ru>, <beilei.xing@intel.com>, <bruce.richardson@intel.com>, <chas3@att.com>, <chenbo.xia@intel.com>, <ciara.loftus@intel.com>, <dsinghrawat@marvell.com>, <ed.czeck@atomicrules.com>, <evgenys@amazon.com>, <grive@u256.net>, <g.singh@nxp.com>, <zhouguoyang@huawei.com>, <haiyue.wang@intel.com>, <hkalra@marvell.com>, <heinrich.kuhn@corigine.com>, <hemant.agrawal@nxp.com>, <hyonkim@cisco.com>, <igorch@amazon.com>, <irusskikh@marvell.com>, <jgrajcia@cisco.com>, <jasvinder.singh@intel.com>, <jianwang@trustnetic.com>, <jiawenwu@trustnetic.com>, <jingjing.wu@intel.com>, <johndale@cisco.com>, <john.miller@atomicrules.com>, <linville@tuxdriver.com>, <keith.wiles@intel.com>, <kirankumark@marvell.com>, <oulijun@huawei.com>, <lironh@marvell.com>, <longli@microsoft.com>, <mw@semihalf.com>, <spinler@cesnet.cz>, <matan@nvidia.com>, <matt.peters@windriver.com>, <maxime.coquelin@redhat.com>, <mk@semihalf.com>, <humin29@huawei.com>, <pnalla@marvell.com>, <ndabilpuram@marvell.com>, <qiming.yang@intel.com>, <qi.z.zhang@intel.com>, <radhac@marvell.com>, <rahul.lakkireddy@chelsio.com>, <rmody@marvell.com>, <rosen.xu@intel.com>, <sachin.saxena@oss.nxp.com>, <skoteshwar@marvell.com>, <shshaikh@marvell.com>, <shaibran@amazon.com>, <shepard.siegel@atomicrules.com>, <asomalap@amd.com>, <somnath.kotur@broadcom.com>, <sthemmin@microsoft.com>, <steven.webster@windriver.com>, <skori@marvell.com>, <mtetsuyah@gmail.com>, <vburru@marvell.com>, <viacheslavo@nvidia.com>, <xiao.w.wang@intel.com>, <cloud.wangxiaoyun@huawei.com>, <yisen.zhuang@huawei.com>, <yongwang@vmware.com>, <xuanziyang2@huawei.com> References: <20220113102718.3167282-1-jerinj@marvell.com> <20220131180859.2662034-1-jerinj@marvell.com> <20220131180859.2662034-2-jerinj@marvell.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add queue based pfc CLI options X-User: ferruhy In-Reply-To: <20220131180859.2662034-2-jerinj@marvell.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0183.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::8) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a7f2221b-aca9-429a-5511-08d9e72f29d3 X-MS-TrafficTypeDiagnostic: MWHPR11MB0016:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: <MWHPR11MB0016FDEF54BF629D3239985C95289@MWHPR11MB0016.namprd11.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9NhsddzFMaTisv8M3bjv0+uBJxxO5vCSlWxILig9tpVbF8ONldoEFRmsZp/YwLazPiyzg/GHNDg2riIMv7Uyr00BZ2D7D96To0gWt1MWJQ3O6YXGHkoE7U4qgaTvBkQlIEPVCTtp+u4gujpNRRBjRnYKccxdPAtoGCnb6hxIFw8Hl//bKDm8vYwstVTlcPfBY3fm8e8zBYRytxqAjiSszD7dMg5GLHdXCq4uxyiJ8o9KXHd+4WaknwfwU7c7t66RoVtd25jJMDCutK4PEj54hu4FAZjA0K0ZaRrlTBQce7V/Sr9Z+zp6/8noOijo9c84bkfnzE3VVvJJTdvmdBCWPYI/+T2xKGKtURYPEC19uSCh0nu59krHU9lCw2iW4M1Tqv1FzVB2borJRTCqllYscxM24QWIPMz6WBqwtXXBbwGWuC95bvbD/EIPMR8ff2+L938Jxrl1BS3HsWtPSLo2IvqIiz0YWcRpBddOhq7JlFzZBW8xHKsnhByO4f5PvVQSkHFGYFrHDlK+GgcXPoztIKmsnvGcJHMxFiXar9WpX9rm1gbCvJItRLKthyyjnMsR/BXoIT6hCr3opuZQm9aovfdNx1PA5gSa2aR2yejWavbZ8yTXYoStfM0YfrsKX/uHNPpBPRrxCMuYwHnwXKsq+NqP5F+jEUuTvvWdMpwo8jMsijaZKbabd9mSTaicJICEWVPUPpe38XqLoqBB87mV+Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(44832011)(55236004)(2616005)(38100700002)(31696002)(53546011)(6512007)(508600001)(36756003)(83380400001)(26005)(186003)(31686004)(6506007)(6666004)(6486002)(7366002)(7406005)(66556008)(82960400001)(8936002)(66946007)(8676002)(66476007)(86362001)(4326008)(5660300002)(6636002)(316002)(2906002)(7416002)(110136005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amQ4VEhWeWFVZW82M2I4N0xOb3NidUN0Tkk1V1g1QzVTbjVUQVRvVWIvUWds?= =?utf-8?B?a1d0NWdXazdOcUprb0RNalBzTjduY3hHV1FIRmdPOCtzaE9QZ1BaZlI2cml3?= =?utf-8?B?bjhuQjZzMVJ5aE5Ha3NucGxxSTFTWmhySWE5SlU4QVRLVFpVMlpXci8zU085?= =?utf-8?B?QkROUDluZUlNa3FLbU9HRG43NklyRXJuK2xFbm1NOWt6YVVadzIvbDJYb3R3?= =?utf-8?B?ZEdCVCswY2F4QlJqazRiMU9IcjVGY3lVZ1JrVXVSVWtLNVI1ZXN3WTU4VjBS?= =?utf-8?B?VE1VVWtkYjJnVkN6OW81b0Jwb0kzdHBTdHpsanA3dFB6aXRNb3Vrd1FLdHVx?= =?utf-8?B?amVKd21pUUc2L05CNDRNYzBXMkxrY3IvZmkvc1Q3YzVtWGY0QjZNQzhCdUUy?= =?utf-8?B?Wi9QR3RvTWpqRXhjVGNNK2ROSVBHeStRNkl0S0F2cmVQSmpzeXV5eGdzUEg1?= =?utf-8?B?UHNLUTMxbndqcm00ZVRNczN2U2QyZHQrV1BadWEyT3dDN05SQzZEL1RnUG9Z?= =?utf-8?B?V3RDUDFjTmU4Q3dPTlBBcTdOTXY3dnVUTFhPRE15UEFoSjN4Y21kSmpKclln?= =?utf-8?B?RGkxaHNPOE51anZ5Uk9ITjIwQzlHakczYjhrckZEVFFTOFFDTklqbWhVRHFV?= =?utf-8?B?NFRTdnZzcEQ0S2xZUFZVR0RHYkhvNDlyUVkvMkVrMFJ5QkRjbW9sUnB6NVR3?= =?utf-8?B?cnA4ZGdTeUxXRnlZS1laVHF1K2hoREVYZUQ5MUkxajE3bHFhdS9XeE0rZGlJ?= =?utf-8?B?WlRuOXhTVGxRbXJYOUxqZlZiOHNrQVVMWEFpa1I5dGdFTGd5OHZlREtMQ2JS?= =?utf-8?B?d08vMkplKzdjWGtOdEd2aENPKzdEK1BPVlpIRVQ2QW9ldnNmZS9iSmx3U2I0?= =?utf-8?B?RVBsRWtRVzYzTFFlSU43dDJXUVF5MDROcWk2TFQ5aGNQK3NDS3lvYWt6UkpL?= =?utf-8?B?Z3U5R0xkTHl1enFJM25lVWZrOUhQNnpoK0RsVGo4ZFpMOUZCbWFRWHZaSkI1?= =?utf-8?B?RzI4Yms0RDhYdFR4T2RUeFl5Nmlmd1dQbm1rNTRMTlI2WlpJcHQrVzVtbE9Q?= =?utf-8?B?QXZoOWhWRkNsTzJGQjkrdmhtR2V2b2tkYlJ5R01LOUhvUUlqRVpHY0IxT0cv?= =?utf-8?B?cDFnb3VKNnp1VUhBVFl3ZWx6cFBqRllKUXp6ajVkem5FeURodzAvajNRZnM3?= =?utf-8?B?cVRobW9oSHJGYjFQNkhrR3dVcmdDRFhTS1NPcmFLekUyYXhGRG54RFY4T2Nt?= =?utf-8?B?aG4wK2d3RlZ4TGNkc1pEM3FYK3ErbVlRdGZQVjR2N1B2VExEeTRBRmJnWWZ2?= =?utf-8?B?blpzdHJUTlA3YWJkUXJ4VnYwOGlRU3cvQTdDdVFibW5vOEZtSklTMWFCNDJO?= =?utf-8?B?TEdyZ2ZWcUdtWi9zb0ZxMEVoK2t6OGYxTkMvd3MyU0xZaUNZeHppMi8vOCts?= =?utf-8?B?OTdWWFM2OGQ5cnlZaWZwcEZaREJvTzlUQVVUdk9CUGhYNUlIRVdNREJ1b2Y5?= =?utf-8?B?R3drdUE1dWJQNTVSZFA4NmVPU3dneTVwQ3g4MmdoSHVHRVRFUFpzVFgrWS9J?= =?utf-8?B?U1FyRkNxZW0yaWZXVDJCbklzUGVpVXcrbnVqRHFiakcxVmp6ZHpkbGF0YVRY?= =?utf-8?B?dWFsckJmc1BwRFVaeWlDYlpON0NSYkl6YnZtZkVGdWprVllybnpWdmxtNmlK?= =?utf-8?B?SVEyNGxFdGw3MHlqc0huaTRQbndXL3FxT1h1T2pBSEJUZTVSWWJob3loL3Rn?= =?utf-8?B?blorTmQwQ2VUT29qeFM3TGszUytLRFpJSlowN0dxa0tpVy9JNWlTUmIxL2Ux?= =?utf-8?B?RWgvazRsYUFOT1NCdTJlaE5LY0R1dll3TDQvWEQxNDRWc095Z0JiZ0JWWHN2?= =?utf-8?B?ME9iMEJ5VnN0bjljTk42TW1UeERMTlpsZjlOaEpySGFPQVNZU0k2cy9HeUZi?= =?utf-8?B?S3A0b2JuTE51NFFKWG05eFg0K05lSC9YU3ZVdlF2OEVWNzBHTFVVaXVlcW45?= =?utf-8?B?WEp0WHh4SmpMWEhzWXR0UGM1WWYrUjRaaXFVaHhTR2ZQRElIZ000RUtZVUV0?= =?utf-8?B?V3ZYVDZFRmJDNjFLNnFDQTNpNTJtRGlNUlNwLytsQXdjUFd3bDNFOWc4SXFK?= =?utf-8?B?MjZxM3FXWmp0bXpuc0trWThkOThIcVZTNC9FbWxLWTFReGs0SXJYNlVaOFlG?= =?utf-8?Q?W2rq36VTrp+pYws4s566by4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a7f2221b-aca9-429a-5511-08d9e72f29d3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 16:06:40.5829 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jks+628xM1LC+Eyr2g0Qsdtjvp7sufcn7Vw7OcqdR3/gV0VacFMziYXZOcWiVEz9HbEIz0y1+XirQAOYax3E/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0016 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 1/31/2022 6:08 PM, jerinj@marvell.com wrote: > From: Sunil Kumar Kori <skori@marvell.com> > > Patch adds command line options to configure queue based > priority flow control. > > - Syntax command is given as below: > > set pfc_queue_ctrl <port_id> rx <on|off> <tx_qid> <tx_tc> \ > tx <on|off> <rx_qid> <rx_tc> <pause_time> > Ahh I see the order is related to the configure struct, where tx_qid is part of rx_pause struct. Can you please explaing this items selection in the struct? Most probaly it will clarify the above usage. > - Example command to configure queue based priority flow control > on rx and tx side for port 0, Rx queue 0, Tx queue 0 with pause > time 2047 > > testpmd> set pfc_queue_ctrl 0 rx on 0 0 tx on 0 0 2047 > > Signed-off-by: Sunil Kumar Kori <skori@marvell.com> <...> > > +set pfc_queue_ctrl > +~~~~~~~~~~~~~~~~~~ > + > +Set the priority flow control parameter on a given Rx and Tx queue of a port:: > + > + testpmd> set pfc_queue_ctrl <port_id> rx (on|off) <tx_qid> <tx_tc> \ > + tx (on|off) <rx_qid> <rx_tc> <pause_time> > + > +Where: > + > +* ``tx_qid`` (integer): Tx qid for which ``tx_tc`` will be applied and traffic > + will be paused when PFC frame is received with ``tx_tc`` enabled. > + > +* ``tx_tc`` (0-15): TC for which traffic is to be paused for xmit. > + > +* ``rx_qid`` (integer): Rx qid for which threshold will be applied and PFC > + frame will be generated with ``tx_tc`` when exceeds the threshold. > + > +* ``rx_tc`` (0-15): TC filled in PFC frame for which remote Tx is to be paused. > + > +* ``pause_time`` (integer): Pause quota filled in the PFC frame. > + 'pause_time' is related to the TX pause configuration, right? At least in the config struct it only exists for Tx. If so can you please document this?