DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] examples/vhost_scsi: fix buffer not terminated
@ 2017-09-22 13:07 Michal Jastrzebski
  2017-10-02 13:50 ` Jastrzebski, MichalX K
  2017-10-12  6:44 ` [dpdk-dev] [PATCH v2] " Jacek Piasecki
  0 siblings, 2 replies; 22+ messages in thread
From: Michal Jastrzebski @ 2017-09-22 13:07 UTC (permalink / raw)
  To: yliu, maxime.coquelin
  Cc: dev, deepak.k.jain, Jacek Piasecki, changpeng.liu, stable

From: Jacek Piasecki <jacekx.piasecki@intel.com>

Fix size of buffer in strcpy. There was possible to get
not terminated string after copy operation.

Coverity issue: 158631
Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app")
Cc: changpeng.liu@intel.com
Cc: stable@dpdk.org

Signed-off-by: Jacek Piasecki <jacekx.piasecki@intel.com>
---
 examples/vhost_scsi/scsi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/examples/vhost_scsi/scsi.c b/examples/vhost_scsi/scsi.c
index 54d3104..de9639a 100644
--- a/examples/vhost_scsi/scsi.c
+++ b/examples/vhost_scsi/scsi.c
@@ -307,7 +307,8 @@
 		strncpy((char *)inqdata->t10_vendor_id, "INTEL", 8);
 
 		/* PRODUCT IDENTIFICATION */
-		strncpy((char *)inqdata->product_id, bdev->product_name, 16);
+		strncpy((char *)inqdata->product_id, bdev->product_name,
+				ARRAY_SIZE(inqdata->product_id) - 1);
 
 		/* PRODUCT REVISION LEVEL */
 		strncpy((char *)inqdata->product_rev, "0001", 4);
-- 
1.9.1

^ permalink raw reply	[flat|nested] 22+ messages in thread
* [dpdk-dev] [PATCH] examples/vhost_scsi: fix buffer not terminated
@ 2017-09-22 13:08 Michal Jastrzebski
  2017-09-22 13:23 ` Jastrzebski, MichalX K
  0 siblings, 1 reply; 22+ messages in thread
From: Michal Jastrzebski @ 2017-09-22 13:08 UTC (permalink / raw)
  To: yliu, maxime.coquelin
  Cc: dev, deepak.k.jain, Jacek Piasecki, changpeng.liu, stable

From: Jacek Piasecki <jacekx.piasecki@intel.com>

Fix size of buffer in strcpy. There was possible to get
not terminated string after copy operation.

Coverity issue: 158631
Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app")
Cc: changpeng.liu@intel.com
Cc: stable@dpdk.org

Signed-off-by: Jacek Piasecki <jacekx.piasecki@intel.com>
---
 examples/vhost_scsi/scsi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/examples/vhost_scsi/scsi.c b/examples/vhost_scsi/scsi.c
index 54d3104..de9639a 100644
--- a/examples/vhost_scsi/scsi.c
+++ b/examples/vhost_scsi/scsi.c
@@ -307,7 +307,8 @@
 		strncpy((char *)inqdata->t10_vendor_id, "INTEL", 8);
 
 		/* PRODUCT IDENTIFICATION */
-		strncpy((char *)inqdata->product_id, bdev->product_name, 16);
+		strncpy((char *)inqdata->product_id, bdev->product_name,
+				ARRAY_SIZE(inqdata->product_id) - 1);
 
 		/* PRODUCT REVISION LEVEL */
 		strncpy((char *)inqdata->product_rev, "0001", 4);
-- 
1.9.1

^ permalink raw reply	[flat|nested] 22+ messages in thread
* [dpdk-dev] [PATCH] examples/vhost_scsi: fix buffer not terminated
@ 2017-09-22 13:09 Michal Jastrzebski
  2017-10-02 13:53 ` Jastrzebski, MichalX K
  2018-05-14 19:08 ` Thomas Monjalon
  0 siblings, 2 replies; 22+ messages in thread
From: Michal Jastrzebski @ 2017-09-22 13:09 UTC (permalink / raw)
  To: yliu, maxime.coquelin
  Cc: dev, deepak.k.jain, Jacek Piasecki, changpeng.liu, stable

From: Jacek Piasecki <jacekx.piasecki@intel.com>

Fix size of buffer in strcpy. There was possible to get
not terminated string after copy operation.

Coverity issue: 158629
Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app")
Cc: changpeng.liu@intel.com
Cc: stable@dpdk.org

Signed-off-by: Jacek Piasecki <jacekx.piasecki@intel.com>
---
 examples/vhost_scsi/vhost_scsi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/examples/vhost_scsi/vhost_scsi.c b/examples/vhost_scsi/vhost_scsi.c
index b4f1f8d..b1a8c93 100644
--- a/examples/vhost_scsi/vhost_scsi.c
+++ b/examples/vhost_scsi/vhost_scsi.c
@@ -186,8 +186,9 @@ static uint64_t gpa_to_vva(int vid, uint64_t gpa)
 	if (!bdev)
 		return NULL;
 
-	strncpy(bdev->name, bdev_name, sizeof(bdev->name));
-	strncpy(bdev->product_name, bdev_serial, sizeof(bdev->product_name));
+	strncpy(bdev->name, bdev_name, sizeof(bdev->name) - 1);
+	strncpy(bdev->product_name, bdev_serial,
+			sizeof(bdev->product_name) - 1);
 	bdev->blocklen = blk_size;
 	bdev->blockcnt = blk_cnt;
 	bdev->write_cache = wce_enable;
-- 
1.9.1

^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2018-05-15  5:59 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-22 13:07 [dpdk-dev] [PATCH] examples/vhost_scsi: fix buffer not terminated Michal Jastrzebski
2017-10-02 13:50 ` Jastrzebski, MichalX K
2017-10-02 15:07   ` Maxime Coquelin
2017-10-05 12:35     ` Piasecki, JacekX
2017-10-05 12:42       ` Maxime Coquelin
2017-10-05 13:01         ` Bruce Richardson
2017-10-05 13:02           ` Maxime Coquelin
2017-10-12  6:44 ` [dpdk-dev] [PATCH v2] " Jacek Piasecki
2017-10-12 11:09   ` Maxime Coquelin
2017-10-12 11:34   ` [dpdk-dev] [PATCH v3] " Jacek Piasecki
2017-10-13  7:12     ` Maxime Coquelin
2017-10-17 13:26       ` Yuanhan Liu
2017-10-24 16:22         ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2017-10-25 10:07     ` [dpdk-dev] [PATCH v4] " Jacek Piasecki
2017-10-25 10:18       ` Thomas Monjalon
2017-09-22 13:08 [dpdk-dev] [PATCH] " Michal Jastrzebski
2017-09-22 13:23 ` Jastrzebski, MichalX K
2017-09-22 13:09 Michal Jastrzebski
2017-10-02 13:53 ` Jastrzebski, MichalX K
2017-10-11 13:45   ` Jastrzebski, MichalX K
2018-05-14 19:08 ` Thomas Monjalon
2018-05-15  5:59   ` Pattan, Reshma

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).