Re: [dpdk-dev] [PATCH V2] net/bonding: delete redundant code

["Wei Hu (Xavier)" <xavier.huwei@huawei.com>]

On 2020/7/4 9:15, 197020236@qq.com wrote:
> From: pandongyang <197020236@qq.com>
>
> The function valid_bonded_port_id() has already contains function
> rte_eth_dev_is_valid_port(), so delete redundant check.
>
> Fixes: 588ae95e7983 ("net/bonding: fix port ID check")
> Cc: stable@dpdk.org
>
> Signed-off-by: pandongyang <197020236@qq.com>
Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
> ---
> v1 -> v2: Adjust commit info
> ---
>   drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
> index b77a37ddb..339374337 100644
> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
> @@ -1675,9 +1675,6 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
>   	dev = &rte_eth_devices[port];
>   	internals = dev->data->dev_private;
>   
> -	if (check_for_bonded_ethdev(dev) != 0)
> -		return -1;
> -
>   	if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0)
>   		return -1;
>   
> @@ -1704,9 +1701,6 @@ rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
>   	dev = &rte_eth_devices[port];
>   	internals = dev->data->dev_private;
>   
> -	if (check_for_bonded_ethdev(dev) != 0)
> -		return -1;
> -
>   	/* Device must be stopped to set up slow queue */
>   	if (dev->data->dev_started)
>   		return -1;