DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nirmoy Das <ndas@suse.de>
To: ferruh.yigit@intel.com
Cc: dev@dpdk.org
Subject: [dpdk-dev] KNI latency improvement
Date: Fri, 29 Dec 2017 15:27:03 +0100	[thread overview]
Message-ID: <0a4ff780-55fc-7c42-e3ab-b6b22a73cfbd@suse.de> (raw)

Hi Ferruh,

There is latency in the range of milliseconds when packets are passed
through KNI up to the IP stack. With CONFIG_RTE_KNI_PREEMPT_DEFAULT=n
its required sacrifice a cpu core. Do you have any suggestion to improve
latency without sacrificing a cpu?

What do you think about using cond_resched() instead of
schedule_timeout_interruptible(), in our test it helped to reduce
latency?

Index: dpdk-stable-16.11.1/lib/librte_eal/linuxapp/kni/kni_misc.c
===================================================================
--- dpdk/lib/librte_eal/linuxapp/kni/kni_misc.c
+++ dpdk/lib/librte_eal/linuxapp/kni/kni_misc.c
@@ -150,9 +150,8 @@ kni_thread_single(void *data)
 		}
 		up_read(&knet->kni_list_lock);
 #ifdef RTE_KNI_PREEMPT_DEFAULT
-		/* reschedule out for a while */
-		schedule_timeout_interruptible(
-			usecs_to_jiffies(KNI_KTHREAD_RESCHEDULE_INTERVAL));
+		/* reschedule out */
+		cond_resched();
 #endif
 	}


Regards,
Nirmoy
-- 
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB
21284 (AG Nürnberg) Maxfeldstr. 5
D-90409 Nürnberg / Phone: +49-911-740 18-4

             reply	other threads:[~2017-12-29 14:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-29 14:27 Nirmoy Das [this message]
2017-12-29 17:13 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a4ff780-55fc-7c42-e3ab-b6b22a73cfbd@suse.de \
    --to=ndas@suse.de \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).