From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 550477CFD
 for <dev@dpdk.org>; Tue, 19 Sep 2017 14:38:45 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga105.fm.intel.com with ESMTP; 19 Sep 2017 05:38:45 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,418,1500966000"; d="scan'208";a="901817603"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57])
 ([10.237.220.57])
 by FMSMGA003.fm.intel.com with ESMTP; 19 Sep 2017 05:38:44 -0700
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
References: <20170918151755.86605-1-ajit.khaparde@broadcom.com>
 <20170918151755.86605-19-ajit.khaparde@broadcom.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <0a5dbf71-8943-426d-7dae-a508e9b9cabb@intel.com>
Date: Tue, 19 Sep 2017 13:38:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170918151755.86605-19-ajit.khaparde@broadcom.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v2 18/19] net/bnxt: add support for flow
	filter ops
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Sep 2017 12:38:46 -0000

On 9/18/2017 4:17 PM, Ajit Khaparde wrote:
> This patch adds support for flow validate/create/destroy/flush ops.
> Also update doc/guides/nics/features/bnxt.ini to indicate this.
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

<...>

> +int bnxt_hwrm_set_ntuple_filter(struct bnxt *bp,
> +			 uint16_t dst_id,
> +			 struct bnxt_filter_info *filter)
> +{
> +	int rc = 0;
> +	struct hwrm_cfa_ntuple_filter_alloc_input req = {.req_type = 0 };
> +	struct hwrm_cfa_ntuple_filter_alloc_output *resp =
> +						bp->hwrm_cmd_resp_addr;
> +	uint32_t enables = 0;
> +
> +	if (filter->fw_ntuple_filter_id != UINT64_MAX) {
> +		RTE_LOG(ERR, PMD,
> +			"NTUPLE id %lx\n", filter->fw_ntuple_filter_id);

This breaks the 32bit build:

.../drivers/net/bnxt/bnxt_hwrm.c:3270:50: error: format ‘%lx’ expects
argument of type ‘long unsigned int’, but argument 4 has type ‘uint64_t
{aka long long unsigned int}’ [-Werror=format=]
    "NTUPLE id %lx\n", filter->fw_ntuple_filter_id);
                       ~~~~~~~~~                  ^

<...>