From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id E0D2E41D37;
Wed, 22 Feb 2023 07:20:55 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id BE3BB40697;
Wed, 22 Feb 2023 07:20:55 +0100 (CET)
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
by mails.dpdk.org (Postfix) with ESMTP id ACE8140693;
Wed, 22 Feb 2023 07:20:53 +0100 (CET)
Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.57])
by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PM5Zm2Fw4zKq98;
Wed, 22 Feb 2023 14:18:56 +0800 (CST)
Received: from [10.67.103.231] (10.67.103.231) by
kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.17; Wed, 22 Feb 2023 14:20:48 +0800
Message-ID: <0a6df956-60ef-5347-2e52-fb7f761729f9@huawei.com>
Date: Wed, 22 Feb 2023 14:20:48 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
Thunderbird/91.2.0
Subject: Re: [PATCH v2] app/testpmd: fix secondary process not forwarding
To: Shiyang He <shiyangx.he@intel.com>, <dev@dpdk.org>
CC: <yidingx.zhou@intel.com>, <stable@dpdk.org>, Yuying Zhang
<yuying.zhang@intel.com>, Aman Singh <aman.deep.singh@intel.com>, Anatoly
Burakov <anatoly.burakov@intel.com>, Matan Azrad <matan@nvidia.com>, Dmitry
Kozlyuk <dmitry.kozliuk@gmail.com>
References: <20221230075554.25244-1-shiyangx.he@intel.com>
<20230221154418.153972-1-shiyangx.he@intel.com>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <20230221154418.153972-1-shiyangx.he@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.231]
X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To
kwepemm600004.china.huawei.com (7.193.23.242)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
在 2023/2/21 23:44, Shiyang He 写道:
> Under multi-process scenario, the secondary process gets queue state
> from the wrong location (the global variable 'ports'). Therefore, the
> secondary process can not forward since "stream_init" is not called.
>
> This commit fixes the issue by calling 'rte_eth_rx/tx_queue_info_get'
> to get queue state from shared memory.
>
> Fixes: 3c4426db54fc ("app/testpmd: do not poll stopped queues")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shiyang He <shiyangx.he@intel.com>
> Acked-by: Yuying Zhang <yuying.zhang@intel.com>
>
> v2: Add function return value processing
> ---
> app/test-pmd/testpmd.c | 35 +++++++++++++++++++++++++++++++++--
> 1 file changed, 33 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 0c14325b8d..b450f3f6c4 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2418,9 +2418,40 @@ start_packet_forwarding(int with_tx_first)
> if (!pkt_fwd_shared_rxq_check())
> return;
>
> - if (stream_init != NULL)
> - for (i = 0; i < cur_fwd_config.nb_fwd_streams; i++)
> + if (stream_init != NULL) {
> + for (i = 0; i < cur_fwd_config.nb_fwd_streams; i++) {
> + if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
> + struct fwd_stream *fs = fwd_streams[i];
> + struct rte_eth_rxq_info rx_qinfo;
> + struct rte_eth_txq_info tx_qinfo;
> + int32_t rc;
> + rc = rte_eth_rx_queue_info_get(fs->rx_port,
> + fs->rx_queue, &rx_qinfo);
> + if (!rc)
> + ports[fs->rx_port].rxq[fs->rx_queue].state =
> + rx_qinfo.queue_state;
> + else if (-ENOTSUP == rc)
"rc != 0" and "rc == -ENOTSUP" style are always welcome in dpdk.
Additionally, it is better to add some comments about '-ENOTSUP' here,
because this patch does not describe it anywhere.
> + ports[fs->rx_port].rxq[fs->rx_queue].state =
> + RTE_ETH_QUEUE_STATE_STARTED;
> + else
> + TESTPMD_LOG(WARNING,
> + "Failed to get rx queue info\n");
> +
> + rc = rte_eth_tx_queue_info_get(fs->tx_port,
> + fs->tx_queue, &tx_qinfo);
> + if (!rc)
> + ports[fs->tx_port].txq[fs->tx_queue].state =
> + tx_qinfo.queue_state;
> + else if (-ENOTSUP == rc)
> + ports[fs->tx_port].txq[fs->tx_queue].state =
> + RTE_ETH_QUEUE_STATE_STARTED;
> + else
> + TESTPMD_LOG(WARNING,
> + "Failed to get tx queue info\n");
> + }
> stream_init(fwd_streams[i]);
> + }
> + }
>
> port_fwd_begin = cur_fwd_config.fwd_eng->port_fwd_begin;
> if (port_fwd_begin != NULL) {