DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Li RongQing <lirongqing@baidu.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] net/bonding: fix a possible unbalance packet receiving
Date: Fri, 9 Oct 2020 14:44:20 +0100
Message-ID: <0a936a50-abb5-15ae-7a1a-0a2ae7a9d03c@intel.com> (raw)
In-Reply-To: <1600770572-22716-1-git-send-email-lirongqing@baidu.com>

On 9/22/2020 11:29 AM, Li RongQing wrote:
> Current Rx round robin policy for the slaves has two issue:
> 
> 1. active_slave in bond_dev_private is shared by multiple PMDS
> which maybe cause some slave Rx hungry, for example, there
> is two PMD and two slave port, both PMDs start to receive, and
> see that active_slave is 0, and receive from slave 0, after
> complete, they increase active_slave by one, totally active_slave
> are increased by two, next time, they will start to receive
> from slave 0 again, at last, slave 1 maybe drop packets during
> to not be polled by PMD
> 
> 2. active_slave is shared and written by multiple PMD in RX path
> for every time RX, this is a kind of cache false share, low
> performance.
> 
> so move active_slave from bond_dev_private to bond_rx_queue
> make it as per queue variable
> 
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> Signed-off-by: Dongsheng Rong <rongdongsheng@baidu.com>
 >

Fixes: ae2a04864a9a ("net/bonding: reduce slave starvation on Rx poll")
Cc: stable@dpdk.org

For series,
Reviewed-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>

Series applied to dpdk-next-net/main, thanks.



      parent reply	other threads:[~2020-10-09 13:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 10:29 Li RongQing
2020-09-22 10:29 ` [dpdk-dev] [PATCH 2/2] net/bonding: fix RX queue conversion Li RongQing
2020-09-30  5:40 ` [dpdk-dev] [PATCH] net/bonding: fix a possible unbalance packet receiving Li RongQing
2020-09-30  8:40   ` Wei Hu (Xavier)
2020-09-30  9:12     ` Li,Rongqing
2020-10-09 11:56     ` Li,Rongqing
2020-10-09 12:04       ` Ferruh Yigit
2020-10-09 13:44 ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a936a50-abb5-15ae-7a1a-0a2ae7a9d03c@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=lirongqing@baidu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git