From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 50BB32D13 for ; Sat, 20 Jan 2018 17:15:51 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jan 2018 08:15:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,386,1511856000"; d="scan'208";a="21286038" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.20.25]) ([10.252.20.25]) by FMSMGA003.fm.intel.com with ESMTP; 20 Jan 2018 08:15:48 -0800 To: Pascal Mazon , Ophir Munk , dev@dpdk.org Cc: Thomas Monjalon , Olga Shern References: <1515692751-25257-1-git-send-email-ophirmu@mellanox.com> <1516282691-29698-1-git-send-email-ophirmu@mellanox.com> <40669d31-ba1d-7d20-04f2-004a0c5a6da2@6wind.com> From: Ferruh Yigit Message-ID: <0adbbad2-00a7-c4ce-d17f-e9bd470e0a62@intel.com> Date: Sat, 20 Jan 2018 16:15:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <40669d31-ba1d-7d20-04f2-004a0c5a6da2@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 0/6] TAP RSS eBPF cover letter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jan 2018 16:15:51 -0000 On 1/19/2018 6:48 AM, Pascal Mazon wrote: > Hi, > > It seems more logical to me to introduce tap_program (patch 3) before > its compiled version (patch 2). > Source code is indeed written down before compiling it. > > The doc section is a good addition. > I'll be happy to see the upcoming utility for turning eBPF bytecode to C > arrays. > I'd have liked to see automation code (in a not-executed Makefile target > typically) for generating the bytecode. > I'm being told it should happen in the upcoming series along with the > aforementioned utility. > > Otherwise code looks good enough (I couldn't see everything for lack of > time), considering that later patches are expected in next release. > > Acked-by: Pascal Mazon > > Best regards, > Pascal > > On 18/01/2018 14:38, Ophir Munk wrote: >> The patches of TAP RSS eBPF follow the RFC on this issue >> https://dpdk.org/dev/patchwork/patch/31781/ >> >> v5 changes with respect to v4 >> ============================= >> Update TAP document guide with RSS >> >> v4 changes with respect to v3 >> ============================= >> * Code updates based on review comments >> * New commits organization (2-->5) based on review comments >> 1. net/tap: support actions for different classifiers (preparations for BPF. >> No BPF code yet) >> 2. net/tap: add eBPF bytes code (BPF bytes code in a separate file) >> 3. net/tap: add eBPF program file (Program source code of bytes code) >> 4. net/tap: add eBPF API (BPF API to be used by TAP) >> 5. net/tap: implement TAP RSS using eBPF >> >> v3 changes with respect to v2 >> ============================= >> * Add support for IPv6 RSS in BPF program >> * Bug fixes >> * Updated compatibility to kernel versions: >> eBPF requires Linux version 4.9 configured with BPF >> * New license header (SPDX) for newly added files >> >> v2 changes with respect to v1 >> ============================= >> * v2 has new commits organization (3 --> 2) >> * BPF program was revised. It is successfully tested on >> IPv4 L3 L4 layers (compatible to mlx4 device) >> * Licensing: no comments received for using "Dual BSD/GPL" >> string during BPF program loading to the kernel. >> (v1 and v2 are using the same license strings) >> Any comments are welcome. >> * Compatibility to kernel versions: >> eBPF requires Linux version 4.2 configured with BPF. TAP PMD will >> successfully compile on systems with old or non-BPF configured kernels. >> During compilation time the required Linux headers are searched for. >> If they are not present missing definitions are locally added >> (tap_autoconf.h). >> If the kernel cannot support a BPF operation - at runtime it will >> gracefully reject the netlink message (with BPF) sent to it. >> >> Ophir Munk (6): >> net/tap: support actions for different classifiers >> net/tap: add eBPF bytes code >> net/tap: add eBPF program file >> net/tap: add eBPF API >> net/tap: implement TAP RSS using eBPF >> doc: detail new tap RSS feature in guides Series applied to dpdk-next-net/master, thanks.