From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0042.outbound.protection.outlook.com [104.47.42.42]) by dpdk.org (Postfix) with ESMTP id 3D330293B for ; Thu, 30 Nov 2017 07:44:49 +0100 (CET) Received: from BN3PR03CA0066.namprd03.prod.outlook.com (10.167.1.154) by CO2PR03MB2358.namprd03.prod.outlook.com (10.166.93.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Thu, 30 Nov 2017 06:44:47 +0000 Received: from BN1AFFO11FD032.protection.gbl (2a01:111:f400:7c10::126) by BN3PR03CA0066.outlook.office365.com (2a01:111:e400:7a4d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.282.5 via Frontend Transport; Thu, 30 Nov 2017 06:44:47 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD032.mail.protection.outlook.com (10.58.52.186) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.239.4 via Frontend Transport; Thu, 30 Nov 2017 06:44:46 +0000 Received: from [10.232.133.65] ([10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id vAU6ii5p029990; Wed, 29 Nov 2017 23:44:45 -0700 To: Ferruh Yigit References: <1493810472-668-1-git-send-email-hemant.agrawal@nxp.com> <8f1ddb5e-661e-6413-00ab-31814a7d5bf7@intel.com> CC: From: Hemant Agrawal Message-ID: <0aebe42e-2887-8788-0964-c7fc603e5c4a@nxp.com> Date: Thu, 30 Nov 2017 12:14:43 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <8f1ddb5e-661e-6413-00ab-31814a7d5bf7@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131564978868816416; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39860400002)(346002)(39380400002)(376002)(2980300002)(1109001)(1110001)(339900001)(3190300001)(199003)(189002)(24454002)(67846002)(31696002)(6246003)(83506002)(4326008)(2906002)(316002)(498600001)(47776003)(104016004)(77096006)(8676002)(65826007)(58126008)(5660300001)(65956001)(65806001)(6916009)(2950100002)(230700001)(31686004)(81156014)(81166006)(356003)(189998001)(305945005)(106466001)(229853002)(105606002)(53936002)(53546010)(36756003)(33646002)(68736007)(64126003)(8936002)(86362001)(23676004)(97736004)(85426001)(50466002)(2486003)(50986010)(76176010)(54356010)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2358; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD032; 1:o6cypVkramwZbEF/tqfUqtShwpb3Ywq83lxQbXmYG0Vemvu9WQ8dQwLjR5BaCR3XCX4U7KZfQcd6vbP3yTWNu+2LWLVC96YuJEL6KZ4UMoJ8iq92xRMMxTYe6di1W55+ X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b72c940-f79a-4f01-7f20-08d537bdd8bf X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4628075)(201703131517081)(2017052603282); SRVR:CO2PR03MB2358; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2358; 3:U7wSSvuhl6bs4yXbwueVECnPduLM041LI4abjvVZLD0c24kDqZ9Yv5IzRoWxSyCgdPlpTLTztukSwDZFxzdOPk84+/QJu2LjmblM9RDxxt+Hh5tT6+kjN/04xWMizWrJsf93E4BrD/Yi6DHF2NxvCHHASA6EwL/TqRT+1+HWtBthPBJjXLZlWwZGGxU8abBzdcwlWQNU7vu2ChLPA+PY1wjsNNFmX/de+dkBBpwQFXFDx/V+ICdD/6aiQDGSZUCM2OqfuESrDoMQC/SkgqBW30tPpQTYnyZ5f4LXmz7/vuKMbZKlS+KOsM9Y+BOU9ArZ5QroKghoBupB9ofK/ttdCK0uNi1Cgrff8EiLe5Ibr3k=; 25:vfpaMtiRrVYAp5YF2WwW2b7ZTEQKbEHK5AeAW/7w5JcsY9JfBMrKugnMvY/tEPfyQ1hxG8aWhKoah1tTwd9G0aFBtohYt7Pkz+KjD8eGFCRw3dV8deDiCmIqfhsf4I3J4XunLKPleILosFuy2tUZzAi1lVCXDR0swD5kLW8aFo8CMMj79mQea4NLHUkGXYF95Zv9cwzfNjvZK0oLFKGM6ZxsGEA8XoF1buXKnH15RQImtbSubqLRDxMD8nXkoQum6Fulr2dqxP9HAEEdEVtHNBZ/hG4s30UExnKyi0YUcDetY6AK0gWe54QMY/haQ/TaHYft60yEFX6e3SfdvHLAVA== X-MS-TrafficTypeDiagnostic: CO2PR03MB2358: X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2358; 31:URKBAxBudgkGClI3lqwkkMrDsg1/e3LVmlNzdtQHuMxpJhIUHXXGYJIAJvzS5gxhxJmNdgdkwjNsZM7XwwUpYsXk0GrIgsg4tHELEJp8Dv829DuCeKHnH6UDDJrxBKiU7+yaQnrQ73Q6tvir6SIi6nZkX+a09GbgNkjsV0q+odvqUvhVCBWvjUSeYrDvYCCDSOu/gChpV4mi82dxAXYVL6rymebkmJEVXx+f1WptBcQ=; 4:Fldb+a+CBM506CZLPk8ZFcWSLcJPqp4fBG4s0JCebBf5DSBjQ/kPl8kWHDk1nXBGoHtP2ge/lgvT0y27KHwSSG86caIjtwWNxw1aW8XWV9gYr0WvdcStqDssMchunIWaqHZS0kZLPHUEXyo7BBxvJK/GDiPx5SnwyczCG8by6cliTmvSAgL3vGeDVbHJDuaDblzWK+4opX/12I8WrP9+hMwbju0Vk1LplAGVL4JK/3io1obFzaIgo5qkQgkU2P4cEBYLzEg/DaFDQKZ0pPeGgS6N/KghtswRPKud0NO+uD1rfipWXgUtlzbztw+fVGFHB/ZlvRF8xSDNfk9OXxpsR92Sh4Z+ijsTGoYU+yQB2+k= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231022)(6055026)(6096035)(20161123563025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123556025)(20161123565025)(20161123559100)(20161123561025)(201708071742011); SRVR:CO2PR03MB2358; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:CO2PR03MB2358; X-Forefront-PRVS: 05079D8470 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjAzTUIyMzU4OzIzOnl4WGtzVm1ERWZpZVA3V1Avck4zRTJiTWtT?= =?utf-8?B?Y2pBbkNGbGVOK0srUzJiaDZ6aUFtZWY1K2NWV1BvMHVJM1FjbFBrcXRtaktF?= =?utf-8?B?MDNEM2puamJjc2FnNGE3d3JPUHZhZlkvdU0wd2RrcEROdjh0WGxVOGozMU16?= =?utf-8?B?a2NXY1RDSzA5WHh1U2lLYTZGUVVGRUYxQkVuSHFnV1UwcDRuUDlJazZ4d09G?= =?utf-8?B?cjVEaTNFVFI4am1WSTBheHVnZTFtTEhDa1N1bkRTUnlKekM2SHRQdlc2RS9W?= =?utf-8?B?NXp6SWtxSHVUd1d1NEloVmxuZlBnTzl0V0haQUlTR1hGU3d0OXFsTGhmUm5I?= =?utf-8?B?R3Jpbk9yeUt4Zm0rcXk0U1dqWktmbUxrOHZFR0lUR3E5eFpkeHBUUmtRMUJw?= =?utf-8?B?MWJSTng4M05OUjd2MjdJOWRPM085ejlGcHM3dFppa0ZQVnFud2pPYmVPSFNM?= =?utf-8?B?WVRIVXRPY2h6UElMTCtvQlFvWkhKNzdwWGZRdm5xa0lYYjhEQ0hhWFM3WlBF?= =?utf-8?B?bWFCMXpkMmROeFduUjl3VjBqeXNlL09mSHpqK1ZOa05jOTRod0dTSFFzOHVw?= =?utf-8?B?cUFFQ3FtSVorTmxScWFUYWk4WWQrS2lGTHFNRWJ6SzJMSDdQbWZ3NnpJSGVi?= =?utf-8?B?Z0xJNGpZZTA3SGdYOVBHZG9pTVVxblJ1aktiSTNBYVlJMGRwc3JjdHFxTy93?= =?utf-8?B?Z2JGYytuQkd4S0pZMGJXOVRQbGZabnNCdmlOd09JNXJkSmxOOUg1Y2lwRDV1?= =?utf-8?B?QVNuYy82NFZwYkhGKzU0aVpHd0V4YUdvejk2RlIzTTgzdkYzeGhzZGdLQlA4?= =?utf-8?B?d0xCckFpZDB3OUVxbnpVbnFGeUxjcVlmV2tLRk1uT1prUjV2cENzN3VYUkdy?= =?utf-8?B?ajZ5SXdCT1NFakNlSVBLZW00SURDU2JycEpYVk9TbTlYUFBSNVdSZU1lRWNT?= =?utf-8?B?YW83U0xHNzQxRWNRWFJ2ZFNnM2ZiaEJrRW1SNHZTOXpjZ3hZTDFuZGNEblcw?= =?utf-8?B?WkpCVDh0L3JEZ0tWL2hHRDlVUTBRS3IrMUpqNm1BNzZrUTBxS3J0LytVRk4r?= =?utf-8?B?N1JsZEhuRjRFb01OU3Z4RWlKWlNaa0prdHU4LzRlaXZpczlsUk1OTjVkWWNj?= =?utf-8?B?ckNSRW8zQzYzQUptemYvWUpOdFlDS0pNc01SSVpKOEVpbndkSDdwWmZqMFhu?= =?utf-8?B?T0QxVGlPZDJHZnZBRXRqYTVybEdMd3JUZktNdWNONmJWUWFWQi80dXdsNTcz?= =?utf-8?B?WHZ6dm53YjZPRWdDYncvSkNRQkl5dW0wQ0k2cmRBdEpUdmE4UmhCV3F0YmVz?= =?utf-8?B?djBuZGF2ankxMWRhbG9ldTNWd051RjI2NHVXNCtKekxkT3JnV3hWUGF1RWpT?= =?utf-8?B?cVMzelV5Sm1GdWNkc0tjVFBGYTl5Y1JubzNISmNkQ1NqcHFPRVVMWFhVSkNZ?= =?utf-8?B?NXcvdVdUeHpsa1M4WlZWUDA1U1pKL21TajBBeVdaOXJtWVVZelk2WGdPM2dQ?= =?utf-8?B?RUt1bVpMbzhkYm1GeXlsN25iSmo5NmozVWhlSUhaaDZ6TmNES0lzSXRzNzI4?= =?utf-8?B?cEZZMGphZEhpNmhieFI4SGJxL3NRM2k1ZjlGVUFkWEJLSVZrTEdqNDFoSktK?= =?utf-8?B?U2lyYkN5MFN5czFrek1LYTF0M093YXdwK2s3cWgwTXVBV2pwMThKT1B0aVVa?= =?utf-8?B?OGpqMDRQQlpkamtaanJjenpBMWtMUUl1ck91UW5YZHlIYm9JRVhSUnRBaDQ4?= =?utf-8?B?eTY1ejhLZDBuaFVsNFpTYitSSlFCbmhlNnJsVnZnUjFGLzlsVUYzVFVIb1Rj?= =?utf-8?B?d3ZKbGFQeXB1TUtTQi9pWjMvSkVGR3pkaURENGF2SStuL21xNmNQS1JocmtH?= =?utf-8?Q?PjYn53Cb2H+2u3ui5EtMz1JyCP9K8jpL?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2358; 6:gjaFMEVcW4HAXWPQcmpEoZqHqnc875VgnZHPHYthsnCx5+1D5z5xC8N6aEuoTfGPZzzIMJY2A1I7zF5LjR5cybQKSeHu9zjBpmBirqDaV/vhMbxhnm4pOZjVvu9ydr/lsfzHlP6Z5xjPjyS4stOzGooNNCQipRwQFcHDC8K8GoIQgoamZYo3kHAu+qWVc1ZivHXWalICSyDv8Q3JLeCHLTgY+Pv8QcJwf/dAPV1q2igaoAY/2iDyIo9AXSd4ptptbO8XucU8hzFbFNbA5ZMe8+dHIi5Zcy54oJnFN4PxkbOY9aCdAxjAsyJPbG2LWpCH3rHqjYXDIbzxe7153K8J37PDBLCs9ryx0NLVezrpn2Q=; 5:LxT4KHOKs7vDJ/Ejj1pQVlB61j/F5tKG/0eAqkgVPLxxEp6roPsnkaTXfD2qWIWLhJNYH1KnI0SkcS8uOisFWFxZJ+ffy0MS6AXBt2KAPAKWyISq7u7tN/U083N08WRyZKE8qb72pEKJKFVmd0ja36x1ENDSx1/5aWWiz7wZ2Vo=; 24:Iy8068wfdxPY9bPNXUZ5WkZTa1lqv36MTU9g6Pp8GxpZ9bZeoAgt3SoMm4BeurfW3pGUgmO0XMOZkwX39nWlPSu/z3ZZAFIb0HgVcwKvEN0=; 7:a5l448syPlUzoiZyHPNBWB0C1V8OVh8D/lP17LjzRpU6fHnCYsqJcQexhVu3/d5gtxI1MuRk42SkoIfsVYmYLzkcpWC0UF3fUp6hyEyncPqi27ctSSH64tRgI9GVvrLqI9eFHQQ3UGHQACszV+oUmX1z5E/UmbYAb55ibojFKtj3Ppj7mivrKjCoCz32AwaV1Mz8F3+qkDd6Wk1gojPtzjEkR1rWmDKw4GiITpwIhto3bDn1Dwpajuo/fVtAHQlz SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2017 06:44:46.5852 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b72c940-f79a-4f01-7f20-08d537bdd8bf X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2358 Subject: Re: [dpdk-dev] [RFC PATCH 1/5] kni: change and configure mac address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 06:44:49 -0000 On 11/29/2017 4:01 AM, Ferruh Yigit wrote: > On 5/3/2017 4:21 AM, Hemant Agrawal wrote: >> This patch adds following: >> 1. option to configure the mac address during create >> 2. inform usespace, if mac address is being changed in linux >> >> Signed-off-by: Hemant Agrawal > > Hi Hemant, Hi Ferruh, Thanks for looking into it. It is a just a co-incidence that I started working on these again yesterday :) I plan to send the updated patch along with application change in next few days. > > This RFC is waiting in patchwork for a while, is there plan to send a v1? I will > mark patchset as RFC in patchwork. > > As far as I can follow latest patchset status is: > > provide initial value and add capability to change > 1/5: MAC address > 2/5: promisc mode > 3/5: MTU > > There is a change request for 1/5, other two looks OK. I am taking care of comments. > But for all three the action done in kni_ops, which means application needs to > implement these features. > Not sure about pushing these common tasks to application, instead of all > applications implement same thing, does it make sense to implement them in kni > library? I don't think it is a good thing to implement them in library itself. Libary may not know about the equivalent Ethernet port and it may be a logical kni port also. > > 4/5: add gso_size info > Nak because it uses mbuf field with another meaning > ok, I will try to find other means. > 5/5: Add cleanup fix for multi process > Multi process support is not supported in KNI at first place, if there is a need > first it needs to be introduced and tested. ok > > > Thanks, > ferruh >