From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35F6CA09F2; Wed, 19 Oct 2022 22:52:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE4AF42BF7; Wed, 19 Oct 2022 22:52:54 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2071.outbound.protection.outlook.com [40.107.101.71]) by mails.dpdk.org (Postfix) with ESMTP id 09E8342BF2 for ; Wed, 19 Oct 2022 22:52:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OulN60VlgDWLJ8G1/lXhbWrwXbPDkz7o3ZV/q0F5tQBCgRJWErDm9Xr891vnPqr2FbRWAlmKuU74GA6pFi89yMpO/b7ue3nc7iJeTXkNExXttqGXU8m5qBr/H7udAW68dj+PMbxlqoI2jnkRvhnKccraRtVsHETqnAX+vTbZQWLzwkPRJtdHaZg0rcChM8GGpPv9gt7OJPbLDvCPYw0ael64vYPOv9MvnUVV158vt01+Qf1h0I4e7pNKU8gMTL2W7MeI7r/cXNUIk79jyytI1F/G+qbufLz1L5vG8h1ZFDT28S6y5x9LSxtdKMjXBcgFXrZHk+pQn9RDienKWzBpIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QNTWzBGqnmLP3f3FsSfNYn4nrbMEebQq7Mf03neK6cU=; b=IF+wieyTZRcvrf7JvOS+gOc3putqbmURVE0eFUYsW1RowtEAEE7TDSrTf9nx8q1zn/IBkYD+MG4hj0/ovLBwFGbv0yZoymeB8ZaGHjVvFsNuKvfvRXRjYKG8eMkqkdxGpjWdknBetxnboP3Hs8s1o6byQTdUlQmStDwrx2zSA6FAeYoz6bnKFkwbzpQKBCSudzvr92xJa21NwYmELwmvOblk2vpWGFCmZIFiYvelW5NqwTearGEBUDFwGEeOc37KTpdmyRG4H4taGgR7HWQvCPK3jgoCxcHvkb5BiAMGQxwJBUc+kuVlAoqyGMzRDujvzrQYFL1kQt3yI99+Ef2nZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QNTWzBGqnmLP3f3FsSfNYn4nrbMEebQq7Mf03neK6cU=; b=DJmFQf4RnJTtFOuxs3ilz1WRMRXUWqlE589hOguRUyBfi6aEGW337ogj/G84No6u65zEm1C72M+MPJVBQVdBBqW1pMBUS6L9YEK1XqX1ctGJQenie6B1CIzF9jy1bK7aN3i1+rtQ/+oL8B2//r8SptrvGs13JS39JQZhopDJtks= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by CH3PR12MB7498.namprd12.prod.outlook.com (2603:10b6:610:143::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34; Wed, 19 Oct 2022 20:52:50 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Wed, 19 Oct 2022 20:52:50 +0000 Message-ID: <0aef306f-5a48-e12f-9eb7-422c2726a355@amd.com> Date: Wed, 19 Oct 2022 21:52:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v5 1/8] net/gve/base: introduce GVE PMD base code To: "Li, Xiaoyun" , "Guo, Junfeng" , "Zhang, Qi Z" , "Wu, Jingjing" , Hemant Agrawal , Stephen Hemminger Cc: "dev@dpdk.org" , "awogbemila@google.com" , "Richardson, Bruce" , "Lin, Xueqin" , "Wang, Haiyue" References: <20220927073255.1803892-2-junfeng.guo@intel.com> <20221010101757.878317-1-junfeng.guo@intel.com> <20221010101757.878317-2-junfeng.guo@intel.com> Content-Language: en-US From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0070.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1::34) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|CH3PR12MB7498:EE_ X-MS-Office365-Filtering-Correlation-Id: f2d491a3-8451-4b07-481f-08dab213e1cd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ViK2WPBD/XAXSq8yLed7NCnYSc3W7acHQtzO1zMbw+pWom3LiO0UNJDsIPfZTErzI/oYxur/SxniTKvaF0blzp/r6PVBILJMledjxMUIaY5Kua8WGcdYAeBN77q8CrYu+zhVH1gxUsRNXnK8xW5rLfhJucsaI241YgGYp1Y3HkSl7wOYdMWOhlhkdSVeNsmv66pFWdsUpn1J4ZzHcYCaLTcf7xAk5QWSvMye9D4yQ2SFP0fubWuzJ1G9dIAgjv9VNIfamVyFpgSewcAycsVTo/JDA3hbpaYY8x2U+pc5JNt8WrqobnaodrD1Z24r54yID+YihGkTqFlqVTAGnplh4eu99y9fLhd/YQQulVfTl+5JoOTxx17XhNnT0uc8LfSZKhqUnLDJi5pNPVsdR/A14HlYVafgyrDU87uD4sIiLskBGRjDRwZ9XPiZvSst8OlX4DFx+5yTesDU0rwmr/LnUwY4pQjOdlPR4lfFYczq00oOczcaOCkowlR6em8ctCVaiJFPgO8wAH1rDDv53xdmL9gvAPuyhZzv9ygeGP92vO1/VAGBVLHv/P6dFJcBh7jmNqTIkMKenwTwIEOK07eVchP79BI1s6Pauv2snI3jU3C9wch2vWT4pQSxmFKm7m51l60ciEsX6ex4whZSuaPGq7poGufxoJNW3zkwIBh6JGUJhdSogQt8UBJeAHJcRWZEmQrgADDL63YL8KHv31+wHl7aASgNaTiz9/FS9wR7X8oviaXrbfjR82iS1qac349Cr2eZ+ye4sRh3XkhxQn8OOsBE6aUEuRHxg/HqsoHiIxDt3SYhWzMtnCovd9DHbLPdOsZO2ciIg0JC4kyT6Ls+vQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(376002)(396003)(39860400002)(366004)(136003)(451199015)(31686004)(36756003)(921005)(110136005)(316002)(41300700001)(38100700002)(83380400001)(8936002)(8676002)(66946007)(2906002)(5660300002)(4326008)(7416002)(66476007)(66556008)(44832011)(54906003)(186003)(6512007)(2616005)(26005)(6666004)(6486002)(966005)(31696002)(86362001)(53546011)(6506007)(478600001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmV4M0JwK3gwY3pTMG9semJJQlZDcXpFVXcyQ21JQ2xkRCt6NkJpWng4RUU5?= =?utf-8?B?YjBHOXRBd3VXbkhGRk40aStiZGNzdlNDSVUvditmd1Z6MkJyRE9UNEtvOWtB?= =?utf-8?B?aE5yOW9nbU1LcWljcXZtd0l5TFQ2RGVxK3BtdGppWU8zalc5dU9pQ1V0M0gv?= =?utf-8?B?SFRneUoxZ0RZdGNaRE4wK2lpTHlCejRmZlUrUGhKZ2FvQ3VRVHhRcnpUZnpV?= =?utf-8?B?OW9vNkVVcHNoQnFKbjFRRjA5SGJHVzl3QUZJM2NZUVZvcDdJR28xTFN0V2lw?= =?utf-8?B?UEhIUXVnZ2cxNk1YVndWR1g2QTA5alYxc28rUVUyK2hwRW9JMzBxdXA2N0JJ?= =?utf-8?B?Q2hPMlVMMDgvcEVYenFuMEpwYms3eGoyR1FDY2d3SXJObXJDUytESHdZUFVP?= =?utf-8?B?eTNZNGFRdHlOcWMraFROZjF1QVAxTDdtQldSM2p6OGMyYWJ0R3A5VW9vYTdG?= =?utf-8?B?VWhSOHFaQ1doVk8xMzY0T1dwZXF2blBDYWZDcTZmUmtKbkdEc1dhMkk2b2Nk?= =?utf-8?B?NjErTy9LWGUwaUJtUUJmdDVoRUlMd2hNbmdWZmZRTmJXd0xZTUNpR0hRMUky?= =?utf-8?B?cnZla3ZvdWF0OG9ITWhVcDJvMjRHRHR1Ynl3aWJQbzF6c0N1NWZHcnhoWFAx?= =?utf-8?B?NUFZK2REdlRSVGs4TlpZTlJhb0tjbUJhTjZMUzFLTWcyMUY2Szd1ZXRnTk81?= =?utf-8?B?eS9PYUxocXpoOVN5RlZUbGJyS3NlelMwSjM0UXZzOHFiWEtkWUtVbGNBNGtj?= =?utf-8?B?T20rdGdGNmszckVocmVGc3JDU3ZsVzd5WjNYVDBZRk1NbGd2dG1Oa3g4dGFJ?= =?utf-8?B?L1RIVW14eTF3VUY2c1A2UkNzTk1DSytXT3hiWnN6WHlXdWFLRnZtTnk5aXJG?= =?utf-8?B?RFpucTV0ZkNqZ3hJNjRFSE1TRlNucytINDM4akNkY0dyVmJBZUdueEZGaGhD?= =?utf-8?B?eDhuRXoxb0RZSGU2MWo2alk3bDB0MjNKQzM2SkRCMExRNTJQTk9mT05nYi8z?= =?utf-8?B?ZldSWU0vRWp6MkJRdlpxb2hsWjdZNzMvRXQ4MEJBeHJQVnBVNHcwKzVzWmly?= =?utf-8?B?UU40ZjR6OFp2dW1JL2dIWnRidTVmdURjVTJGSno1N0Q2UGxhZWM1TTFEb1Mv?= =?utf-8?B?Qlo0NmRLM0I5dmtUYUhPd0tLV3lkd2JoakYxQ0lLMEFQeElway9mUjYvVG9X?= =?utf-8?B?MER1SG1NMk82ZDlkRnY2R0tqQUdGUk5MVjlONXRMUG40eHZsVGNQM0hUeWIx?= =?utf-8?B?aEE1b1JOaysrNmxpTS8vSlRQclB3WmNUa1RTNkYxanhkY3JVN1JlQ3FBWkZD?= =?utf-8?B?WjBLVlMvbjVVUElXYnVzWm5RcDcxV05lMitJYzdxNWl6d0ZldTZYMFNGVVZE?= =?utf-8?B?Q2VXczg4N29nSU1yOC9IS0hjek03U1V1d1p5aHJmWWNOWjMrWTVjc0RsL1Q1?= =?utf-8?B?NlMyNDMwYlpMMEFzWjlWeVNGSU9NV2pPVXZuMTFkOGFlZ0lWL0lLTHo0NXQw?= =?utf-8?B?TVM1eVltajhCc3ZMWHVSQkJ6blNkYlVJWjQ5Ukh3WC83a0RObWFYc3lSU3dZ?= =?utf-8?B?d2VwOUdjcWhVY1lmcktIQ25HYUJGRk50VjFrTEF5MVBEanM3QWRDb0JGbGl0?= =?utf-8?B?SzhaNDk5eHZlU0JXMDNYeFBNc2NjR0FCNGd4S0N4VHhDOTV4cERja21OTnpV?= =?utf-8?B?cG9HbkdETmJ2ZGI5ZmVoWUxCeWpBT0JqWVlIcWpkRUNPeUdIRGxhN2NuZUN2?= =?utf-8?B?bjBNNWxQdFVTSkZ3amNEU295S0hUb1NaT2hHamxaQWxGSUd5VlRpb01MT3Fa?= =?utf-8?B?WEo2b3N0WmRqNnNlUi8zd3Jpc2lPYWtEZnNnS3FVTDI4YnVJZ1AzWUdWWDBu?= =?utf-8?B?dnNDcE80TDhlVVpPYTdURkx6S2dXYmc5cDlHbXBEem8xM0xKaFp2ZndBeE5B?= =?utf-8?B?eEtoNVI2alBteXNQRWtKeXl5eVNnM3hqK0VYdGYwc2xEVmlhQ21hdmFIVnJW?= =?utf-8?B?QTNWbGZKaGdYTzJXQnZlYmdJdlRFYXhERjJ4b0dSSEdQdmxQRjh5M0UrQjNO?= =?utf-8?B?eUpqTEZtaUN2dURicmxpYTg4aGdnZ09VbFVpeTFjQ2hJb1Q4VE9kbG1pNjQ1?= =?utf-8?Q?bNi5+C9YpGzJb+cP2SG0D7U31?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2d491a3-8451-4b07-481f-08dab213e1cd X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 20:52:50.2671 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zSPbeip2gkPQ6aW/g8pI8sSLitB0UrtmX1iV35arDRCJvDVcAGE/AIj6zvgrlaFX X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7498 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/19/2022 4:48 PM, Li, Xiaoyun wrote: > Hi > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Wednesday, October 19, 2022 14:45 >> To: Guo, Junfeng ; Zhang, Qi Z >> ; Wu, Jingjing ; Hemant >> Agrawal ; Stephen Hemminger >> >> Cc: dev@dpdk.org; Li, Xiaoyun ; >> awogbemila@google.com; Richardson, Bruce ; >> Lin, Xueqin ; Wang, Haiyue >> Subject: Re: [PATCH v5 1/8] net/gve/base: introduce GVE PMD base code >> >> On 10/10/2022 11:17 AM, Junfeng Guo wrote: >>> The following base code is based on Google Virtual Ethernet (gve) >>> driver v1.3.0 under MIT license. >>> - gve_adminq.c >>> - gve_adminq.h >>> - gve_desc.h >>> - gve_desc_dqo.h >>> - gve_register.h >>> - gve.h >>> >>> The original code is in: >>> https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-linux/ >>> \ >>> tree/v1.3.0/google/gve >>> >>> Note that these code are not Intel files and they come from the kernel >>> community. The base code there has the statement of >>> SPDX-License-Identifier: (GPL-2.0 OR MIT). Here we just follow the >>> required MIT license as an exception to DPDK. >>> >>> Signed-off-by: Xiaoyun Li >>> Signed-off-by: Haiyue Wang >>> Signed-off-by: Junfeng Guo >> >> <...> >> >>> diff --git a/drivers/net/gve/base/gve.h b/drivers/net/gve/base/gve.h >>> new file mode 100644 index 0000000000..1b0d59b639 >>> --- /dev/null >>> +++ b/drivers/net/gve/base/gve.h >>> @@ -0,0 +1,58 @@ >>> +/* SPDX-License-Identifier: MIT >>> + * Google Virtual Ethernet (gve) driver >>> + * Version: 1.3.0 >> >> There is a version macro in the code, is version information required in the >> file comment? > > Different versions of gve kernel driver change a lot. So for reference, I think adding the version info for the base code makes sense. Just tell the following update people which version is used. > No problem to add version to base code, it is already in the code as macro: #define GVE_VERSION "1.3.0" #define GVE_VERSION_PREFIX "GVE-" My question is if to have is in the *file comment* or not, for it is duplicate and another thing to maintain (I won't get surprised in the future someone update the macro but not file comment). >> >>> + * Copyright (C) 2015-2022 Google, Inc. >>> + * Copyright(C) 2022 Intel Corporation >> >> I don't know if it is OK to add Intel copyright, as far as I know this requires big >> enough contribution to the code, if this is copy of existing code, may be only >> original copyright should exist. > > It's not just directly copy. Directly copy like gve_desc.h doesn't have Intel copyright. > But gve.h, in gve kernel driver, it has a lot of info dpdk doesn't need or dpdk has its own version like txq/rxq info. > I'm not sure the contribution is a lot or not. But I suppose this patchset is following the principle that if the code is changed, intel copy right is added, otherwise, only google's copyright. > Thanks Xiaoyun confirming it is not direct copy, can someone in your end check Intel's addition to the file, and if it justifies Copyright or not? >> >> cc'ed @Hemant and @Stephen for more comment.