From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Rami Rosen <ramirose@gmail.com>, dev@dpdk.org
Cc: stable@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/virtio: remove unnecessary forward declaration
Date: Fri, 8 Feb 2019 18:34:54 +0100 [thread overview]
Message-ID: <0b17f3ce-456e-c3dd-35f0-574109cf42b8@redhat.com> (raw)
In-Reply-To: <20190123172948.4016-1-ramirose@gmail.com>
On 1/23/19 6:29 PM, Rami Rosen wrote:
> This minor cleanup patch removes an unecessary forward
s/unecessary/unnecessary/
> declaration of virtio_intr_enable() in net/virtio PMD.
>
> Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO")
> Cc: stable@dpdk.org
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
> drivers/net/virtio/virtio_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index ee5a98b..d8fd288 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -71,7 +71,6 @@ static int virtio_mac_addr_add(struct rte_eth_dev *dev,
> static int virtio_mac_addr_set(struct rte_eth_dev *dev,
> struct ether_addr *mac_addr);
>
> -static int virtio_intr_enable(struct rte_eth_dev *dev);
> static int virtio_intr_disable(struct rte_eth_dev *dev);
>
> static int virtio_dev_queue_stats_mapping_set(
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
I'll fix the typo while applying.
Thanks,
Maxime
next prev parent reply other threads:[~2019-02-08 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 17:29 Rami Rosen
2019-02-08 17:34 ` Maxime Coquelin [this message]
2019-02-08 18:06 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b17f3ce-456e-c3dd-35f0-574109cf42b8@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=ramirose@gmail.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).