From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id CE2671B612; Fri, 8 Feb 2019 18:34:59 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2ECCF40220; Fri, 8 Feb 2019 17:34:59 +0000 (UTC) Received: from [10.36.112.52] (ovpn-112-52.ams2.redhat.com [10.36.112.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D9E86013E; Fri, 8 Feb 2019 17:34:55 +0000 (UTC) To: Rami Rosen , dev@dpdk.org Cc: stable@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com References: <20190123172948.4016-1-ramirose@gmail.com> From: Maxime Coquelin Message-ID: <0b17f3ce-456e-c3dd-35f0-574109cf42b8@redhat.com> Date: Fri, 8 Feb 2019 18:34:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190123172948.4016-1-ramirose@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 08 Feb 2019 17:34:59 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/virtio: remove unnecessary forward declaration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Feb 2019 17:35:00 -0000 On 1/23/19 6:29 PM, Rami Rosen wrote: > This minor cleanup patch removes an unecessary forward s/unecessary/unnecessary/ > declaration of virtio_intr_enable() in net/virtio PMD. > > Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO") > Cc: stable@dpdk.org > Signed-off-by: Rami Rosen > --- > drivers/net/virtio/virtio_ethdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index ee5a98b..d8fd288 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -71,7 +71,6 @@ static int virtio_mac_addr_add(struct rte_eth_dev *dev, > static int virtio_mac_addr_set(struct rte_eth_dev *dev, > struct ether_addr *mac_addr); > > -static int virtio_intr_enable(struct rte_eth_dev *dev); > static int virtio_intr_disable(struct rte_eth_dev *dev); > > static int virtio_dev_queue_stats_mapping_set( > Reviewed-by: Maxime Coquelin I'll fix the typo while applying. Thanks, Maxime