From: "Min Hu (Connor)" <humin29@huawei.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Guo, Jia" <jia.guo@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: fix write NVM srwr alwayes return success
Date: Wed, 21 Apr 2021 17:15:44 +0800 [thread overview]
Message-ID: <0b2aa7f5-b4c2-c570-d4c4-d0ab9faea36e@huawei.com> (raw)
In-Reply-To: <BN8PR11MB3795516A46CF518511997B0AF7479@BN8PR11MB3795.namprd11.prod.outlook.com>
Hi,
在 2021/4/21 15:34, Wang, Haiyue 写道:
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Wednesday, April 21, 2021 15:12
>> To: dev@dpdk.org
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
>> <haiyue.wang@intel.com>
>> Subject: [PATCH v2] net/e1000: fix write NVM srwr alwayes return success
>>
>> From: Chengwen Feng <fengchengwen@huawei.com>
>>
>> This patch fixes e1000_write_nvm_srwr() alwayes return success.
>>
>
> As I said in v1:
>
> "This commit message seems not so correct, it should be like:
>
> This fixes the timed out for shadow RAM write EEWR can't be detected."
>
> What do you think ?
Fixed in v3, thanks.
>
>> Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> ---
>> v2:
>> * change 'E1000_ERR_NVM' to '-E1000_ERR_NVM'.
>> ---
>
>
>
>> --
>> 2.7.4
>
> .
>
next prev parent reply other threads:[~2021-04-21 9:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 6:22 [dpdk-dev] [PATCH] " Min Hu (Connor)
2021-04-21 6:56 ` Wang, Haiyue
2021-04-21 7:14 ` Min Hu (Connor)
2021-04-21 7:10 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-04-21 7:12 ` Min Hu (Connor)
2021-04-21 7:18 ` Wang, Haiyue
2021-04-21 7:28 ` Min Hu (Connor)
2021-04-21 7:34 ` Wang, Haiyue
2021-04-21 9:15 ` Min Hu (Connor) [this message]
2021-04-21 9:15 ` [dpdk-dev] [PATCH v3] net/e1000: fix timed out for shadow RAM write Min Hu (Connor)
2021-04-21 11:22 ` Wang, Haiyue
2021-04-21 14:38 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b2aa7f5-b4c2-c570-d4c4-d0ab9faea36e@huawei.com \
--to=humin29@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=haiyue.wang@intel.com \
--cc=jia.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).