From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: wangyunjian <wangyunjian@huawei.com>, dev@dpdk.org
Cc: jerry.lilijun@huawei.com, xudingke@huawei.com
Subject: Re: [dpdk-dev] [PATCH] vfio: remove unnecessary explicit type casting
Date: Wed, 16 Sep 2020 15:14:15 +0100 [thread overview]
Message-ID: <0b39f42c-0b13-93c1-6183-40f2a398d510@intel.com> (raw)
In-Reply-To: <884010e4-a9ef-9ff3-5a7f-67fd75ad393c@intel.com>
On 16-Sep-20 2:38 PM, Burakov, Anatoly wrote:
> On 16-Sep-20 1:41 PM, wangyunjian wrote:
>> From: Yunjian Wang <wangyunjian@huawei.com>
>>
>> The variables 'vfio_res->nb_maps' and 'i' are of type int. The type
>> casting of 'vfio_res->nb_maps' is redundant and not required.
>>
>> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>> ---
>
> I wonder if we should make vfio_res->nb_maps to be an unsigned int
> instead. I don't think we ever expect number of mappings to be negative...
>
Just checked the code, this would be a big reword as there's lots of
other places we do this, so for now i'm inclined to leave it be and
remove the unnecessary casts instead. So,
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2020-09-16 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 12:41 wangyunjian
2020-09-16 13:38 ` Burakov, Anatoly
2020-09-16 14:14 ` Burakov, Anatoly [this message]
2020-10-05 8:13 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b39f42c-0b13-93c1-6183-40f2a398d510@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jerry.lilijun@huawei.com \
--cc=wangyunjian@huawei.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).