From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) by dpdk.org (Postfix) with ESMTP id B39FF2C55 for ; Thu, 2 May 2019 12:40:30 +0200 (CEST) Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id D1E8DC2B6325EE198A8A for ; Thu, 2 May 2019 18:40:28 +0800 (CST) Received: from [127.0.0.1] (10.177.131.206) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Thu, 2 May 2019 18:40:24 +0800 To: "Pattan, Reshma" , "dev@dpdk.org" CC: "Varghese, Vipin" , "Burakov, Anatoly" References: <1556624124-54930-2-git-send-email-mousuanming@huawei.com> <1556774432-59147-1-git-send-email-mousuanming@huawei.com> <3AEA2BF9852C6F48A459DA490692831F2A44CFAE@irsmsx110.ger.corp.intel.com> From: Suanming.Mou Message-ID: <0b4192d3-f1db-22a6-29d6-d6d31e33d9ad@huawei.com> Date: Thu, 2 May 2019 18:40:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A44CFAE@irsmsx110.ger.corp.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.177.131.206] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 May 2019 10:40:31 -0000 Hi, Thanks for the advises from you all. The latest v7 patch has sent out. Br, Mou On 2019/5/2 17:54, Pattan, Reshma wrote: > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Suanming.Mou > > > >> static void >> +monitor_primary(void *arg __rte_unused) { >> + if (quit_signal) >> + return; >> + >> + if (rte_eal_primary_proc_alive(NULL)) >> + rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary, >> NULL); >> + else >> + quit_signal = 1; >> +} >> + > Adding the log message saying primary existing so, secondary.. would be helpful here. > I am ok to have it as default behaviour. > As Vipin mentioned, can you also update the document doc/guides/tools/pdump.rst > > Thanks, > Reshma > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 40C47A0AC5 for ; Thu, 2 May 2019 12:40:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 500F6325F; Thu, 2 May 2019 12:40:32 +0200 (CEST) Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) by dpdk.org (Postfix) with ESMTP id B39FF2C55 for ; Thu, 2 May 2019 12:40:30 +0200 (CEST) Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id D1E8DC2B6325EE198A8A for ; Thu, 2 May 2019 18:40:28 +0800 (CST) Received: from [127.0.0.1] (10.177.131.206) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Thu, 2 May 2019 18:40:24 +0800 To: "Pattan, Reshma" , "dev@dpdk.org" CC: "Varghese, Vipin" , "Burakov, Anatoly" References: <1556624124-54930-2-git-send-email-mousuanming@huawei.com> <1556774432-59147-1-git-send-email-mousuanming@huawei.com> <3AEA2BF9852C6F48A459DA490692831F2A44CFAE@irsmsx110.ger.corp.intel.com> From: Suanming.Mou Message-ID: <0b4192d3-f1db-22a6-29d6-d6d31e33d9ad@huawei.com> Date: Thu, 2 May 2019 18:40:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A44CFAE@irsmsx110.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.177.131.206] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502104008.OSj5m-yPuHXkwrcpL0BNii4Bmh-Pyko2DBEIvqAHhB8@z> Hi, Thanks for the advises from you all. The latest v7 patch has sent out. Br, Mou On 2019/5/2 17:54, Pattan, Reshma wrote: > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Suanming.Mou > > > >> static void >> +monitor_primary(void *arg __rte_unused) { >> + if (quit_signal) >> + return; >> + >> + if (rte_eal_primary_proc_alive(NULL)) >> + rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary, >> NULL); >> + else >> + quit_signal = 1; >> +} >> + > Adding the log message saying primary existing so, secondary.. would be helpful here. > I am ok to have it as default behaviour. > As Vipin mentioned, can you also update the document doc/guides/tools/pdump.rst > > Thanks, > Reshma > >