From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9E4BDA09E0;
	Fri, 11 Dec 2020 16:38:14 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 845DBC956;
	Fri, 11 Dec 2020 16:38:13 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by dpdk.org (Postfix) with ESMTP id 595D7AC9A;
 Fri, 11 Dec 2020 16:38:11 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 110C47F50B;
 Fri, 11 Dec 2020 18:38:10 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 110C47F50B
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1607701090;
 bh=VN6bbXutud403GgonH5wts2+ONxuYHl5uxwfayM9FbY=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=ZTuP/2D8R6zp3VX/fl3K6zlADU8ocFW0Dx1zGT67G3UqLq/b34e8UfBDnjTlmg7R3
 fAFiusVwbs+1cz66pcE4flwCcSyDFOnRPhHF9Cd4uI6P4ctSeAEJu6s4LfkXMuCtqx
 lHW+uZxyVIhGk7AqRrQRFNdzhePT4LDhACPwWyCA=
To: Ivan Malov <ivan.malov@oktetlabs.ru>, dev@dpdk.org
Cc: stable@dpdk.org, Andy Moreton <amoreton@xilinx.com>
References: <20201211153421.28382-1-ivan.malov@oktetlabs.ru>
 <20201211153421.28382-2-ivan.malov@oktetlabs.ru>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <0b53cfaf-3033-0b28-d0df-66b1bf3713f9@oktetlabs.ru>
Date: Fri, 11 Dec 2020 18:38:09 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <20201211153421.28382-2-ivan.malov@oktetlabs.ru>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 2/2] common/sfc_efx/base: check for MAE
	privilege
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/11/20 6:34 PM, Ivan Malov wrote:
> VFs can't control MAE, so it's important to override the general
> MAE capability bit by taking MAE privilege into account. Reorder
> the code slightly to have the privileges queried before datapath
> capabilities are discovered and add required MAE privilege check.
> 
> Fixes: eb4e80085fae ("common/sfc_efx/base: indicate support for MAE")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>

Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>