From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 249FDA0503; Tue, 17 May 2022 15:23:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 148D74282E; Tue, 17 May 2022 15:23:47 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0CCF94003C for ; Tue, 17 May 2022 15:23:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652793824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sJ2q4zdPQqC2rRkCfRF4u8n/aILRmRK3NcS2yU8jMNs=; b=Qn4z8xGRHLCv8D/zCSqTBs7tBFwJmNcgNAsqIJtN8XrCdLIuKw1dcUQ99CNcP1zrm9V6BR GLom0Gknrd7MTFTODiFfEMuV+pmMUbxmrBdKwBkuMq3rjUdMjmTauP7zee5uAoqpXmhBT6 QjwSYB1H5GrzcWrKs0SiR+yU5lpFevY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-413-4hpwahlqPYyeiSfomVGlaA-1; Tue, 17 May 2022 09:23:41 -0400 X-MC-Unique: 4hpwahlqPYyeiSfomVGlaA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D7D1886B8AD; Tue, 17 May 2022 13:23:40 +0000 (UTC) Received: from [10.39.208.44] (unknown [10.39.208.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0431E2026D07; Tue, 17 May 2022 13:23:39 +0000 (UTC) Message-ID: <0b589117-de9c-6be8-8d6c-6530f2ab6dd5@redhat.com> Date: Tue, 17 May 2022 15:23:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH 0/5] vhost: introduce per-virtqueue stats API To: dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com, i.maximets@ovn.org References: <20220510201720.1262368-1-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: <20220510201720.1262368-1-maxime.coquelin@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/10/22 22:17, Maxime Coquelin wrote: > This series introduces a new Vhost API that provides > per-virtqueue statistics to the application. It will be > generally useful, but initial motivation for this series > was to be able to get to get virtqueues stats when Virtio > RSS feature will be supported in Vhost library. > > First patch introduces the new API and generic statistics. > Patch 2 makes use of this API in Vhost PMD. > The 3 last patches introduce more specific counters > (syscalls in DP, IOTLB cache hits and misses, inflight > submitted and completed for vhost async). > > > > Changes in v3: > ============== > - Remove patch1, already applied > - Fix memory leaks in error path (Chenbo) > - Fix various typos (Chenbo) > - Removed unused IOTLB counter (Chenbo) > - Add generic packets stats in async enqueue path > - Add Vhost async specific counters > > Changes in v2: > ============= > - Rebased on top of v22.03 > - Add documentation > > Maxime Coquelin (5): > vhost: add per-virtqueue statistics support > net/vhost: move to Vhost library stats API > vhost: add statistics for guest notifications > vhost: add statistics for IOTLB > vhost: add statistics for in-flight packets > > doc/guides/prog_guide/vhost_lib.rst | 24 ++ > drivers/net/vhost/rte_eth_vhost.c | 348 ++++++++++------------------ > lib/vhost/rte_vhost.h | 99 ++++++++ > lib/vhost/socket.c | 4 +- > lib/vhost/version.map | 4 +- > lib/vhost/vhost.c | 125 +++++++++- > lib/vhost/vhost.h | 27 ++- > lib/vhost/virtio_net.c | 61 +++++ > 8 files changed, 460 insertions(+), 232 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime