From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33190A054A; Tue, 7 Jun 2022 14:26:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10D194021D; Tue, 7 Jun 2022 14:26:14 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id E5E5A40156 for ; Tue, 7 Jun 2022 14:26:11 +0200 (CEST) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LHV0P31HCzgYs2; Tue, 7 Jun 2022 20:24:21 +0800 (CST) Received: from [127.0.0.1] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 7 Jun 2022 20:26:09 +0800 Subject: Re: [PATCH] eal: fix segment fault when exit trace From: fengchengwen To: , , "Richardson, Bruce" CC: , References: <20220607120014.49823-1-fengchengwen@huawei.com> Message-ID: <0b9f04f5-6944-85e6-4c91-566476601368@huawei.com> Date: Tue, 7 Jun 2022 20:26:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20220607120014.49823-1-fengchengwen@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Bruce, Could you please test freebsd platform? I think it also have the same problem, but I hasn't freebsd enviorment. Thanks On 2022/6/7 20:00, Chengwen Feng wrote: > Bug scenario: > 1. start testpmd: > dpdk-testpmd -l 4-6 -a 0000:7d:00.0 --trace=.* -- -i > 2. quit testpmd and then observed segment fault: > Bye... > Segmentation fault (core dumped) > > The root cause is that rte_trace_save() and eal_trace_fini() access > the huge pages which were cleanup by rte_eal_memory_detach(). > > This patch moves rte_trace_save() and eal_trace_fini() before > rte_eal_memory_detach() to fix the bug. > > Fixes: dfbc61a2f9a6 ("mem: detach memsegs on cleanup") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > --- > lib/eal/linux/eal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c > index 1ef263434a..c6f2056197 100644 > --- a/lib/eal/linux/eal.c > +++ b/lib/eal/linux/eal.c > @@ -1266,13 +1266,13 @@ rte_eal_cleanup(void) > vfio_mp_sync_cleanup(); > #endif > rte_mp_channel_cleanup(); > + rte_trace_save(); > + eal_trace_fini(); > /* after this point, any DPDK pointers will become dangling */ > rte_eal_memory_detach(); > eal_mp_dev_hotplug_cleanup(); > rte_eal_malloc_heap_cleanup(); > rte_eal_alarm_cleanup(); > - rte_trace_save(); > - eal_trace_fini(); > eal_cleanup_config(internal_conf); > rte_eal_log_cleanup(); > return 0; >