From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id BE984727F for ; Fri, 27 Apr 2018 11:56:14 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 35AC610D456; Fri, 27 Apr 2018 09:56:14 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 55D6F10B2B22; Fri, 27 Apr 2018 09:56:11 +0000 (UTC) To: Arnon Warshavsky Cc: Thomas Monjalon , "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org References: <1524663944-30376-11-git-send-email-arnon@qwilt.com> <1524723664-30510-1-git-send-email-arnon@qwilt.com> <1524723664-30510-10-git-send-email-arnon@qwilt.com> <621e7964-0450-a66e-cbf3-4fbc3a5ad723@redhat.com> From: Kevin Traynor Organization: Red Hat Message-ID: <0bbd121b-eb98-82c2-4732-275bdf3082f1@redhat.com> Date: Fri, 27 Apr 2018 10:56:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 27 Apr 2018 09:56:14 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 27 Apr 2018 09:56:14 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'ktraynor@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 09:56:15 -0000 On 04/26/2018 11:08 PM, Arnon Warshavsky wrote: > Hi Kevin > > > + if (rte_config_init() != 0) > > + return -1; > > + > > I'm confused, is this deliberate? there is now two rte_config_init() > calls. > > > Please note that there are 2 eal.c files. One under linux and one under bsd > There is a copy of rte_config_init() in each. > > > Aaron's comments on v4 about rte_eal_init_alert() are missed? and > it's missing the clear once and error number like the other returns. > > > These comments were for code that I reverted to call panic again. > As Aaron pointed out, the partial treatment of v4 did not only > not-improve things, rather made them worst. > This code along with other panic instances thrown from within threads > will have a dedicated patchset. > I was referencing the code above (but as it's a duplicate call, I don't know if it was merge leftovers from a previous version). Other returns from rte_eal_init() have something like: rte_eal_init_alert("Cannot init logging."); rte_errno = ENOMEM; rte_atomic32_clear(&run_once); return -1; > Thanks > /Arnon >