From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 461BB429EB; Tue, 25 Apr 2023 14:00:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15C2640ED6; Tue, 25 Apr 2023 14:00:15 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 7383340395; Tue, 25 Apr 2023 14:00:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682424012; x=1713960012; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=IaRzMdpCdT/PSg/QUDlYyQsu+RMHzboZ+87tgxcFn6Y=; b=jV9dBQJJq4Hd58BIyJNsByQfekutvBfSwqXImKZ4QsZ4WhLdKSoPLVBv wP8u+8r8KP0x6DpcrDhWZ2X+bnGaJ3dZ4H4x8Ko+5tBEfh+lI8w7LyfNl 7Yi6jqKncSLRy3oseo3r1lK/uoElFtUN7OhjLLgabeUjVmPABuhBbGWaw GiOEV/g3kN4bPTGpSYzk9/yoyn1/fBBRY6gzsrTCnqmtfjuCI6qzL5PZB Z1gYwwIf5Nwd2TRq00ua7I9u+X74cknygaOssttswFf3DGKBDC1bAxqo5 xQuz7meHSEmNaA7lOghl1Zs1Q2TM7FUsGAL6zFqOytR/CBGvkoAxvMXVo w==; X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="346767277" X-IronPort-AV: E=Sophos;i="5.99,225,1677571200"; d="scan'208";a="346767277" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 05:00:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="726085715" X-IronPort-AV: E=Sophos;i="5.99,225,1677571200"; d="scan'208";a="726085715" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 25 Apr 2023 05:00:10 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 25 Apr 2023 05:00:10 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 25 Apr 2023 05:00:10 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 25 Apr 2023 05:00:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IAwb2dwX4Qffj3o8OOLMn0cJX+0W/uPw26TF691+7OtIpJwZ1BpzmGPRUCTYT6gdrNPKTuuTmAiGiTre7Qbi1h9vaHfo7XFarTyIS/5PczPYp1V7Zudu5wmkw4JMOUFrZJOZN0a2xSukjD0swJKV4BcrSrIGK0I+0WsmU9DI9CVRQvC8V6JkP2X9H95/jtD1zeZLITLzMzQ/E+t3aI4CyPOkgPjW9PeUCL6ZlFreJHQWz2QEx7NPebVU7PRSGlOAoGhjrO0QyXezN6HzQ2pnZcjTshy799GVs4YpULzGXCwcvZ5nhaQCdYoBV3cVKO5bw8H7r5sAMsumd85Y8V/dzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8kivt7VADaY4zDBaGxfAnoIGpOt+bPk4PCpPOFNKSK8=; b=ic7DEv0BP3ib7BoA7+2Jae8uLwTqAtrGBtE4iueUX099FdnnmnBrF2Gw6D3Pik8vLmOMyxDQcTe4haMdHyV75rm3u36mL6LBp166XUx1Z3jdD3ZrN9EfMWDopZ3u3Za5EdMp+Cwx360WQTIPj3i+DIh15Ph4bHXXQK8SMRchljcVIjI//83XZNQvAG0OSlRv4xNyz9rT/0kbO+LBtZJ9qGspTd+x4ybHsaZXdT0EX5eRXD6fVTn7d61GTnPIVlR2n3ymutnCgJ08qkIkJ30mrCoDM91xftKo2gpcQxK/O52srwZsG/asPD5+01SE0VrU8l2ihr/+bCp3bfQJ1Jk2xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by PH8PR11MB7072.namprd11.prod.outlook.com (2603:10b6:510:214::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.32; Tue, 25 Apr 2023 12:00:05 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::8d3b:6bb3:3e95:6c05]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::8d3b:6bb3:3e95:6c05%5]) with mapi id 15.20.6319.033; Tue, 25 Apr 2023 12:00:05 +0000 Message-ID: <0bbf69db-a227-8133-93a1-ba184b3ea916@intel.com> Date: Tue, 25 Apr 2023 17:29:52 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] app/testpmd: fix GTP L2 len in checksum engine To: Raslan Darawsheh , CC: , , , Yuying Zhang References: <20230402122619.10078-1-rasland@nvidia.com> Content-Language: en-US From: "Singh, Aman Deep" In-Reply-To: <20230402122619.10078-1-rasland@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN3PR01CA0186.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:be::7) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB0062:EE_|PH8PR11MB7072:EE_ X-MS-Office365-Filtering-Correlation-Id: 38b0c24e-2685-40a9-114e-08db45849ae5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qEARl+GHT1wTAOl6tAaBRAS0NCuSj+taG0pZ+HF4z6e7+RGrTCzaar9HuWvivb/iPN5b6YsQZnU3sfleHKFquPIomPttah2h/fSsx2KoKkJxgzt/nEr99nuApyIpzjuZaQeovCoauE40f70ARIlpIfoYl6RkhLpp404pM2tWw5+G412qZ//+06VSlFneNWslpjTj61l4qBXUA/yH9NDN7QsCBy/vU3nW6xsThFqO7Jx/v7Ox+bu4iHzYMe9LzsYdh6GhdfcNPgaLLiR1k2EW8ofWZI50E3RTKL32+GCSh5dIcITsAfnRSDTCYRzRBDbCZXCXMOwrWzCazgYWyEGyPraTtczGNzfEpcsA/yItiHjlAReW/L7iqzDkJVUu6Zk5iES5d1AIMq1u5TiPJ4+3je3xkJBUzt126RT8dBQqFj+2gL7K7swMQwSZxwEnXTPGrDHHT/GciuAJJGOG9PHOiNCrqS+/WRDkGod8hKYjMt1YL6eX6Clepm8zAL0V2TeZiS12/kuEMcrDX2UVZZG3GXOlAj6QWEDp3pBBCk1Pp/Xzf52/vdxzpkIlGz2jJjVTP6+efL4Y3PaGLa3cUqTb8WBHjSFznx5xotZdPW4PlUCsgmau7q8kq9pTD03HB3UtJ5r0TqKDb4PA/8Ib0wqQdw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(366004)(396003)(136003)(39860400002)(376002)(451199021)(31696002)(86362001)(478600001)(36756003)(107886003)(186003)(6486002)(53546011)(6512007)(6506007)(26005)(8936002)(6666004)(82960400001)(316002)(41300700001)(4326008)(66946007)(66556008)(66476007)(83380400001)(8676002)(5660300002)(31686004)(2906002)(38100700002)(2616005)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WHhzL0c5ZDFzVWF5TXJ3RlBLMVZzVFRLdkJETHFlUTJTSlhJbGhBNWVxQnBC?= =?utf-8?B?TndTbWJkNWlCeHVRbjhVNHdxUlVhYTV0Tmp3VU9rdjRFOFlTRWMzS2tHUWIv?= =?utf-8?B?QnFWZzM5czMyTDNxOUZ3M0dJODRhcVdUb0c3cDhBTjZNemFWYkxFNzVJaHBn?= =?utf-8?B?RXJVSHdsZmhjaEtOY3NaUFJwczErRGo4N3ZIV2pialhLbVhidkxjVXJkOTJo?= =?utf-8?B?NDJ6Zkt1djUzTng3YkhVL2dCS2NYajZYeW9FbVl6ZWhPOXRHUy9MdUQxYXRj?= =?utf-8?B?dGNIYkdkWGdxZWllTXNXYnpNdnpKcUx1aDRlMm9NazFPR2xVckhidWtsM3hE?= =?utf-8?B?a29CemR3a1ExVFAxbG54K3VObVBPcTkrVENieFNWYTVaU2NGMWt2Vkpqck9I?= =?utf-8?B?WmlaWGoxeTI3UkgwUVBPNVdoSkpJUjRYQnlzV1FobWV6RVMxRmFrd3lnMFRz?= =?utf-8?B?TFdRUlhwTFNJOFdSazRSSDN0dDFUUlI1YWhPbzBiWXlzL2drak90NVNIaEhm?= =?utf-8?B?WnF4cnlndUt2b3ZKQXNDTjdXUkxHY09YcEFib0JVVTMza0tZRFlSaGYwZmxa?= =?utf-8?B?QkdMUjU3aFBLelRXclhSTkRRU2JVck1kQ0dGZllXa1hEOExrRWJUOW1ROFRC?= =?utf-8?B?VHJXTVBMRitSR08weEVQdGN0SGdyY0gzdFo0UHBIbXEvZmQreFgvOS9BWkVp?= =?utf-8?B?OFZXWW9DTmlZTjRqZnlEdUFZa01QZTEyZkZOd2lrb0l0RDFqMjMwdk1tbU9T?= =?utf-8?B?TGI1T2J5NW13bHoyQ0dGVVpTN1VKQ0VremhwKzg0UlYzV1dmS1RmUGRmRjR3?= =?utf-8?B?S0lMQ3ljeng0SzNORkE2Vy9CbE8yMGpIdkV0aVdzeHI3N1ZYNWVxUG1HUEpF?= =?utf-8?B?SW5pMzRNbmhYT25PRzVsWURqU29ZVXdWODRxd1cvM25vWURJU0NvYlE1N0d2?= =?utf-8?B?Z2dOb2xyeTlHYkRqcU9kRlltVXVselZweExydGlhWSt6enRjbXkxVmxVZjVX?= =?utf-8?B?WGNrbVgzNGdoYlR5NzBYNFFkUndWWlBFYTFjV3ZYWHZRQmZlUXQwVU9JRTJ6?= =?utf-8?B?Z0Rob1prSGlFV3dVUmFPSFFsSjBsdm1OQ2FxT09IRCt3MDMxZFI3anFDZm52?= =?utf-8?B?VGpQOFVCYXZUeUFWTE1xVHNBTTRLenJlYmhmSWVxNy9zTm9oUFZ2bVovOW1K?= =?utf-8?B?THpHcVA4a3lnRWZ0RWkxODNhYWJsbWZuVE5qT1FVNWEyRHZVNmlqcWZCclRC?= =?utf-8?B?NGE1QlRLWlhCRnRLTlpaNlRHYTNPZHV0VFNXb0NRZng4R2lkRVpDRE8zQkJv?= =?utf-8?B?aWFNeHFJTC9zRUZYUlBzK09OSFJQZTVKYUJiSlVMWlVwelhzU0Q5NzJqQjFZ?= =?utf-8?B?MUJBMU0wUUphVDZ1WXZmQjJ1RjRUQnExUXVIRmV1K0ZvbS9na3Q2Z2w2OTlj?= =?utf-8?B?QjNhK3hBazA1SS8zaDlUZVdxVmdvWVgzQk9PZFhEdHVleElkaWpHekNUSjFE?= =?utf-8?B?S3JNdVZ3YTZTOGtXaEJTT2U5UngxQkhGanJRbTlaR3NuZlExaDZTYVZmS05W?= =?utf-8?B?Y2I2eGg5eExhajRid1dVdVNKdmlLdyt3SCtSNjNIYUZPRnNpdjFNYktqWlV6?= =?utf-8?B?SVMwdUdtMkQyeUxBcHRsTkVKY1MrTHNFTjBUU0FIUWRVbUoxMUZ2UHZQbTMv?= =?utf-8?B?OUdPQzBmcTVjZjVhQ3ZpbDJnV0cyQkFRWCtUU3RtL1c0N0RHK0RVK09sUGcv?= =?utf-8?B?K3pxWERMcnpFL1ZPM0w4bkN2S0JabWVtM3FPY2lFbFQzREF4TXFaanZqYW5L?= =?utf-8?B?YlZudUliTmQ1cVJwZ29jK1BwVUJEYU03ZEs0dFphL3I1dVRGQ2ZQRkthTGlo?= =?utf-8?B?T2xrRjkwdnhUdmZyY0x6WkM4VXlaNzlwVEdGM0lqZjlXcHZsVnVzQWYxKzF1?= =?utf-8?B?UllJWFFvZHk4WExPblR5ekZYOEtoRm51eGx5UEVBREMyYytuekFUZWJEYncz?= =?utf-8?B?bWIzbHUrS29ZTHFJZjFOTkJwazBTOVQzMDhLemlsMkdPbnJzdXdSUFJaMXd3?= =?utf-8?B?clM2Vk5lK1k4WFpjRk1YeFhXaFJCZzBhVHVoWFVaUlVhWktxUUVnRnlLdzNN?= =?utf-8?B?TGQyWUptRW9SVEdGN2YybjB4d0M2TktDUzF6QXpLazl0ZFlZSlVsWWNDR1VV?= =?utf-8?B?b2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 38b0c24e-2685-40a9-114e-08db45849ae5 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2023 12:00:04.4196 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /5bX+hsJO6puqhSPezCBPP82mbne5uf25UkWmECr8e2gCciNZca7ads+P/o2bFbTQ5GUBm052i0Hp9Svp7rQFB003HMkYwjmKqtSHvtzkTY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7072 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/2/2023 5:56 PM, Raslan Darawsheh wrote: > GTP header can be followed by an optional 32 bits extension. > > But, l2_len value statically set to RTE_ETHER_GTP_HLEN > which is defined to be > (sizeof(struct rte_udp_hdr) + sizeof(struct rte_gtp_hdr)) > > This fixes the l2_len to take into consideration the extension size. > > Fixes: d8e5e69f3a9b ("app/testpmd: add GTP parsing and Tx checksum offload") > Cc: ting.xu@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Raslan Darawsheh Acked-by: Aman Singh > --- > app/test-pmd/csumonly.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c > index fc85c22a77..b50b89367a 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -250,7 +250,7 @@ parse_gtp(struct rte_udp_hdr *udp_hdr, > info->l4_proto = 0; > } > > - info->l2_len += RTE_ETHER_GTP_HLEN; > + info->l2_len += gtp_len + sizeof(udp_hdr); Macro is unused after above change. So can be removed. > } > > /* Parse a vxlan header */