From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67276A00C5; Wed, 2 Feb 2022 15:05:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEC3740688; Wed, 2 Feb 2022 15:05:18 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id DE2F240141 for ; Wed, 2 Feb 2022 15:05:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643810717; x=1675346717; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=Fv/Rk5zCF2whmB2Cn65CJAuROBQ+vkPljmZdJbR/OvY=; b=mxBbUT8AOKBDmIkY8wmFFKwK7RCDJaiZC09JL0cAkVSVqbJEZQAPEdkc XiugvwmFumV+858z4EY558pJK4yjsZ4v10tf3SaGYi2sQ4b2rXLUbWFDC mCxLcWPzofgDKawicOGCfnuZLP4Gp6ZuVpBDn94op7lwZsuDZhs+j2cMy KPmgVG0i1FuQY0kGuQE3+InvlhyeU51iYipovcOTMHAXXFRmo92AY/pOo taBMoB7K9MN7fR9EDNQqzETkys+MqKkT6Q6nKEGrs2XOpvJWyfxncEQKM TaCXsEWrQ9C8SPTKNiLZDLDwmwmLdSpQcdkRYWrlLRTu6s+LO6yWVmrYY A==; X-IronPort-AV: E=McAfee;i="6200,9189,10245"; a="334279037" X-IronPort-AV: E=Sophos;i="5.88,337,1635231600"; d="scan'208";a="334279037" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2022 06:04:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,337,1635231600"; d="scan'208";a="698903115" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 02 Feb 2022 06:04:47 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 2 Feb 2022 06:04:46 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 2 Feb 2022 06:04:46 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 2 Feb 2022 06:04:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=le2sivDFSL97QhRB9Mpoou8wOiz/frO1jYFB3f1AEIWsGVUk9ubJ57nLbF/zJEukQ8wNEGfPBb1aERTFC2p/SzI5KzDjpcuzEEBFEU9Oti6TnBDpnpCijj9OgfaLyDumwTFagqgFFjULU7ANgSvP1J9UdecYKJbrjVsxbiocqQ/73+PE8QE2iFVDChA9/reRcFWTceJoCBfa0d1B2KmP7Abn/I7Ikeht3tcsdm3IYMdyUr6lzeZQXCR9iI17N2ypaH7MgwwO9IUeAs8aW7vIB8UgIUDagkZYmc04gwR5R8dRu1w+2j3pyGeuiBWRJ2Z2lIhkRAN5O3dhJoggFAltAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/VnnC4afeKmwdMnEBsSh0BnAaT9nhvliyqRjRZZ+lZY=; b=f5T2MtX7ChASHpaJoGfl5MHPY11hm91EQkPCMtipFQ/HwtLN/TVhG2JXJqGtD3pVGTguH+3JQrIgc/IVlWqNvMMz6MQvZBeg6tm8c7elE93kPQeqcI4Cy04l+C6hauNT3wVrgpegMFn7vc1YVXiXEUErq1Pe5mUlSYHFzlRVCJ6nfY/03jnrxt0E75KH+/8JAMCIQ6d1apjLsAPm61DDWTtwmk4Kpo5SskBZr9GcyqWmtAB5JUnKvgg7lnXgWb3AiDA3Cmkpcm9w/NPwEgB3GKB+o4Pfm6+jejTcodlE+3/oKRTftBQe1AWVZ7epR5NIbTiI+NvtzYeqQwW9sxa70w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MWHPR11MB1437.namprd11.prod.outlook.com (2603:10b6:301:a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.19; Wed, 2 Feb 2022 14:04:45 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022 14:04:45 +0000 Message-ID: <0bc43f49-72bb-36ca-1e56-f844af5d5ace@intel.com> Date: Wed, 2 Feb 2022 14:04:38 +0000 Content-Language: en-US To: Akhil Goyal , "dev@dpdk.org" , "Radu Nicolau" , "mdr@ashroe.eu" , "David Marchand" CC: Anoob Joseph , "matan@nvidia.com" , "konstantin.ananyev@intel.com" , "thomas@monjalon.net" , "andrew.rybchenko@oktetlabs.ru" , "rosen.xu@intel.com" , Jerin Jacob Kollanukkaran , "stephen@networkplumber.org" References: <20220120162627.4155695-1-gakhil@marvell.com> <20220130175935.1947730-1-gakhil@marvell.com> <20220130175935.1947730-5-gakhil@marvell.com> <944f52a5-2778-d891-d891-de982f358ebb@intel.com> From: Ferruh Yigit Subject: Re: [EXT] Re: [PATCH v3 4/4] security: add IPsec option for IP reassembly X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0271.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::6) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b7526aa2-c463-449b-58b7-08d9e654f742 X-MS-TrafficTypeDiagnostic: MWHPR11MB1437:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oWgh54HD4dWgshrK5mrsbyVxIiVmJwdFpnVnpY8C4obaDoJDLxfDpiR0RaXuIekpaeNB0YjE9c6XXGvXEcpz7TrcyoESYh8CK4yOyzh/Bi4gteQY5mPyxJVba0tHEaCbTjSLCQIq0X0q8zBtmzEWs4juxRAOmi0CIuHxgfmLrAosDATFeUzhuCLluP9Ni23/+lGfWCSIVTykeN8PTz5MeknocO0gkvk5B32s4DgZDE16+edsYfaRVaLlsxrs8VLF8ROFNY1MAwf14Fic78VgKv9bwh/DgGKQR59qkHINHPKaE9bDUUKEY8sNPIEuI1KfKL45cHDoicvOMtLe4qHjscX1OPkB9wL+5+3Xr8xUcFewU9B5P3TM3YL4yfUuMWgXmcTKVCY8f8q/pcr+huRFoTOkFpDYoaZ+L02OA9OkLe480I/OOO7JdrRgFzD7OzgjWGP29V8NOc0HOGkwNkNwiKjeeQf6oQCcwHHNvdAjWHnxgu9n7A9oXOdhK4blArFgaAziwJNcMODsSoDxR7L5TFEpcz1XpDmTu0QwbAIbGVbPeC8FBZGEoDjBUzG2NVNj6ucyGRzf2Ne2Pp3PjqugRkV94bWxU72LX/Yj45tcgC+5WB001HnX+8H1M+yBIbeiIjrVuuHAfoNBtsPBg7dGcXW5ZUPW8WVy+qd+6YwzRhy69ghAbBmh4ecg7FCemmx2MXNWureH+/tAZAIFBmi6uQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38100700002)(66946007)(66556008)(110136005)(6486002)(316002)(31686004)(36756003)(54906003)(508600001)(66476007)(44832011)(8936002)(186003)(26005)(5660300002)(53546011)(31696002)(55236004)(2616005)(86362001)(2906002)(6512007)(15650500001)(4326008)(6666004)(8676002)(7416002)(82960400001)(6506007)(83380400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWs5SjdBSVpWSjZ5cHhCVU1SQTA2aXVZTjNEbUY5MDlwYXI5aGxBb1U1UTJq?= =?utf-8?B?b3BzTGJMRlpyQjBlc09nSldqZm1ZNk50aHpPd0ZFbVU1YjJmYmdVSzdrWEhS?= =?utf-8?B?SHJCdi91OUZsUmM0RU5vT1B1bHd5TjFKajN0NTBxcUoyWXJmTTB6TVFoQkJM?= =?utf-8?B?emFQWkV5NjI5VlpXNGh3UVV0Wll3YUp1M292LytlRXRGdWR1Z2FmZElubGs2?= =?utf-8?B?emg2UkF4cUV1dHJIZE50RTd2WjNoRXhkY084YWxrT3NQR0h1OWNYS3hFcFFx?= =?utf-8?B?dDNoWkxHaGV4aU1nd3l6U2F5M3htWmJlVGJYelV2YmxibG9XbFAydzk4RGVa?= =?utf-8?B?MkQ3SlcycFhKcmh3NHdmbjdGVzlaNGZhenVzVmxKOTE2dEtvcVdPZkRsYVVD?= =?utf-8?B?dTRtM3k3K24zS1ZNSlpuNHZ5UG0yUGo4VGwwdFpDdHVVZGRKK3RmRDNuaDYy?= =?utf-8?B?T1VDcitldnMxMUtPOGVsaVNOWDIxSE9vQVVsd20vZG5sQlhMeVpSVzhNQWd0?= =?utf-8?B?TGlPZE5XOVNXWUV5VWJBb2VEWUtMNnhjd0RoS2IvTUg3dkthczJ1UUwrVmN4?= =?utf-8?B?bUJ1bHpuVU9WL2FVM2VjZkpuOUJ6cTZZem9zMGVVV015S0dGWWZHMVpNbWtK?= =?utf-8?B?ZHFjMytvN2dhT0pobktnREtlNzFvYm1KSmNwRGQzZ3JRTjZJZjVjQzJTMTVp?= =?utf-8?B?a1lpWHJhT1B1dXhCSm5lTDAwK1JDRFQ4ZnlQZUVNRk5WdzVqUmNQT0J2dlIz?= =?utf-8?B?aEsxMzBZZ1p5RG53SUI1QjVzVFE4RDhkdVh2WEpybmgzVjJqQWltYUMrcDhC?= =?utf-8?B?cllTMVBMRStzUm9IdU1yWHIrekdiYm5ROEFHNTdQeUJtbzlmTGNtbUJBM2Vi?= =?utf-8?B?dG5ZWHI5MkZjS0lOQzFaMTVlcEhoMmN0dGVPck00MWl6OWsyaVNUYTJSRlZM?= =?utf-8?B?NUNxN1ZXVDRWS2NUaklSWWtBQjFMcHNRRzU1cGF4YmdoQkxHVUdaekk2cGQw?= =?utf-8?B?dG9VMitTT2VaM1BkTnU1Z0F5OS9ocTJidzl6Z1lZS056by9pb0M3aUNlNUIw?= =?utf-8?B?Smp4cHBGcVltMUVXdERtdm1rRldCeHJQdGgzbVF3SXBITm9zQXhKWjhJanNU?= =?utf-8?B?RlREdDNOUUdrUk5vaDlzaFgzQ21VaHFtVGw2OXBMQ25YNkN3QlRPTGdTamx5?= =?utf-8?B?dGtLcXErYjFvaU9za2hYTmdJeWw1Tklxd2I2SVY0R2Y2WWgxMGZIS3lBY280?= =?utf-8?B?TDlHTHU0cFZidW9ObEZQN0Y5MGE3ZVdLbU5XV0g0ZWtKQ1FxRnBnaHNHVGxO?= =?utf-8?B?bDBmMGVrWDZnVWJGOHBDempuY2tHM2dnRnhMK3QyUStEdE1NTko4NWVjVGxn?= =?utf-8?B?VWR1VmxkSko5UHY2SGZVNExPL2VnajV4TUxnKzdqZ1dwTldTOEpUOUt4MmFS?= =?utf-8?B?N0VhRnBqVHp1RWxBcmxMNlNVYlZ5RFBGOVZtRDQ4UGlOdmo5K04wTEl2a29m?= =?utf-8?B?a0dHdGorbUpqcE54SFpSOWQ0Z0Q5UTVkNklvdjVIN1pnRWx4UVplUklHQjFx?= =?utf-8?B?VjJjR1M5ZGdvUnZMcGI0SUZKUWZ0eW56RXhLS3VtZzdBdGlyZDlVVTFSNGw2?= =?utf-8?B?UjNxc2FKMHUvbTBwMDFZbW9HMXlwOUNLNFVRYlhtQnZ0SnRxZUFaTGdzTkpX?= =?utf-8?B?MmZBcmVTcTVvbnJvUXA5MkRpaE9ud00rS1pVSGNraFN4Z3lLVjl4T21zaTR0?= =?utf-8?B?bHlJcSswK2VraHB6TTlqeFdiZVBHdTBFN0VsVVBMN0J5TVFtMk9kckFtRWQx?= =?utf-8?B?TUNXK3VsQVcyVkRKcUN6dGhGdFRBdGVrN2F3WUh4ZjFicTlSdzRuUzI5Uk5H?= =?utf-8?B?V25ma3lDYmxheE9rREFqRDh5bkg1UUwxUzhVZFUzU3lXVnA2SloxN3F2L2Ri?= =?utf-8?B?ZXFQRzQrbmpMd2N4cTVTSGRmOVlxQmJLUTRxQjhyekFHUFZJVzM2UDI3UVhq?= =?utf-8?B?VURmNHVQdjNhNVREMkxLSjZKNnhoMHVrcGt3TkRSUmVTYXlrbmxSRkhZWkpv?= =?utf-8?B?c3RBWUJtNFVpUUhhcEdEQ2ZVaG1TY3pxNnhKL3ZKQ1NzTFFvazJMbEpJYWU3?= =?utf-8?B?dXpoL21LZGdmeHZ4dklDS2FQenA0TjB4Wm1aNDY5RllKWFJVTFdSdU1GcDFr?= =?utf-8?Q?BDfNgtu3Ei+8IRUBe8JBrIo=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b7526aa2-c463-449b-58b7-08d9e654f742 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 14:04:45.2722 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XQFnQLkvORDRCvhxQUmsx9ZT2qsjj2krIDeEWYONLVJw9LqsxtZJz47cjQ0uOm8unDMW/Rt+hh5pDZaS93QQ8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1437 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/2/2022 9:15 AM, Akhil Goyal wrote: >> On 1/30/2022 5:59 PM, Akhil Goyal wrote: >>> A new option is added in IPsec to enable and attempt reassembly >>> of inbound packets. >>> >>> Signed-off-by: Akhil Goyal >>> --- >>> devtools/libabigail.abignore | 14 ++++++++++++++ >>> lib/security/rte_security.h | 12 +++++++++++- >> >> >> +Radu for review >> >>> 2 files changed, 25 insertions(+), 1 deletion(-) >>> >>> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore >>> index 90f449c43a..c6e304282f 100644 >>> --- a/devtools/libabigail.abignore >>> +++ b/devtools/libabigail.abignore >>> @@ -16,3 +16,17 @@ >>> [suppress_type] >>> name = rte_eth_dev_info >>> has_data_member_inserted_between = {offset_of(reserved_64s), end} >>> + >>> +; Ignore fields inserted in place of reserved_opts of >> rte_security_ipsec_sa_options >>> +[suppress_type] >>> + name = rte_ipsec_sa_prm >>> + name = rte_security_ipsec_sa_options >>> + has_data_member_inserted_between = {offset_of(reserved_opts), end} >>> + >>> +[suppress_type] >>> + name = rte_security_capability >>> + has_data_member_inserted_between = {offset_of(reserved_opts), >> (offset_of(reserved_opts) + 18)} >>> + >>> +[suppress_type] >>> + name = rte_security_session_conf >>> + has_data_member_inserted_between = {offset_of(reserved_opts), >> (offset_of(reserved_opts) + 18)} > > Could not find any better way to suppress the ABI warning. > Any better idea? > +David for it, who knows abigail better. >>> diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h >>> index 1228b6c8b1..168b837a82 100644 >>> --- a/lib/security/rte_security.h >>> +++ b/lib/security/rte_security.h >>> @@ -264,6 +264,16 @@ struct rte_security_ipsec_sa_options { >>> */ >>> uint32_t l4_csum_enable : 1; >>> >>> + /** Enable reassembly on incoming packets. >>> + * >>> + * * 1: Enable driver to try reassembly of encrypted IP packets for >>> + * this SA, if supported by the driver. This feature will work >>> + * only if rx_offload RTE_ETH_RX_OFFLOAD_IP_REASSEMBLY is set in >>> + * inline Ethernet device. >>> + * * 0: Disable reassembly of packets (default). >>> + */ >>> + uint32_t reass_en : 1; >>> + >>> /** Reserved bit fields for future extension >>> * >>> * User should ensure reserved_opts is cleared as it may change in >>> @@ -271,7 +281,7 @@ struct rte_security_ipsec_sa_options { >>> * >>> * Note: Reduce number of bits in reserved_opts for every new option. >>> */ >>> - uint32_t reserved_opts : 18; >>> + uint32_t reserved_opts : 17; >>> }; >>> >>> /** IPSec security association direction */ >