From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7FC79A04FD;
	Thu, 10 Nov 2022 10:01:15 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 66834400EF;
	Thu, 10 Nov 2022 10:01:15 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 7AFA4400D4
 for <dev@dpdk.org>; Thu, 10 Nov 2022 10:01:13 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id EF59366;
 Thu, 10 Nov 2022 12:01:12 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru EF59366
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1668070873;
 bh=nIakNRRPwqOVkOVYRXAxs/6zJ4aqcEPT36QHBmDcdB8=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=tBAM1FTjgMexuGd62AWffJ3s3m2yM9b0m8u7Sh5iQWaE2h00abGijGMXLQh0E4CjD
 GRkoW3/4q2FL4pUVFXShNsMXEUcR9rjRdGLAIEj4dmvUQap523oM6SDhNcSGp8lbAY
 QC6RKZ6zds44ZtnfDdNsj3GDN11P4Nxo4wSKm+qo=
Message-ID: <0bcde78d-7eab-3925-9566-ae2e7a048c3d@oktetlabs.ru>
Date: Thu, 10 Nov 2022 12:01:12 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH v13 1/1] app/testpmd: support multiple mbuf pools per Rx
 queue
Content-Language: en-US
To: Hanumanth Pothula <hpothula@marvell.com>,
 Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, jerinj@marvell.com,
 ndabilpuram@marvell.com
References: <20221107053153.2275618-1-hpothula@marvell.com>
 <20221110081719.2404059-1-hpothula@marvell.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20221110081719.2404059-1-hpothula@marvell.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 11/10/22 11:17, Hanumanth Pothula wrote:
> Some of the HW has support for choosing memory pools based on
> the packet's size. The pool sort capability allows PMD/NIC to
> choose a memory pool based on the packet's length.
> 
> On multiple mempool support enabled, populate mempool array
> accordingly. Also, print pool name on which packet is received.
> 
> Signed-off-by: Hanumanth Pothula <hpothula@marvell.com>
> 
> v13:
>   - Make sure protocol-based header split feature is not broken
>     by updating changes with latest code base.
> v12:
>   - Process multi-segment configuration on number segments
>     (rx_pkt_nb_segs) greater than 1 or buffer split offload
>     flag (RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) set.
> v11:
>   - Resolve compilation and warning.
> v10:
>   - Populate multi-mempool array based on mbuf_data_size_n instead
>     of rx_pkt_nb_segs.

I'm sorry for inconvenience, could you rebase the patch on
current next-net/main, please. I've decided to apply protocol
based buffer split fix first. Of course, I can rebase myself,
but I want result to be checked very carefully and tested
properly. Thanks.