DPDK patches and discussions
 help / color / mirror / Atom feed
* Re: [dpdk-dev] [PATCH] eal: remove experimental from hotplug add/remove
  2018-10-02 11:04 [dpdk-dev] [PATCH] eal: remove experimental from hotplug add/remove Ferruh Yigit
@ 2018-10-02 10:08 ` Andrew Rybchenko
  2018-10-02 10:23   ` Ferruh Yigit
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Rybchenko @ 2018-10-02 10:08 UTC (permalink / raw)
  To: Ferruh Yigit, Rosen Xu, Tianfei zhang; +Cc: dev, Thomas Monjalon, Ian Stokes

On 10/2/18 2:04 PM, Ferruh Yigit wrote:
> rte_eal_hotplug_add() & rte_eal_hotplug_remove() APIs first added on
> v17.08 as experimental
> Commit a3ee360f4440 ("eal: add hotplug add/remove device")
>
> When __rte_experimental tag created, APIs tagged with it on v18.02
> Commit 77b7b81e32e9 ("add experimental tag to appropriate functions")
>
> After rte_eth_dev_attach() & rte_eth_dev_detach() APIs has been
> deprecated in v18.08 eal APIs are only ones for hotplug operations
> Commit 9f2be5b3db8b ("ethdev: deprecate attach and detach functions")
>
> These APIs are around for a few releases now and without an alternative,
> removing the experimental tag from them.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Dup of http://patches.dpdk.org/patch/45791/ ?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: remove experimental from hotplug add/remove
  2018-10-02 10:08 ` Andrew Rybchenko
@ 2018-10-02 10:23   ` Ferruh Yigit
  2018-10-08  2:58     ` Xu, Rosen
  0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2018-10-02 10:23 UTC (permalink / raw)
  To: Andrew Rybchenko, Rosen Xu, Tianfei zhang
  Cc: dev, Thomas Monjalon, Ian Stokes

On 10/2/2018 11:08 AM, Andrew Rybchenko wrote:
> On 10/2/18 2:04 PM, Ferruh Yigit wrote:
>> rte_eal_hotplug_add() & rte_eal_hotplug_remove() APIs first added on
>> v17.08 as experimental
>> Commit a3ee360f4440 ("eal: add hotplug add/remove device")
>>
>> When __rte_experimental tag created, APIs tagged with it on v18.02
>> Commit 77b7b81e32e9 ("add experimental tag to appropriate functions")
>>
>> After rte_eth_dev_attach() & rte_eth_dev_detach() APIs has been
>> deprecated in v18.08 eal APIs are only ones for hotplug operations
>> Commit 9f2be5b3db8b ("ethdev: deprecate attach and detach functions")
>>
>> These APIs are around for a few releases now and without an alternative,
>> removing the experimental tag from them.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Dup of http://patches.dpdk.org/patch/45791/ ?

Ahh, yes it is, I will mark this as Rejected, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH] eal: remove experimental from hotplug add/remove
@ 2018-10-02 11:04 Ferruh Yigit
  2018-10-02 10:08 ` Andrew Rybchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2018-10-02 11:04 UTC (permalink / raw)
  To: Rosen Xu, Tianfei zhang
  Cc: dev, Ferruh Yigit, Thomas Monjalon, Ian Stokes, arybchenko

rte_eal_hotplug_add() & rte_eal_hotplug_remove() APIs first added on
v17.08 as experimental
Commit a3ee360f4440 ("eal: add hotplug add/remove device")

When __rte_experimental tag created, APIs tagged with it on v18.02
Commit 77b7b81e32e9 ("add experimental tag to appropriate functions")

After rte_eth_dev_attach() & rte_eth_dev_detach() APIs has been
deprecated in v18.08 eal APIs are only ones for hotplug operations
Commit 9f2be5b3db8b ("ethdev: deprecate attach and detach functions")

These APIs are around for a few releases now and without an alternative,
removing the experimental tag from them.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Ian Stokes <ian.stokes@intel.com>
CC: arybchenko@solarflare.com
---
 drivers/raw/ifpga_rawdev/Makefile       |  1 -
 drivers/raw/ifpga_rawdev/meson.build    |  2 --
 lib/librte_eal/common/eal_common_dev.c  |  7 ++++---
 lib/librte_eal/common/include/rte_dev.h | 15 +++++----------
 lib/librte_eal/rte_eal_version.map      |  4 ++--
 5 files changed, 11 insertions(+), 18 deletions(-)

diff --git a/drivers/raw/ifpga_rawdev/Makefile b/drivers/raw/ifpga_rawdev/Makefile
index f3b9d5e61..c534f7f08 100644
--- a/drivers/raw/ifpga_rawdev/Makefile
+++ b/drivers/raw/ifpga_rawdev/Makefile
@@ -8,7 +8,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
 #
 LIB = librte_pmd_ifpga_rawdev.a
 
-CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -I$(RTE_SDK)/drivers/bus/ifpga
diff --git a/drivers/raw/ifpga_rawdev/meson.build b/drivers/raw/ifpga_rawdev/meson.build
index 67256872d..37896afba 100644
--- a/drivers/raw/ifpga_rawdev/meson.build
+++ b/drivers/raw/ifpga_rawdev/meson.build
@@ -11,5 +11,3 @@ deps += ['rawdev', 'pci', 'bus_pci', 'kvargs',
 sources = files('ifpga_rawdev.c')
 
 includes += include_directories('base')
-
-allow_experimental_apis = true
diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c
index 678dbcac7..ab3170ebc 100644
--- a/lib/librte_eal/common/eal_common_dev.c
+++ b/lib/librte_eal/common/eal_common_dev.c
@@ -127,8 +127,9 @@ int rte_eal_dev_detach(struct rte_device *dev)
 	return ret;
 }
 
-int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devname,
-			const char *devargs)
+int
+rte_eal_hotplug_add(const char *busname, const char *devname,
+		const char *devargs)
 {
 	struct rte_bus *bus;
 	struct rte_device *dev;
@@ -193,7 +194,7 @@ int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devn
 	return ret;
 }
 
-int __rte_experimental
+int
 rte_eal_hotplug_remove(const char *busname, const char *devname)
 {
 	struct rte_bus *bus;
diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
index b80a80598..2db506987 100644
--- a/lib/librte_eal/common/include/rte_dev.h
+++ b/lib/librte_eal/common/include/rte_dev.h
@@ -189,9 +189,6 @@ __rte_deprecated
 int rte_eal_dev_detach(struct rte_device *dev);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Hotplug add a given device to a specific bus.
  *
  * @param busname
@@ -204,13 +201,11 @@ int rte_eal_dev_detach(struct rte_device *dev);
  * @return
  *   0 on success, negative on error.
  */
-int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devname,
-			const char *devargs);
+int
+rte_eal_hotplug_add(const char *busname, const char *devname,
+		const char *devargs);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Hotplug remove a given device from a specific bus.
  *
  * @param busname
@@ -220,8 +215,8 @@ int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devn
  * @return
  *   0 on success, negative on error.
  */
-int __rte_experimental rte_eal_hotplug_remove(const char *busname,
-					  const char *devname);
+int
+rte_eal_hotplug_remove(const char *busname, const char *devname);
 
 /**
  * Device comparison function.
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index 73282bbb0..bd6ba15e3 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -265,6 +265,8 @@ DPDK_18.08 {
 DPDK_18.11 {
 	global:
 
+	rte_eal_hotplug_add;
+	rte_eal_hotplug_remove;
 	rte_strscpy;
 
 } DPDK_18.08;
@@ -292,8 +294,6 @@ EXPERIMENTAL {
 	rte_devargs_remove;
 	rte_devargs_type_count;
 	rte_eal_cleanup;
-	rte_eal_hotplug_add;
-	rte_eal_hotplug_remove;
 	rte_fbarray_attach;
 	rte_fbarray_destroy;
 	rte_fbarray_detach;
-- 
2.17.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: remove experimental from hotplug add/remove
  2018-10-02 10:23   ` Ferruh Yigit
@ 2018-10-08  2:58     ` Xu, Rosen
  0 siblings, 0 replies; 4+ messages in thread
From: Xu, Rosen @ 2018-10-08  2:58 UTC (permalink / raw)
  To: Yigit, Ferruh, Andrew Rybchenko, Zhang, Tianfei
  Cc: dev, Thomas Monjalon, Stokes, Ian



> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, October 02, 2018 18:24
> To: Andrew Rybchenko <arybchenko@solarflare.com>; Xu, Rosen
> <rosen.xu@intel.com>; Zhang, Tianfei <tianfei.zhang@intel.com>
> Cc: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; Stokes, Ian
> <ian.stokes@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] eal: remove experimental from hotplug
> add/remove
> 
> On 10/2/2018 11:08 AM, Andrew Rybchenko wrote:
> > On 10/2/18 2:04 PM, Ferruh Yigit wrote:
> >> rte_eal_hotplug_add() & rte_eal_hotplug_remove() APIs first added on
> >> v17.08 as experimental
> >> Commit a3ee360f4440 ("eal: add hotplug add/remove device")
> >>
> >> When __rte_experimental tag created, APIs tagged with it on v18.02
> >> Commit 77b7b81e32e9 ("add experimental tag to appropriate functions")
> >>
> >> After rte_eth_dev_attach() & rte_eth_dev_detach() APIs has been
> >> deprecated in v18.08 eal APIs are only ones for hotplug operations
> >> Commit 9f2be5b3db8b ("ethdev: deprecate attach and detach functions")
> >>
> >> These APIs are around for a few releases now and without an
> >> alternative, removing the experimental tag from them.
> >>
> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> > Dup of http://patches.dpdk.org/patch/45791/ ?
> 
> Ahh, yes it is, I will mark this as Rejected, thanks.

Just back from holiday, a long story of this patch and 45791 :)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-10-08  2:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-02 11:04 [dpdk-dev] [PATCH] eal: remove experimental from hotplug add/remove Ferruh Yigit
2018-10-02 10:08 ` Andrew Rybchenko
2018-10-02 10:23   ` Ferruh Yigit
2018-10-08  2:58     ` Xu, Rosen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).