From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3B7D45501; Wed, 26 Jun 2024 14:04:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C3AF43356; Wed, 26 Jun 2024 13:56:47 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id B2B2F42E95 for ; Wed, 26 Jun 2024 13:45:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719402315; x=1750938315; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tHE3XUSN5ATfol0iqZnjeKfCEqBwrH1u/PjLzMLAsrg=; b=BKzLlNjDy7vxT1qEyrkwZjmlaQz/szTIhnvdSBAbbA46uRBqC1xUs08p RVpOb+1zVoKcOgFAwgkJ+D4JZ8ZNd1vYydpbXPurYv7D0hlcfQj6NfHKd n9rO+iQqrOuVS8kO6FBy6JqTSEup3vbXhhJjsUbVKSZwaat/J8HtsJSQa k5/+quvtn/aS8fssu0skc/A0w9/iXPRIdwm80VsPxtFya74CEWuEH12kx SNGhlxY/V7zqkwM+sWSbxR2vJmdGqREklTcJnjXcx9by7XF48KJayXYCx vXXNz/EtdkJyKYU5ToI8fWAl7p1baZ3RM9drl7o33IcECHawkMq4pQjj9 g==; X-CSE-ConnectionGUID: V3RZsEMoSD6Jyx2eJ5hbbQ== X-CSE-MsgGUID: Em8Ts+jHRLqxDeh/8LYjFg== X-IronPort-AV: E=McAfee;i="6700,10204,11114"; a="38979527" X-IronPort-AV: E=Sophos;i="6.08,266,1712646000"; d="scan'208";a="38979527" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2024 04:45:13 -0700 X-CSE-ConnectionGUID: LWCzcKoZQ6S+lq3fAPtkDA== X-CSE-MsgGUID: tlvee74tRh+ZN2xDiL9FIg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,266,1712646000"; d="scan'208";a="43874245" Received: from unknown (HELO silpixa00401119.ir.intel.com) ([10.55.129.167]) by orviesa010.jf.intel.com with ESMTP; 26 Jun 2024 04:45:13 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Dan Nowlin , ian.stokes@intel.com, bruce.richardson@intel.com Subject: [PATCH v4 078/103] net/ice/base: support E830 in Topology AQ command Date: Wed, 26 Jun 2024 12:42:06 +0100 Message-ID: <0c312feff8feffccd3093773c7978b4292ff97fa.1719401848.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Dan Nowlin In E830, regarding the Get Tx Topology AQ command, there is a change in the way that the RD bit must be set. For E830, the RD bit must be cleared. Setting the RD bit for the E830 device was causing the Get Tx Topology command to fail. Fix it to clear RD bit for E830 device. Signed-off-by: Dan Nowlin Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ddp.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/base/ice_ddp.c b/drivers/net/ice/base/ice_ddp.c index d5d81db949..f82e5a387f 100644 --- a/drivers/net/ice/base/ice_ddp.c +++ b/drivers/net/ice/base/ice_ddp.c @@ -2298,11 +2298,16 @@ ice_get_set_tx_topo(struct ice_hw *hw, u8 *buf, u16 buf_size, if (buf) cmd->set_flags |= ICE_AQC_TX_TOPO_FLAGS_SRC_RAM | ICE_AQC_TX_TOPO_FLAGS_LOAD_NEW; + + desc.flags |= CPU_TO_LE16(ICE_AQ_FLAG_RD); } else { ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_get_tx_topo); cmd->get_flags = ICE_AQC_TX_TOPO_GET_RAM; + + if (!ice_is_e830(hw)) + desc.flags |= CPU_TO_LE16(ICE_AQ_FLAG_RD); } - desc.flags |= CPU_TO_LE16(ICE_AQ_FLAG_RD); + status = ice_aq_send_cmd(hw, &desc, buf, buf_size, cd); if (status) return status; -- 2.43.0